Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#34056] indexer does not work properly in languages with different decimal notation #4116

Closed
wants to merge 1 commit into from

Conversation

chrisdavenport
Copy link
Contributor

[#34056] indexer does not work properly in languages with different decimal notation

== Reproduce

Have a joomla site in a language that uses comma instead of a dot for decimal places (ex: Portuguese).

Turn on search indexer content plugin.

Edit a content item in the frontend and save.
It will appear an sql error like this

Column count doesn't match value count at row 1 SQL=INSERT INTO 29i8c_finder_tokens (term,stem,common,phrase,weight,context,language) VALUES ('a', 'a', 0, 0, 0,0667, 1, 'pt')

Note the "0,0667" it should be "0.0667" and the error is there.

[#34056] indexer does not work properly in languages with different decimal notation
@brianteeman
Copy link
Contributor

(updated title)

@brianteeman brianteeman changed the title Update mysql.php [#34056] indexer does not work properly in languages with different decimal notation Aug 15, 2014
@wilsonge
Copy link
Contributor

I guess this change is needed in the other two database files as well?

@brianteeman brianteeman changed the title [#34056] indexer does not work properly in languages with different decimal notation [#34056] indexer does not work properly in languages with different decimal notation Sep 1, 2014
@jissues-bot jissues-bot changed the title [#34056] indexer does not work properly in languages with different decimal notation indexer does not work properly in languages with different decimal notation Oct 17, 2014
@jissues-bot jissues-bot changed the title indexer does not work properly in languages with different decimal notation indexer does not work properly in languages with different decimal notation Oct 17, 2014
@brianteeman
Copy link
Contributor

Copied steps to reproduce from joomlacode


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4116.

@roland-d
Copy link
Contributor

roland-d commented Nov 8, 2015

Hello @chrisdavenport

Thank you for your contribution.

The last comment here was on 4th January 2015. So the question is, Is this issue/pull request still valid?
If no reply is received within 4 weeks we will close this issue.

Thanks for understanding!


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4116.

@zero-24
Copy link
Contributor

zero-24 commented Nov 10, 2015

Closing as this repo is removed. Here is a redo of the needed changes also for postgres and the mssql driver. Thanks @chrisdavenport

#8372

@zero-24 zero-24 closed this Nov 10, 2015
@joomla-cms-bot joomla-cms-bot changed the title indexer does not work properly in languages with different decimal notation [#34056] indexer does not work properly in languages with different decimal notation Nov 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants