Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indexer does not work properly in languages with different decimal notation thanks @chrisdavenport #8372

Closed
wants to merge 1 commit into from

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented Nov 10, 2015

[#34056] indexer does not work properly in languages with different decimal notation

== Reproduce

Have a joomla site in a language that uses comma instead of a dot for decimal places (ex: Portuguese).

Turn on search indexer content plugin.

Edit a content item in the frontend and save.
It will appear an sql error like this

Column count doesn't match value count at row 1 SQL=INSERT INTO 29i8c_finder_tokens (term,stem,common,phrase,weight,context,language) VALUES ('a', 'a', 0, 0, 0,0667, 1, 'pt')

Note the "0,0667" it should be "0.0667" and the error is there.


Redo this PR by @chrisdavenport: #4116

@waader
Copy link
Contributor

waader commented Nov 11, 2015

I was unabled to reproduce the sql error. Here is what I did:

  • installed current staging with testing data and english, german and portuguese language
  • switched frontend language to portuguese
  • enabled smart search content plugin
  • went to the frontend
  • logged in and edited and saved an article

Have I missed anything?

@zero-24
Copy link
Contributor Author

zero-24 commented Nov 11, 2015

Can You run The indexer The First time bevor go to The frontend?

What Can You find in The findet tokens table?

But hey maye it is fixed else were i'm not Sure but i Can check it maybe tomorrow

@astridx
Copy link
Contributor

astridx commented Nov 14, 2015

I think here is a patch for this issue: [#5318] - Fixing finder to format weight as non-locale float.

But:
I could not reproduce this error, too.

  1. ´I installed the current staging with English test data.
  2. Then I installed the German language files and activated them in the backend and in the frontend.
  3. After that I enabled smart search content plugin and build the index.
  4. Then I edited a lot of articles in the frontend.
  5. My tokens table was empty all the time.

@zero-24
Copy link
Contributor Author

zero-24 commented Nov 14, 2015

Ok maybe This is fixed Else where. Thanks for testing.

@zero-24 zero-24 closed this Nov 14, 2015
@zero-24 zero-24 deleted the finder_indexer branch November 14, 2015 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants