New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.0] AVIF support for media manager #41381
Conversation
Allow media manager to have AVIF files uploaded and rendered
@wilsonge You've changed the base.sql file for MySQL but not the one for PostgreSQL. This cannot be right. |
#35752 is just for the image list field (I'm not aware of anywhere we use that in core). But people would have needed to upload those files by hand. This PR specifically addresses media manager. Yes it will address #30666. However it will only address the AVIF part of #37669 (the original issue was a broader thing around document formats etc which obviously isn't covered here) |
Update?
|
Done! |
I can confirm this works. |
I have tested this item ✅ successfully on d0ec800 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41381. |
It works but doesn't produce a thumbnail in the media manager, and the instructions for adding .avif files are missing from the settings. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41381. |
is it possible that you server doesn't support av1? |
To test to see if your server supports avif see https://php.watch/versions/8.1/gd-avif |
Also to check if you use patchtester you will need to manually update the parameters in media manager |
thx |
Allow media manager to have AVIF files uploaded and rendered
Summary of Changes
AVIF is an alternative to webp in some circumstances (see https://www.smashingmagazine.com/2021/09/modern-image-formats-avif-webp/ for more info).
I've deliberately chosen to not add this to a SQL Update script so there are no security implications for sites who may have more restrictive upload policies. This will only apply to new sites.
Worth noting this is a better fit for J5 than J4.4 because the GD library support was only added in PHP 8.1 (although technically that doesn't stop people uploading the files themselves in J4.4 as web browser support already exists - it's just easier because they can be edited too) - https://php.watch/versions/8.1/gd-avif
Testing Instructions
Upload AVIF file. Before will be rejected and any files on the server won't be rendered. Afterwards they will be.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed