Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow standard sql #42032

Closed
wants to merge 1 commit into from
Closed

workflow standard sql #42032

wants to merge 1 commit into from

Conversation

alikon
Copy link
Contributor

@alikon alikon commented Oct 3, 2023

Pull Request for Issue #42031 .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

The issue has been reported for 4.3.4, so a fix should be done for the 4.4-dev branch and then be merged up to 5.0-dev.

@kochinc
Copy link
Contributor

kochinc commented Oct 3, 2023

There was a mistake in the join() call. Please see the revised commit at #42031.

@richard67
Copy link
Member

There was a mistake in the join() call. Please see the revised commit at #42031.

@kochinc Could you make a pull request from that commit? Just referring to it in an issue doesn’t make it usable yet.

@kochinc
Copy link
Contributor

kochinc commented Oct 3, 2023

There was a mistake in the join() call. Please see the revised commit at #42031.

@kochinc Could you make a pull request from that commit? Just referring to it in an issue doesn’t make it usable yet.

Done. See PR #42036.

@richard67
Copy link
Member

@alikon I think @kochinc 's PR #42036 is better because it removes the condition also from the where clause (besides adding it to the join like both PRs do. In addition his PR is already for 4.4-dev. I suggest to close this one here in favour of PR #42036 .

@alikon alikon closed this Oct 4, 2023
@alikon alikon deleted the patch-6 branch October 4, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants