Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There needs to be an option to disable dark mode in J5 Atum #42134

Closed
bebetteraperson opened this issue Oct 13, 2023 · 36 comments
Closed

There needs to be an option to disable dark mode in J5 Atum #42134

bebetteraperson opened this issue Oct 13, 2023 · 36 comments

Comments

@bebetteraperson
Copy link

After testing J5 and seeing there's no way to disable Dark mode other than in my OS settings, I find this to be a very large problem. I've found a components that aren't dark-mode friendly yet, including Akeeba backup. Expecting all developers to go back and redesign their products is not only asking too much, but most won't. This is a simple design issue that can be fixed by a plugin that can turn this feature off imo. Please consider shipping this with the first release as I can already expect the backlash. Thanks all

@toby07801
Copy link

Absolutely! Please add an option either in global settings / admin template settings / or per-user settings to disable dark mode or set the preferred behaviour. (On / Off / Automatic)

I, like many, have Windows default set to always be dark, but that does not mean I want this to to be affecting websites I visit. There needs to be an override!

The Joomla interface looks rather horrific a the moment using dark mode...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42134.

@brianteeman
Copy link
Contributor

interesting

@simbus82
Copy link
Contributor

Is dark mode really not configurable? In fact I also couldn't find an option but I thought it was due to the "beta state" of the DM. I use Chrome in dark mode, but I could never use Joomla's dark mode (or other backends where writing or managing content is important). Lot's of applications and websites now gives the choice "On/Off/Auto" for Dark Mode (if it exists at a style level).

@GASOLINE
Copy link

GASOLINE commented Oct 18, 2023

interesting

Sorry Brian,
It's not interesting. It's one more thing that makes me fall out of love with Joomla. Using Joomla since 2005 but lately I don't know what's happening. The migration to J4 was a nightmare and another change for my clients (the dark mode) is something they will question. It makes me look less professional.
There should ALWAYS be an option to choose dark/light mode. And the dark mode (that's off course personal) looks very aweful to me.
Hopefully it will be changed very soon, don't force options to us. I'm not willing to update clients at the moment.

@Fedik
Copy link
Member

Fedik commented Oct 18, 2023

I also couldn't find an option

It in your OS configuration.

In general.
It seems to me that people misunderstood the difference between "dark mode" and "dark theme" or not fully understand, when they enable "dark mode" in their OS. Additionally whole "dark mode" trending only make everything more confusing.

Joomla added "dark mode" to follow your OS preferences. There no way to overide @media (prefers-color-scheme: dark) Browser behavior.

@cod3blox
Copy link

It could be made an optional decision by putting @media (prefers-color-scheme: dark) rules in a seperate css file, which is only included when mayba a "Include Dark Mode" switch is enabled in the Atum template configuration.

At least now many of the external components are not ready for this mode. It renders parts of components unreadable (black fonts on dark backgrounds etc.).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42134.

@simbus82
Copy link
Contributor

I also couldn't find an option

It in your OS configuration.

In general. It seems to me that people misunderstood the difference between "dark mode" and "dark theme" or not fully understand, when they enable "dark mode" in their OS. Additionally whole "dark mode" trending only make everything more confusing.

Joomla added "dark mode" to follow your OS preferences. There no way to overide @media (prefers-color-scheme: dark) Browser behavior.

I have Windows 11 set in dark mode, and Chrome with a dark theme (desktop chrome doesn't have the dark mode). With these settings, Facebook, Instagram, X, etc., automatically switch to a dark mode. However, lot's of "modern" website has the option to let me choose, and I have selected the light mode despite my OS and browser settings.

Facebook
image

X - Twitter
image

Instagram
image

October CMS
image

@hikashop-nicolas
Copy link
Contributor

I was also surprised that there was no option to be able to change this. Abidding by the OS/browser behavior by default is nice, but providing the option to divert from it if necessary seems like a good idea.

@Fedik
Copy link
Member

Fedik commented Oct 18, 2023

You guys probably need to look for OS dark theme, not dark mode 😉

It could be made an optional decision by putting media (prefers-color-scheme: dark) rules in a seperate css file,

That can work

@simbus82
Copy link
Contributor

simbus82 commented Oct 18, 2023

You guys probably need to look for OS dark theme, not dark mode 😉

@Fedik The world is full of behavioral varieties, those who do marketing and develop products know this well.
Certain things are globally established. We have brought you some global examples.

That can work

Yep! It remains to be understood whether it is a function of the Joomla backoffice or specific to the template: I would expect to have a switch in my Admin user profile

@dgrammatiko
Copy link
Contributor

There no way to overide @media (prefers-color-scheme: dark) Browser behavior.

@Fedik actually that's not exactly true. I'm doing that (without extra CSS files) with Muta: https://muta.dgrammatiko.dev (which I offered to the project but probably rejected [tbh nobody even answered])

@Feenders
Copy link

The Autum theme is based on Bootstrap 5. Indeed, it uses the BS5 mechanism for auto dark mode.

Look at the switch in the upper right corner on the bootstrap site.
https://getbootstrap.com/
It just changes the attribute of the root-html tag from data-bs-theme="dark" to data-bs-theme="light".

I am pretty sure it will only need some extra css to add this functionality to the template.

The dark bootstrap admin theme looks awfully and irritating. I am pretty sure we will not update any site to joomla 5 if it stays like this.

@GASOLINE
Copy link

There no way to overide @media (prefers-color-scheme: dark) Browser behavior.

@Fedik actually that's not exactly true. I'm doing that (without extra CSS files) with Muta: https://muta.dgrammatiko.dev (which I offered to the project but probably rejected [tbh nobody even answered])

Thanks, That's what we want. But I can't get it to display in light mode. See no option and no slider.

@dgrammatiko
Copy link
Contributor

But I can't get it to display in light mode. See no option and no slider.

This might help:
Screenshotx

@GASOLINE
Copy link

GASOLINE commented Oct 22, 2023

But I can't get it to display in light mode. See no option and no slider.

This might help:

The issue was I need to log out and login again. Than I have that option otherwise I got an error I'm not allowed to see that page. Joomla is very annoying lately. I use it for myself and clients since 2005 but I start to fall out of love.

It's unacceptable Joomla did not give us that option in the standard admin template. I think the wrong people are making the decisions at the moment.

@dgrammatiko
Copy link
Contributor

The issue was I need to log out and login again. Than I have that option otherwise I got an error I'm not allowed to see that page.

The part that you need to logout/login is a strange behaviour. The other one also annoys me...

@GASOLINE
Copy link

GASOLINE commented Oct 22, 2023

The issue was I need to log out and login again. Than I have that option otherwise I got an error I'm not allowed to see that page.

The part that you need to logout/login is a strange behaviour. The other one also annoys me...

I see that the logout/login issue was there also in J3 already. So something was/is going wrong there but not a major thing if you know what to do.
Anyway, thanks for the template. It's very helpful!!

@dgrammatiko
Copy link
Contributor

So something was/is going wrong there but not a major thing if you know what to do.

Do you mind opening an issue with the steps and the expected/actual result?
Thanks

@GASOLINE
Copy link

So something was/is going wrong there but not a major thing if you know what to do.

Do you mind opening an issue with the steps and the expected/actual result? Thanks

It's not an issue with your template, I also have this on other Joomla 5 sites with standard templates only.

image

@jjnxpct
Copy link

jjnxpct commented Oct 23, 2023

I agree there should be an option to disable the automatic dark mode based on the OS settings. Also, I think there shlould be some more fine-tuning in the dark mode for it to work smoothly. The darkblue and black/ grey are not very comaptible and there are still a lot of parts that are to bright (like the woarnings, but also notification badges).

Also some developers create there own backend interface, not using BS5. So now there is a huge clash with those interfaces and the Joomla interface. I would prefer all developers use the BS5 way of doing things, but not all do. And maybe we should allow those developers to adapt to this new dark theme for a bit longer so the can adapt to this?

So I would suggest:

  • Add an option to choose light or dark mode (or 'follow OS')
  • Default to 'Light', at least until the dark mode has been is improved. After that defaulting to OS might be OK.

@dgrammatiko
Copy link
Contributor

I've landed the PHP part for this with: #42209
The SCSS changes depend on #42010 which is still WIP

@Fedik
Copy link
Member

Fedik commented Oct 26, 2023

There is a PR #42221, if someone is interesting to have it, then please help with that. Thanks.

@Fedik Fedik closed this as completed Oct 26, 2023
@it-basixs
Copy link

Hello.

You can use these instructions to use a button to change the dark mode.
Ihr könnt diese Anleitung nutzen, um eine Schaltfläche zum Umstellen des Darkmode zu verwenden.

Your text to link here...


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42134.

@VladimirHot
Copy link

You can use these instructions to use a button to change the dark mode.
Ihr könnt diese Anleitung nutzen, um eine Schaltfläche zum Umstellen des Darkmode zu verwenden.

Your text to link here...

The best solution that can be applied. It works perfectly! The guys from the Joomla Team need to take it as a standard module.

@Feenders
Copy link

Thank you. The solution from it-basixs is easy, small and works like a flaw.

Maybe you should make a pull request.

But anyway, Joomla5 is not yet an option for productive use.
The compatibility plugin makes it clear. Joomla is under such heavy development that even the core components are not compatible with changes.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42134.

@brianteeman
Copy link
Contributor

The compatibility plugin makes it clear. Joomla is under such heavy development that even the core components are not compatible with changes.

Really? Thats news to me!

@chmst
Copy link
Contributor

chmst commented Nov 28, 2023

The compatibility plugin makes it clear. Joomla is under such heavy development that even the core components are not compatible with changes.

Which one?

@Feenders
Copy link

Really? Thats news to me!

Try it ... try to disable the [Behaviour - Backward Compatibility] plugin in Joomla 4 or 5!

Make a Database backup first!

@brianteeman
Copy link
Contributor

I have live sites running without that plugin

@chmst
Copy link
Contributor

chmst commented Nov 28, 2023

My own sites are running without this plugin. But I have no 3rd party extensions except my own which are J5.

@fgsw
Copy link

fgsw commented Nov 28, 2023

Maybe @Feenders means this (happens after disable plugin Behaviour - Backward Compatibility):

Untitled1

Its a site without 3rd party extension, test on J5.0.0 and J5.0.1.

@alikon
Copy link
Contributor

alikon commented Nov 28, 2023

if you can detail step by step how to reproduce it, maybe better to open a new proper issue
... this sounds like a dark mode issue not a plugin Behaviour - Backward Compatibility issue
my 0.02€

@brianteeman
Copy link
Contributor

The class JPlugin does NOT exist anywhere in Joomla 5. So the only way it can be present and produce the error is by having an installed extension

@alikon
Copy link
Contributor

alikon commented Nov 28, 2023

so did you mean that somethings has not been reported from the pre-update check ?
cause i've tryed to reproduce it , without success, with some extensions but probably with not a reproducible one;
that's why i'm asking for step by step info

@fgsw
Copy link

fgsw commented Nov 28, 2023

@brianteeman Its true, stack say it is the cloudpanel by CloudAccess:

Untitled

I wasn't aware that this plugin is installed as i started the site via https://launch.joomla.org/.

@jjnxpct
Copy link

jjnxpct commented Jan 3, 2024

Back to the dark mode switch: I tested the custom module solution to be able to swicht from dark to light mode. This is a nice solution, for now. I do hope there will be a more permanent fix (added option) for this in Joomla. I browsed through some issues and I think there something brewing? #42221

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests