Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Cleanup input options #42166

Merged
merged 5 commits into from
Nov 8, 2023
Merged

Conversation

wilsonge
Copy link
Contributor

@wilsonge wilsonge commented Oct 18, 2023

Summary of Changes

When the live site parameter was added for some reason rather than adding just that parameter into the existing definition we re-created the entire definition

Testing Instructions

Check all global options are still available when using the CLI (such as verbosity and the live site parameter). There should be no changes but less code (yay!)

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@richard67
Copy link
Member

Remove the use Symfony\Component\Console\Input\InputArgument; in line 57 because it became obsolete with the other changes, that's why PHPCS fails in drone (new rule for unnecessary use statements).

@HLeithner HLeithner changed the title [5.0] Cleanup input options [5.1] Cleanup input options Oct 18, 2023
@HLeithner HLeithner changed the base branch from 5.0-dev to 5.1-dev October 18, 2023 18:22
@HLeithner
Copy link
Member

rebased it to 5.1 because it's not a bug that needs to be fixed, it's an improvement

@HLeithner
Copy link
Member

conflict's will be solved by upmerging 5.0 to 5.1 soon

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Oct 18, 2023
@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester labels Oct 22, 2023
@Quy
Copy link
Contributor

Quy commented Oct 27, 2023

I have tested this item ✅ successfully on 4e2c60a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42166.

1 similar comment
@alikon
Copy link
Contributor

alikon commented Nov 4, 2023

I have tested this item ✅ successfully on 4e2c60a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42166.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester labels Nov 4, 2023
@alikon
Copy link
Contributor

alikon commented Nov 4, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42166.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 4, 2023
@joomla-cms-bot joomla-cms-bot removed Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester labels Nov 4, 2023
@LadySolveig LadySolveig merged commit 4dd90b4 into joomla:5.1-dev Nov 8, 2023
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 8, 2023
@LadySolveig
Copy link
Contributor

Thank you @wilsonge !

@Quy Quy added this to the Joomla! 5.1.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants