-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5][webservices] add filter by search #42519
Conversation
Sorry I'm new adding feature requests. You mentioned me to test I don't know how to test. There's a new Joomla 4 version?? |
iirc new feature cannot go in 4.x series, if the release lead consider this a bug fix i will do it in the 4.x branch |
I have downloaded CategoriesController and TagsController and tested locally and it works fine. Please, we need this filter search for the 4.x branch in a new version, thanks This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42519. |
I have tested this item ✅ successfully on c8da438 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42519. |
@aberenguer78 could you mark the PR as tested by you in the issue tracker? If you do, then we can mark this as ready to commit and this PR could already be in Joomla 5.1. |
#42503 It's closed. I tested locally on 15th of December locally and it works fine. You, have my comments here : |
I have tested this item ✅ successfully on c8da438 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42519. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42519. |
Thank you @alikon and also for testing and support @aberenguer78 @walturbo @Hackwar |
Pull Request for Issue #42503 .
Summary of Changes
added filter bt search
Testing Instructions
{{base_path}}/api/index.php/v1/tags?filter[search]=text
{{base_path}}/api/index.php/v1/content/categories?filter[search]=text
Actual result BEFORE applying this Pull Request
N/A
Expected result AFTER applying this Pull Request
response take care of serch filter
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed