[5.1] CLI: Core Update - improve output #42601
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
The output of the CLI command to update the Joomla core currently is producing very bad output. The way the progressbar is used, all output is more or less deleted right away again and the progressbar is also not really very progressy...
This PR changes the output to keep all messages which were previously written on the screen and to actually display a progressbar.
Testing Instructions
libraries/src/Console/UpdateCoreCommand.php
and add$error = 0;
in the line below.php cli/joomla.php core:update
Actual result BEFORE applying this Pull Request
Output is really not helpfull.
Expected result AFTER applying this Pull Request
Output is a lot more verbose.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed