Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] CLI: Core Update - improve output #42601

Merged
merged 2 commits into from Jan 13, 2024

Conversation

Hackwar
Copy link
Member

@Hackwar Hackwar commented Jan 3, 2024

Summary of Changes

The output of the CLI command to update the Joomla core currently is producing very bad output. The way the progressbar is used, all output is more or less deleted right away again and the progressbar is also not really very progressy...

This PR changes the output to keep all messages which were previously written on the screen and to actually display a progressbar.

Testing Instructions

  1. See how the core update on the CLI looks right now.
  2. Apply the changes from this PR.
  3. Change the version in `/libraries/src/Version.php to a lower version like 5.0.0.
  4. Since your DB structure will be a mismatch to our perceived version and the update, we have to comment out the schema check on line 195 of libraries/src/Console/UpdateCoreCommand.php and add $error = 0; in the line below.
  5. Run php cli/joomla.php core:update

Actual result BEFORE applying this Pull Request

Output is really not helpfull.

Expected result AFTER applying this Pull Request

Output is a lot more verbose.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@alikon
Copy link
Contributor

alikon commented Jan 4, 2024

I have tested this item ✅ successfully on a3c7358


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42601.

@dautrich
Copy link

dautrich commented Jan 9, 2024

I have tested this item ✅ successfully on a3c7358


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42601.

@dautrich
Copy link

dautrich commented Jan 9, 2024

Before application of the patch:
grafik

Change to UpdateCoreCommand.php:
grafik
Remark: I suppose item 4 in your Testing Instructions should read $errors = 0

After application of the patch:
grafik

@alikon
Copy link
Contributor

alikon commented Jan 9, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42601.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 9, 2024
@Razzo1987 Razzo1987 merged commit 67c7a8d into joomla:5.1-dev Jan 13, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 13, 2024
@Razzo1987
Copy link
Contributor

Thanks!

@Quy Quy added this to the Joomla! 5.1.0 milestone Jan 14, 2024
@Hackwar Hackwar deleted the 5.1-cli-core-update branch January 15, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants