Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] text not visible (error_login) #42616

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

brianteeman
Copy link
Contributor

Pull Request for Issue #42600 .

Summary of Changes

add class text-dark to the h1 to force it to be visible

Testing Instructions

do not log in to the backend
visit https://example.tl/administrator/index.php?option=com_admin&view=sysinfo&format=text

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@Quy
Copy link
Contributor

Quy commented Jan 5, 2024

It will be a regression with v5 in dark mode.

42616-dark-mode

@brianteeman
Copy link
Contributor Author

The PR is for j4 ;)

@dautrich
Copy link

dautrich commented Jan 5, 2024

I have successfully tested this PR on J4.4 Stable.
Should I use the issue tracker to document my successful test?

@fgsw
Copy link

fgsw commented Jan 6, 2024

I have tested this item ✅ successfully on 87dfabe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42616.

1 similar comment
@dautrich
Copy link

dautrich commented Jan 6, 2024

I have tested this item ✅ successfully on 87dfabe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42616.

@alikon
Copy link
Contributor

alikon commented Jan 6, 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42616.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 6, 2024
@MacJoom MacJoom self-assigned this Jan 10, 2024
@MacJoom MacJoom added this to the Joomla 4.4.3 milestone Jan 10, 2024
@MacJoom MacJoom enabled auto-merge (squash) January 10, 2024 17:14
@MacJoom MacJoom merged commit db66279 into joomla:4.4-dev Jan 10, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2024
@brianteeman brianteeman deleted the error branch January 10, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants