Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI - Use the right data type when saving global configuration values #42640

Open
richard67 opened this issue Jan 10, 2024 · 0 comments
Open
Labels

Comments

@richard67
Copy link
Member

Is your feature request related to a problem? Please describe.

Currently the CLI command config:set changes all integer values to string values when saving changes, regardless whether these values were changed or not.

Values which seem to be boolean because they have content "true" or "false" are saved as booleans, but that is not really safe.

See the comment here: #42618 (comment) .

Describe the solution you'd like

The CLI should save configuration in the same way as the administrator does, so the data types of the particular values are determined by the administrator/components/com_config/forms/application.xml file or by the existing configuration.php file.

The should not be a data type conversion based on the content of a value like it is currently done for boolean here https://github.com/joomla/joomla-cms/blob/5.0-dev/libraries/src/Console/SetConfigurationCommand.php#L445-L450 .

Additional context

See also issue #42612 and PR #42618 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants