Redirect component: Wrong error message shown when not collecting URLs

[kauffeld]

I am using German Language in Joomla so some English term may not be correct.

Steps to reproduce the issue

In Joomla administration dashboard go to System - Plugins
Select System - Redirect
Deactivate Collect URLs
Save and close

Go to Redirects

Expected result

A warning message with Id 'COM_REDIRECT_COLLECT_MODAL_URLS_DISABLED' should occur.

Actual result

An error message with Id 'COM_REDIRECT_PLUGIN_MODAL_DISABLED' occurs.

System information (as much as possible)

Error occurs with Joomla 5.1.0. With 5.0.3 the message was ok.

Additional comments

When collection URLs the message is ok.

[brianteeman]

This is a bug, Looking into it now

[brianteeman]

This is how it should be - note that the message is coompletely wrong in test 3 and in test 2 it should be info not warning

This needs to bec checked both with existing redirects and in the emptystate view

These errors come from #42447 - sorry @Fedik I am not following the logic of your new code or I would have done a PR

Test 1 - Redirect Plugin Disabled

Current Message

The Redirect System Plugin is disabled. It needs to be enabled for this component to work.

Correct Message

The Redirect System Plugin is disabled. It needs to be enabled for this component to work.

Test 2 - Redirect Plugin Enabled Collect Url Enabled

Current Message

The Redirect Plugin is enabled. The option 'Collect URLs' is enabled.

Correct Message

The Redirect Plugin is enabled. The option 'Collect URLs' is enabled.

Test 3 - Redirect Plugin Enabled Collect Url Disabled

Current Message

The Redirect System Plugin is disabled. It needs to be enabled for this component to work.

Correct Message

The Redirect Plugin is enabled. The 'Collect URLs' option in the Redirect System Plugin is disabled. Error page URLs will not be collected by this component.

[kauffeld]

Ok, that's what I expect and that's how it was before Joomla 5.1.0

[Fedik]

I have moved the message from controller to the layout.
Not sure why I have change "notice" to "warning", maybe mixed up something.
I will make PR later.

[brianteeman]

its your logic for determining if the plugin is enabled or not that I dont understand

[Fedik]

Yes, I mean, it should stay the same as before.
I not remember why I did change message type.

[brianteeman]

I dont think you realised you had. I think the logic you ghave for testing what is enabled etc is wrong and thats what confused you. It sure as hell confused me.

[Fedik]

Please test #43402