Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.1] Use Dialog for Plugin editing #42447

Merged
merged 7 commits into from Jan 10, 2024
Merged

Conversation

Fedik
Copy link
Member

@Fedik Fedik commented Dec 2, 2023

Summary of Changes

Use Dialog for Plugin editing modals.
Similar to #42423

Testing Instructions

Run npm install.
Disable plugins:
Content - Smart Search
System - Redirect

Visit Finder Index overview, you should see a message about disable pplugin, with link to edit it. Try to use it for change plugin state.

Visit Redirects overview, you should see a message about disable pplugin, with link to edit it. Try to use it for change plugin state.

Actual result BEFORE applying this Pull Request

Works with BS modal

Expected result AFTER applying this Pull Request

Works with Joomla Dialog

Link to documentations

Please select:

References:

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev labels Dec 2, 2023
@Fedik Fedik added the Feature label Dec 2, 2023
@Quy
Copy link
Contributor

Quy commented Dec 15, 2023

I have tested this item ✅ successfully on 974f595


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42447.

1 similar comment
@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 974f595


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42447.

@alikon
Copy link
Contributor

alikon commented Dec 23, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42447.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 23, 2023
@LadySolveig LadySolveig added this to the Joomla! 5.1.0 milestone Jan 5, 2024
@LadySolveig LadySolveig merged commit 72942f6 into joomla:5.1-dev Jan 10, 2024
3 checks passed
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 10, 2024
@LadySolveig
Copy link
Contributor

Thank you @Fedik and also for testing @Quy @viocassel

@Fedik Fedik deleted the popup-plugin-edit branch January 10, 2024 15:01
alikon added a commit to alikon/joomla-cms that referenced this pull request Jan 14, 2024
alikon added a commit to alikon/joomla-cms that referenced this pull request Jan 14, 2024
alikon added a commit to alikon/joomla-cms that referenced this pull request Jan 14, 2024
alikon added a commit to alikon/joomla-cms that referenced this pull request Jan 14, 2024
@brianteeman
Copy link
Contributor

This is completely wrong - at least for the redirects. It stops checking if the plugin is enabled or disabled. it only checks if the plugin is installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.1-dev
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants