Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If we logged out from front end then multiple validation message is displayed. #4784

Closed
amithadkar opened this issue Oct 17, 2014 · 25 comments
Closed

Comments

@amithadkar
Copy link

amithadkar commented Oct 17, 2014

Steps to reproduce the issue

  1. In User Manager options make sure that Frontend User Parameters is set to hide
  2. Open front end of joomla.
  3. Login using admin with valid credentials.
  4. Click on logout button.
  5. Verify the results.

Expected result

Only one validation message is displayed

Actual result

Validation message is displayed twice.

System information (as much as possible)

PHP Built On Windows NT 6.2 build 9200
Database Version 5.6.12-log
Database Collation utf8_general_ci
PHP Version 5.4.12
Web Server Apache/2.4.4 (Win64) PHP/5.4.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.3.7-dev Development [ Ember ] 01-October-2014 02:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0

screen shot 2014-10-17 at 08 49 41#### Additional comments

@allanlhansen
Copy link

Couldn't reproduce this.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@aDaneInSpain
Copy link
Contributor

@amithadkar Do you have lastpass installed or something similar that logs you in automatically? I did and saw the same issue, but not when disabling Lastpass.

Also the issue only occurred when logging out from a page that required me to be logged in to see.

@revers28
Copy link

@test can't reproduce this issue on Chrome using Apache+mod_php/MySql Joomla 3.3.7dev.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@sandstorm871
Copy link

I tested this on FF & Chrome - With & Without Last Pass enabled and I could NOT reproduce this error any way at all?

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@aDaneInSpain
Copy link
Contributor

Yeah, for Lastpass to mess it up you must have enabled AUTO login AND be on a page that requires you to be logged in when logging out. Either way, no one seems to be able to replicate the issue (without Lastpass).

@brianteeman
Copy link
Contributor

I am going to set this to information required for now to see if anyone else reports anything or provides a second report of this issue. Otherwise it will be closed in a few weeks.

YThanks everyone for testing

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@omkarambre
Copy link

I have debugged the code, Print $messages in libraries\joomla\document\html\renderer\message.php in private function getData() . When i print $messages i get

Array ( [0] => Array ( [message] => Please login first [type] => message ) [1] => Array ( [message] => Please login first [type] => message ) )

I debugged the same code on another system and i get $messages as blank array. I think the reason for not getting the message must be the absence of data in the array. If message data is blank in array then also its an issue. screen shot 2014-10-18 at 02 29 04

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@amithadkar
Copy link
Author

To reproduce the above issue please follow the below steps:

  1. Open the front end of joomla
  2. Login with the admin.
  3. Click on "Edit Profile" page.
  4. Now click on Logout button.
  5. Verify the validation message.

    This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@brianteeman
Copy link
Contributor

tried that and cant see any issue

On 18 October 2014 08:38, amithadkar notifications@github.com wrote:

To reproduce the above issue please follow the below steps:

  1. Open the front end of joomla
  2. Login with the admin.
  3. Click on "Edit Profile" page.
  4. Now click on Logout button.
  5. Verify the validation message.

This comment was created with the J!Tracker Application
https://github.com/joomla/jissues at issues.joomla.org/joomla-cms/4784
http://issues.joomla.org/tracker/joomla-cms/4784.


Reply to this email directly or view it on GitHub
#4784 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@amithadkar
Copy link
Author

Please refer the screenshot for every step.

  1. Create menu "Edit user profile" from back end.-- Screenshot 1
  2. Login on front end using "admin" user.-- Screenshot 2
  3. Click on "Edit user profile menu".-- Screenshot 3
  4. Click on Logout button.-- Screenshot 4

If you cannot see any confirmation message then that will also be an Issue. Either you will see two confirmation message or you will not able see any confirmation message. In both case it is an issue.

screenshot 1
screenshot 2
screenshot 3
screenshot 4

@brianteeman
Copy link
Contributor

Thank you for your detailed instructions it really helped and with this
exact set up using the brochure sample data I was able to replicate the
issue.

So then I was able to see what was different with an install with no sample
data and testing data where I couldnt replicate it and this install to
track down the problem.

And I did
In the User Manager Options there is a setting
Frontend User Parameters hide/show

When they are hidden you get the error
When they are shown you dont

So that is where the problem lies - perhaps you are able to come up with a
fix now we know what is causing it and how to replicate it

On 18 October 2014 09:58, amithadkar notifications@github.com wrote:

Please refer the screenshot for every step.

  1. Create menu "Edit user profile" from back end.-- Screenshot 1
  2. Login on front end using "admin" user.-- Screenshot 2
  3. Click on "Edit user profile menu".-- Screenshot 3
  4. Click on Logout button.-- Screenshot 4

If you cannot see any confirmation message then that will also be an
Issue. Either you will see two confirmation message or you will not able
see any confirmation message. In both case it is an issue.

[image: screenshot 1]
https://cloud.githubusercontent.com/assets/9278202/4689056/cab62820-56a4-11e4-85ff-cf363834312c.png
[image: screenshot 2]
https://cloud.githubusercontent.com/assets/9278202/4689057/cabcb0aa-56a4-11e4-8862-a30806cb2716.png
[image: screenshot 3]
https://cloud.githubusercontent.com/assets/9278202/4689059/cac1f8a8-56a4-11e4-92b3-38e4d6da4667.png
[image: screenshot 4]
https://cloud.githubusercontent.com/assets/9278202/4689058/cac0d3e2-56a4-11e4-83b7-6401ca927345.png


Reply to this email directly or view it on GitHub
#4784 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@brianteeman
Copy link
Contributor

I am going to edit your original post with the steps to reproduce so that people will know to change that setting

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@durgesh4
Copy link

Unable to reproduce this issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@aDaneInSpain
Copy link
Contributor

I can reproduce this by logging out from any page that requires login to view. Here is what I think is happening.

After logging out, Joomla tries to redirect to the same page you are on, but you are no longer allowed to see that page (as it requires login). The router then somehow redirects to another page you are also not allowed to see and so you get the "stacked" messages.

I would argue that seeing even one "Please login first" message after logging out is an error. So 0, 1 or 2 are all wrong. Instead the message should be "You have successfully logged out" or similar.

I recommend that the solution is that the logout functionality checks the requirements of the redirect page before attempting to redirect to it to avoid this issue. And then simply redirect to the frontpage if the requested page requires you to be logged in.

@ChuckNorrison
Copy link

I got the same issue. Frontend User Parameters are hidden in my setup.

@fancyFranci
Copy link
Contributor

I tested the problem with Joomla 3.4.4-dev and I got the error message "Please log in first" only once not twice. It doesnt matter if the Frontend User Parameters is set on "show" or "hide". Maybe it was fixed with the update?
Should the redirect to the original page get fixed nevertheless?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@ChuckNorrison
Copy link

in this case the multiple validation message is fixed.

I got the mulitple validation message if i logout in another tab and then click on profile menu item in the logged in tab.

  • Login your site
  • dublicate the tab and logout
  • click on Profile menu item in the first tab

@amithadkar
Copy link
Author

Issue is still exist on 3.4.3 version.
Steps to reproduce are already as stated above.

@pe7er
Copy link
Contributor

pe7er commented May 7, 2016

This is a known issue with a Joomla installation using the brochure sample data. As it seems specifically related to the brochure sample data, and the sample data is being reviewed by PLT, I'm closing this issue.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@zero-24
Copy link
Contributor

zero-24 commented May 7, 2016

Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/4784

@amithadkar
Copy link
Author

@pe7er Kindly provide the appropriate patch and then close this issue else reopen it.

@zero-24 Please reopen this issue.

@brianteeman Kindly look into this.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784.

@amithadkar
Copy link
Author

@brianteeman Can you please give me update?

@zero-24
Copy link
Contributor

zero-24 commented Oct 3, 2016

I can not reproduce this on 3.7.0-dev also with the brochure sample data

@amithadkar
Copy link
Author

@zero-24 I have tested on joomla 3.6.2 and it is fixed.

@zero-24
Copy link
Contributor

zero-24 commented Oct 5, 2016

Thanks for the feedback 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests