-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If we logged out from front end then multiple validation message is displayed. #4784
Comments
Couldn't reproduce this. |
@amithadkar Do you have lastpass installed or something similar that logs you in automatically? I did and saw the same issue, but not when disabling Lastpass. Also the issue only occurred when logging out from a page that required me to be logged in to see. |
@test can't reproduce this issue on Chrome using Apache+mod_php/MySql Joomla 3.3.7dev. |
I tested this on FF & Chrome - With & Without Last Pass enabled and I could NOT reproduce this error any way at all? |
Yeah, for Lastpass to mess it up you must have enabled AUTO login AND be on a page that requires you to be logged in when logging out. Either way, no one seems to be able to replicate the issue (without Lastpass). |
I am going to set this to information required for now to see if anyone else reports anything or provides a second report of this issue. Otherwise it will be closed in a few weeks. YThanks everyone for testing |
I have debugged the code, Print $messages in libraries\joomla\document\html\renderer\message.php in private function getData() . When i print $messages i get Array ( [0] => Array ( [message] => Please login first [type] => message ) [1] => Array ( [message] => Please login first [type] => message ) ) I debugged the same code on another system and i get $messages as blank array. I think the reason for not getting the message must be the absence of data in the array. If message data is blank in array then also its an issue. |
To reproduce the above issue please follow the below steps:
|
tried that and cant see any issue On 18 October 2014 08:38, amithadkar notifications@github.com wrote:
Brian Teeman |
Please refer the screenshot for every step.
If you cannot see any confirmation message then that will also be an Issue. Either you will see two confirmation message or you will not able see any confirmation message. In both case it is an issue. |
Thank you for your detailed instructions it really helped and with this So then I was able to see what was different with an install with no sample And I did When they are hidden you get the error So that is where the problem lies - perhaps you are able to come up with a On 18 October 2014 09:58, amithadkar notifications@github.com wrote:
Brian Teeman |
I am going to edit your original post with the steps to reproduce so that people will know to change that setting |
Unable to reproduce this issue. |
I can reproduce this by logging out from any page that requires login to view. Here is what I think is happening. After logging out, Joomla tries to redirect to the same page you are on, but you are no longer allowed to see that page (as it requires login). The router then somehow redirects to another page you are also not allowed to see and so you get the "stacked" messages. I would argue that seeing even one "Please login first" message after logging out is an error. So 0, 1 or 2 are all wrong. Instead the message should be "You have successfully logged out" or similar. I recommend that the solution is that the logout functionality checks the requirements of the redirect page before attempting to redirect to it to avoid this issue. And then simply redirect to the frontpage if the requested page requires you to be logged in. |
I got the same issue. Frontend User Parameters are hidden in my setup. |
I tested the problem with Joomla 3.4.4-dev and I got the error message "Please log in first" only once not twice. It doesnt matter if the Frontend User Parameters is set on "show" or "hide". Maybe it was fixed with the update? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784. |
in this case the multiple validation message is fixed. I got the mulitple validation message if i logout in another tab and then click on profile menu item in the logged in tab.
|
Issue is still exist on 3.4.3 version. |
This is a known issue with a Joomla installation using the brochure sample data. As it seems specifically related to the brochure sample data, and the sample data is being reviewed by PLT, I'm closing this issue. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784. |
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/4784 |
@pe7er Kindly provide the appropriate patch and then close this issue else reopen it. @zero-24 Please reopen this issue. @brianteeman Kindly look into this. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4784. |
@brianteeman Can you please give me update? |
I can not reproduce this on 3.7.0-dev also with the |
@zero-24 I have tested on joomla 3.6.2 and it is fixed. |
Thanks for the feedback 👍 |
Steps to reproduce the issue
Expected result
Only one validation message is displayed
Actual result
Validation message is displayed twice.
System information (as much as possible)
PHP Built On Windows NT 6.2 build 9200
Database Version 5.6.12-log
Database Collation utf8_general_ci
PHP Version 5.4.12
Web Server Apache/2.4.4 (Win64) PHP/5.4.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.3.7-dev Development [ Ember ] 01-October-2014 02:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0
#### Additional comments
The text was updated successfully, but these errors were encountered: