MSSQL: Joomla! update for test fails

[sovainfo]

Running J336 wanting to use Joomla! Update to test 337-dev it will fail.

Error: 42000 [Microsoft][SQL Server Native Client 11.0][SQL Server]A nested INSERT, UPDATE, DELETE, or MERGE statement must have an OUTPUT clause.SQL=SELECT * FROM ( UPDATE [j336_extensions] SET [params] = '{"mediaversion":"a0029d5a3035565db1f2f0ddb93da8a6"}' WHERE [type] = 'library' AND [element] = 'joomla') _myResults WHERE RowNumber BETWEEN 1 AND 0

Again a problem due to processLimit in libraries/joomla/database/query.php. Applies to all RDBMS's but only MSSQL has this complex implementation.

FIX: Make sure to only processLimit for SELECT statements! Move the lines:
if ($this instanceof JDatabaseQueryLimitable)
{
$query = $this->processLimit($query, $this->limit, $this->offset);
}
from just before: return $query
to the case "select" just before the break.
Don't forget to add " && ($this->limit > 0 || $this->offset > 0)" to the condition in the if. Between the e and ).

Applying these changes should allow you to refresh on the .finalise error.

[Bakual]

Please see #4870

[Bakual]

Closing as fixed with #5293