SQL Azure updates. #5293
SQL Azure updates. #5293
Conversation
pmorrisarctg
commented
Dec 2, 2014
pmorrisarctg
commented
- Can now install on MS SQL
- Will create a SQL Server DB if one does not exist
- Can run the CMS and Admin on SQL Server
- Can now install on MS SQL - Will create a SQL Server DB if one does not exist - Can run the CMS and Admin on SQL Server
|
The original pull request that had merge issues due to other developers fixing issues in the same file is here. #3751 That request has merge issues. This one should not. |
| @@ -275,7 +331,7 @@ public function processLimit($query, $limit, $offset = 0) | |||
| $rowNumberText = ', ROW_NUMBER() OVER (' . $orderBy . ') AS RowNumber FROM '; | |||
|
|
|||
| $query = preg_replace('/\sFROM\s/i', $rowNumberText, $query, 1); | |||
| $query = 'SELECT * FROM (' . $query . ') _myResults WHERE RowNumber BETWEEN ' . $start . ' AND ' . $end; | |||
| //$query = 'SELECT * FROM (' . $query . ') _myResults WHERE RowNumber BETWEEN ' . $start . ' AND ' . $end; | |||
There was a problem hiding this comment.
Instead of commenting the line you should remove it - please
There was a problem hiding this comment.
Completed. Thank you.
Patrick
From: Brian Teeman [mailto:notifications@github.com]
Sent: Tuesday, December 02, 2014 5:43 PM
To: joomla/joomla-cms
Cc: pmorrisarctg
Subject: Re: [joomla-cms] SQL Azure updates. (#5293)
In libraries/joomla/database/query/sqlsrv.php:
@@ -275,7 +331,7 @@ public function processLimit($query, $limit, $offset = 0)
$rowNumberText = ', ROW_NUMBER() OVER (' . $orderBy . ') AS RowNumber FROM ';$query = preg_replace('/\sFROM\s/i', $rowNumberText, $query, 1);
$query = 'SELECT \* FROM (' . $query . ') _myResults WHERE RowNumber BETWEEN ' . $start . ' AND ' . $end;//$query = 'SELECT \* FROM (' . $query . ') _myResults WHERE RowNumber BETWEEN ' . $start . ' AND ' . $end;
Instead of commenting the line you should remove it - please
—
Reply to this email directly or view it on GitHub https://github.com/joomla/joomla-cms/pull/5293/files#r21202134 . https://github.com/notifications/beacon/ACJs9yneWYmXlb7x688INlqZLf1KUzhoks5nTkXvgaJpZM4DDU1G.gif
|
Can you deal with the code style issues (several places where you're using spaces for indents instead of tabs plus a small number of other minor issues) |
|
Absolutely. Will do so and re-commit. |
|
You're a star! Thanks :) |
|
Fixed the codestyle issues and merged into |
