New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken pagination on Post-installation Messages (iframe) #5217
Comments
Not sure what we can do about this in the CMS as this is just an iframe to another site |
We can't fix the content of the iFrame. But we could remove the iFrame itself. Imho it wasn't the best decision to have that in there. |
the module already exists. it is set to appear in a position called On 27 November 2014 at 11:10, Thomas Hunziker notifications@github.com
Brian Teeman |
Hmm, I have it on the |
Either http://www.joomla.org/announcements/release-news.feed?type=rss or http://www.joomla.org/announcements/release-news.feed?type=atom as those are the feeds for the page shown in the iFrame (http://www.joomla.org/announcements/release-news) |
That's what I already have in the unused module. Wondering if it is setup
|
@Bakual Give some time and will come up with a PR using newsfeed instead of iframe... |
It is in the sample data sets (wrong/unused position) but not in the full sql file (92, 'Release News', '', '', 1, 'postinstall', 0, '0000-00-00 00:00:00', '0000-00-00 00:00:00', '0000-00-00 00:00:00', 1, 'mod_feed', 1, 1, '{"rssurl":"http://www.joomla.org/announcements/release-news.feed","rssrtl":"0","rsstitle":"1","rssdesc":"1","rssimage":"1","rssitems":"3","rssitemdesc":"1","word_count":"0","layout":":default","moduleclass_sfx":"","cache":"1","cache_time":"900","module_tag":"div","bootstrap_size":"0","header_tag":"h3","header_class":"","style":"0"}', 1, ''); |
@Bakual @brianteeman Is this any better? Anything that should be changed, added? |
@brianteeman I guess we don’t need that sql line in the data sets (the same info is available in post-installation) and the postinstall position [?] |
well it doesnt do anything that i can see On 27 November 2014 at 13:32, Dimitris Grammatiko notifications@github.com
Brian Teeman |
Set to "closed" on behalf of @zero-24 by The JTracker Application at issues.joomla.org/joomla-cms/5217 |
See here for a PR: #5222 |
This affects all 3.x with post-installation messages and although it is really a minor, it can be marked as annoying.
Steps to replicated:
On a fresh installation go to post-installation messages.
On the right hand side there is an iframe with title Release news (from Joomla.org)
Scroll down should be the only option here but scroll right is also an option.
This is due to a very big row with pagination buttons.
Posible solution keep start, previous, next, end as the only buttons (above the buttons there is a line that indicates the current page out of the total pages).
This comes straight from the joomla.org
Pics:
On the local site
And the actual joomla.org site:
The text was updated successfully, but these errors were encountered: