Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/modules/mod_articles_category/helper.php and search plugin require content router file #5424

Closed
Denitz opened this issue Dec 14, 2014 · 1 comment

Comments

@Denitz
Copy link
Contributor

Denitz commented Dec 14, 2014

Steps to reproduce the issue

See /modules/mod_articles_category/helper.php:

require_once $com_path . 'router.php';

See /plugins/search/content/content.php:
require_once JPATH_SITE . '/components/com_content/router.php';

Expected result

Component router file is included in router but should not be included directly, otherwise router override is impossible.

Actual result

Included directly.

System information (as much as possible)

Additional comments

@Denitz
Copy link
Contributor Author

Denitz commented Dec 15, 2014

PR:
#5437

wilsonge added a commit that referenced this issue Dec 26, 2014
[#5424] - removing content router inclusion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants