-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NoCaptcha - Recaptcha #5595
Comments
Aside from this comment from JM, can't say I see anything that warrants separate plugins. But if both are calling the same API endpoints anyway, then JM's issue is something out of our hands. Unless there's a way to force the original plugin to always use the older Recaptcha version. |
From what I can read J-M issue is a generic issue and effected people From the author of the wordpress recaptcha plugin
On 3 January 2015 at 01:27, Michael Babker notifications@github.com wrote:
Brian Teeman |
I think we made a mistake adding this as a new plugin especially as google only have one available captcha system for creating keys. If I was a regular user and wanted to add captcha I would chose the old one because that is labelled the same as google. (they seem to only have used the nocaptcha name as part of the announcement marketing) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5595. |
As far as I understand, using the new captcha plugin OR the old one will work if a user is not using a Global key, i.e. for someone creating new keys from Google site. We should maybe consider a post installation message and dropping the old one in 4.0? |
People, let’s think of it from the perspective of someone upgrading their sites. Remember that the old ReCAPTCHA library accepts existing Global keys, the new one doesn’t. So, we have two possible cases: Keep the old plugin as-is, create a new plugin for NoCAPTCHA Replace the old plugin with the NoCAPTCHA library (optionally moving the old plugin under a different name) So the best plan to move forward from a user perspective if we want to completely remove the old plugin is: Rename the title of the old plugin to “Captcha – Old ReCAPTCHA (no longer available)” This is not an entirely problem-free solution, but there are enough hints for all but the most cognitively challenged users to figure out the obvious solution. Unless, of course, someone knows a way to positively detect global keys?= |
From what I read googling the global keys no longer work on new sites with I would propose either following the path Nicholas suggests OR
Existing sites will still work with no change - the only diff would be that HOWEVER we have no idea
Neither option is ideal but if we have to make a change (and I believe we |
I cannot confirm this. Just created a new test site, used my old Global Keys with ReCaptcha and it works fine This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5595. |
Was that on localhost? All keys always work on localhost On 4 January 2015 at 09:13, infograf768 notifications@github.com wrote:
Brian Teeman |
We were wrong to call it nocaptcha. We were too fast. To avoid confusion and to ensure that NEW users use the NEW plugin I would like to propose the following. Rename the plugins The description for Captcha - reCAPTCHA (Legacy) should be changed. Add this to the beginning in bold The description for Captcha - reCAPTCHA should be changed. Add this to the end This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5595. |
We probably don't need to ship the legacy plugin in new installs then. Maintain in separately like with weblinks. Note i haven't read up on this just from reading down this thread |
we would still need to ship the lang files though if we want to update the On 9 January 2015 at 16:46, George Wilson notifications@github.com wrote:
Brian Teeman |
Yes This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5595. |
I would wait 3.5 or 3.6 to do that.
Makes sense. |
Ok I will make the PR thanks for checking
|
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5595. |
Is there a reason for keeping the two plugins as they both serve the same thing with the same keys. Can we not simply update the old Recaptcha with the code from the new NoCaptcha?
@nikosdion were we just too quick to implement?
The text was updated successfully, but these errors were encountered: