Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new wrapper classes in the filesystem package #5849

Merged
merged 1 commit into from
Jan 28, 2015
Merged

Use the new wrapper classes in the filesystem package #5849

merged 1 commit into from
Jan 28, 2015

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Jan 21, 2015

Redo of #4827

From our testing sprint in October, we've taken some initial steps to modernize some of our architecture and focus on replacing static methods as able. To do so without backward compatibility breaks, we've introduced several wrapper classes which are object based and enable developers to utilize these to work with what will be the object based API in a later major release.

This PR demonstrates how the wrappers can be used internally by using the newly created wrappers for the Filesystem package within its classes. In conjunction with #4717 this demonstrates how we can begin modernizing the code in phased steps without introducing larger B/C breaks between major releases by providing a compatibility layer in our current releases.

Testing Instructions

  • Apply the patch
  • Perform actions in the user interface that interact with the filesystem (the media manager and extension manager are great places to test from)
  • Ensure filesystem management still works

@Kubik-Rubik
Copy link
Member

Thank you for the new PR, I will look into it in more detail soon!

@Fedik
Copy link
Member

Fedik commented Jan 25, 2015

test
works good here
tried upload/create/delete in media manager, and install/uninstall extensions

@gunjanpatel
Copy link
Contributor

Working fine in media manager. Tried to Add, remove file and create folder. Tried to install and upgrade component. All working fine for me.

Testing Environment:

PHP Built On Linux gunjan 3.13.0-43-generic #72-Ubuntu SMP Mon Dec 8 19:35:06 UTC 2014 x86_64
Database Version 5.5.40-0ubuntu0.14.04.1
Database Collation utf8_general_ci
PHP Version 5.5.9-1ubuntu4.5
Web Server Apache/2.4.7 (Ubuntu)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5849.

@brianteeman
Copy link
Contributor

Has two tests - setting RTC - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5849.

@brianteeman brianteeman added the RTC This Pull Request is Ready To Commit label Jan 27, 2015
wilsonge added a commit that referenced this pull request Jan 28, 2015
Use the new wrapper classes in the filesystem package
@wilsonge wilsonge merged commit 7b9b9ac into joomla:staging Jan 28, 2015
@wilsonge wilsonge added this to the Joomla! 3.4.0 milestone Jan 28, 2015
@zero-24 zero-24 removed the RTC This Pull Request is Ready To Commit label Oct 14, 2015
@mbabker mbabker deleted the UseFilesystemWrapper branch March 30, 2016 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants