Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the new wrapper classes in the filesystem package #4827

Closed
wants to merge 2 commits into from
Closed

Use the new wrapper classes in the filesystem package #4827

wants to merge 2 commits into from

Conversation

mbabker
Copy link
Contributor

@mbabker mbabker commented Oct 18, 2014

From our testing sprint this week, we've taken some initial steps to modernize some of our architecture and focus on replacing static methods as able (this will be blogged about more thoroughly in the coming weeks). To do so without backward compatibility breaks, we've introduced several wrapper classes which are object based and enable developers to utilize these to work with what will be the object based API in a later major release.

This PR demonstrates how the wrappers can be used internally by using the newly created wrappers for the Filesystem package within its classes. In conjunction with #4717 this demonstrates how we can begin modernizing the code in phased steps without introducing larger B/C breaks between major releases by providing a compatibility layer in our current releases.

Testing Instructions

  • Apply the patch
  • Perform actions in the user interface that interact with the filesystem (the media manager and extension manager are great places to test from)
  • Ensure filesystem management still works

@mbabker
Copy link
Contributor Author

mbabker commented Jan 21, 2015

🤷

@mbabker mbabker closed this Jan 21, 2015
@brianteeman
Copy link
Contributor

Was this closed because of?

@mbabker
Copy link
Contributor Author

mbabker commented Jan 21, 2015

Lack of interest, to be able to delete the 3.4-dev branch

@javigomez
Copy link
Contributor

But it can be recreated against staging, isn't it?

@Kubik-Rubik
Copy link
Member

@mbabker Can you do a new PR against staging, please?

@mbabker
Copy link
Contributor Author

mbabker commented Jan 21, 2015

See #5849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants