Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alert of extension update - missing in list of updates #5931

Closed
Hils opened this issue Jan 30, 2015 · 23 comments
Closed

alert of extension update - missing in list of updates #5931

Hils opened this issue Jan 30, 2015 · 23 comments

Comments

@Hils
Copy link
Contributor

Hils commented Jan 30, 2015

extension-update-available

[sitename]/administrator/index.php

Using the 'update now' button goes to next screen which says there is no extension update available.

extension-update-available-not

@brianteeman
Copy link
Contributor

Press Find Updates - what do you get?

I bet it will find something

(and yes this is plain daft)

On 30 January 2015 at 13:26, Hils notifications@github.com wrote:

[image: extension-update-available]
https://cloud.githubusercontent.com/assets/736887/5976202/223fa690-a883-11e4-8ca8-23e7b01343d2.PNG

[sitename]/administrator/index.php

Using the 'update now' button goes to next screen which says there is no
extension update available.

[image: extension-update-available-not]
https://cloud.githubusercontent.com/assets/736887/5976237/6c4a1630-a883-11e4-9c30-58dceb28b302.PNG


Reply to this email directly or view it on GitHub
#5931.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Hils
Copy link
Contributor Author

Hils commented Jan 30, 2015

Clicking the 'not very obvious' Find Updates button top left which is out of direct view - ie admin's eye is drawn immediately to the 'there are no updates' alert. Would it not be better if the sequence of views was first view above and, if there is an update, move straight to the third view so stop the need for the intermediate 'discover' action when it has already been discovered by Joomla. Very confusing.

extension-update-available-discover

@Hils
Copy link
Contributor Author

Hils commented Jan 30, 2015

we cross-posted! I was only half done :D

@brianteeman
Copy link
Contributor

I 10000000% agree with you hils

Unfortunately the last time I brought this up it was shouted down very

On 30 January 2015 at 13:32, Hils notifications@github.com wrote:

we cross-posted! I was only half done :D


Reply to this email directly or view it on GitHub
#5931 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Hils
Copy link
Contributor Author

Hils commented Jan 30, 2015

Well let those who disagreed last time please show the logic AGAINST this suggestion! Thanks :)

@mbabker
Copy link
Contributor

mbabker commented Jan 30, 2015

If I'm not mistaken, there was once upon a time immediate display of extension updates when you clicked the quick icon link...

@brianteeman
Copy link
Contributor

The reasoning was that it was very slow. You will need to search for the
explanation by IIRC @nikosdion
On 30 Jan 2015 13:40, "Michael Babker" notifications@github.com wrote:

If I'm not mistaken, there was once upon a time immediate display of
extension updates when you clicked the quick icon link...


Reply to this email directly or view it on GitHub
#5931 (comment).

@brianteeman
Copy link
Contributor

I "think" this is where the discussion took place #3775


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5931.

@brianteeman brianteeman changed the title 3.4 - erroneous alert of extension update alert of extension update missing in list of updates Jan 30, 2015
@brianteeman
Copy link
Contributor

I have updated the title to be clearer about the issue


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5931.

@Hils
Copy link
Contributor Author

Hils commented Jan 30, 2015

Thanks for finding that Brian. Let me know if you want this closed. It looks like we might not find a Developer to agree :( (the alert isn't missing is it? - re title update)

@brianteeman
Copy link
Contributor

alert of extension update - missing in list of updates

I personally dont want it closed. I see it as a bug

On 30 January 2015 at 14:46, Hils notifications@github.com wrote:

Thanks for finding that Brian. Let me know if you want this closed. It
looks like we might not find a Developer to agree :( (the alert isn't
missing is it? - re title update)


Reply to this email directly or view it on GitHub
#5931 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@nikosdion
Copy link
Contributor

@brianteeman Nope, it wasn't me. I also don't understand why exactly we don't show the updates immediately. We've polled the update sites, we know if there's a new version, what's the big deal? If nothing else we can change that plugin's link to force the refresh when clicked.

@zero-24
Copy link
Contributor

zero-24 commented Jan 30, 2015

@nikosdion

If nothing else we can change that plugin's link to force the refresh when clicked.

What link is needed? This:
index.php?option=com_installer&view=update&task=update.ajax or something new?

@nikosdion
Copy link
Contributor

I'm not talking about the URL it reads the data from. This can't change (of course). I'm talking about the URL it takes you when you click on the update found message. Now it takes you to the update view of com_installer but we could force it to show the refresh update information URL. I'm not in front of my regular computer now, I can't give you the correct URLs :(

@brianteeman
Copy link
Contributor

My apologies @nikosdion I thought you had said something about this being
very slow if you had a lot of extsions and a lot of extension sites to poll

On 30 January 2015 at 15:15, Nicholas K. Dionysopoulos <
notifications@github.com> wrote:

I'm not talking about the URL it reads the data from. This can't change
(of course). I'm talking about the URL it takes you when you click on the
update found message. Now it takes you to the update view of com_installer
but we could force it to show the refresh update information URL. I'm not
in front of my regular computer now, I can't give you the correct URLs :(


Reply to this email directly or view it on GitHub
#5931 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@nikosdion
Copy link
Contributor

Well, it is, but that happens anyway when you click on the refresh updates button. This efficiency problem is why we have a maximum cache time and why it is possible that only some (not all) of the update sites being hit in one update request by the plugin. This would explain why if I release an update now you might now see it until up to 24 hours (depending on your settings, default is 6 hours) later: the old update is cached on your site. But if the cache had to do anything with it you wouldn’t be notified about the update, at all.=

@brianteeman
Copy link
Contributor

So there is no problem in fixing this issue that @Hils has reported

On 30 January 2015 at 15:25, Nicholas K. Dionysopoulos <
notifications@github.com> wrote:

Well, it is, but that happens anyway when you click on the refresh updates
button. This efficiency problem is why we have a maximum cache time and why
it is possible that only some (not all) of the update sites being hit in
one update request by the plugin. This would explain why if I release an
update now you might now see it until up to 24 hours (depending on your
settings, default is 6 hours) later: the old update is cached on your site.
But if the cache had to do anything with it you wouldn’t be notified about
the update, at all.=


Reply to this email directly or view it on GitHub
#5931 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@mbabker
Copy link
Contributor

mbabker commented Jan 30, 2015

In theory you should be seeing whatever data is already in the updates table when you click those buttons. So I'm mildly curious what's causing that to not happen.

@nikosdion
Copy link
Contributor

The fix MIGHT introduce another issue. When you click on that update button you will try reloading all update sites. This MIGHT lead to a blank page due to timeouts or memory outage (usually the former). Basically, you can’t win unless you are willing to go to an AJAX solution for fetching updates, one update site at a time which will be slower but not prone to showing a blank page. It will, however, be prone to not working at all on all those hosts which screw up the response from AJAX requests and all those sites with badly written plugins that inject HTML or who-knows-what even in format=raw requests. So, no, I was wrong: you can’t win. At least the solution we currently have is consistent in its inconsistency and there is a viable, albeit non obvious, workaround.=

@nikosdion
Copy link
Contributor

@mbabker I’d venture that Progressive caching is enabled.=

@brianteeman brianteeman changed the title alert of extension update missing in list of updates alert of extension update - missing in list of updates Jan 30, 2015
@infograf768
Copy link
Member

We also have a similar issue for Extension Manager=> Install Languages.
I always have to click on Find languages when opening a new session.

@brianteeman
Copy link
Contributor

Also see #5263


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/5931.

@zero-24
Copy link
Contributor

zero-24 commented Apr 29, 2015

Closing as fixed in staging here: #6727 Thanks!

@zero-24 zero-24 closed this as completed Apr 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants