Removing obsolete file check in JEditor #6513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Applied patch and was still able to install JCE - is that a successful test? This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6513. |
|
@brianteeman Make sure the editor is still being loaded properly (when you edit an article for example) and your test could be counted as one successful test. @test : Look good from code review. Also applied the patch and editor still being loaded properly. So test success from me. |
|
@brianteeman as @joomdonation said, this is during loading of an editor. This check came from a time where plugins did not have their own folder, but were installed in the plugin groups folder directly. That is not possible anymore since 1.6 and thus this check can be removed. |
|
Agree. |
|
Setting RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6513. |
wilsonge
added a commit
that referenced
this pull request
Apr 13, 2015
Removing obsolete file check in JEditor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check that is removed in this PR was not valid since Joomla 1.6 and there is no way to install an editor in a way that this check would have evaluated to true. So this might as well be removed here and now.