Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5fallback.js generates errors #6573

Closed
cr2a-graphique opened this issue Mar 24, 2015 · 2 comments
Closed

html5fallback.js generates errors #6573

cr2a-graphique opened this issue Mar 24, 2015 · 2 comments

Comments

@cr2a-graphique
Copy link

Hi, with my fellow worker @vinespie we found a mistake are generate by html5fallback.js

example :
For the mod_login, when you go out of a field like username "html5fallback.js" generate a aria-invalid="false" in the label.

aria-invalid is not used for label.

@zero-24
Copy link
Contributor

zero-24 commented Apr 1, 2015

Closing as we have a PR: #6631 Thanks

@vinespie
Copy link
Contributor

According to accessibility standards attribute "aria-invalid" should be only placed on the attribute "input" not on the label coresponding.
https://www.w3.org/WAI/GL/wiki/Using_Aria-Invalid_to_Indicate_An_Error_Field

Actual result

  1. Go to "index.php?option=com_users&view=login&Itemid=233" or login page
  2. Do not enter a login information and click the button
  3. You must see the input login incorrect, the label "Username" with attribute "aria-invalid" set to true.

2015-05-25 10_39_39-login

Test instructions

  1. Apply the patch
  2. Go to "index.php?option=com_users&view=login&Itemid=233" or login page
  3. Do not enter a login information and click the button
  4. You must see the input login incorrect, the label "Username" with no attribute "aria-invalid"

2015-05-25 10_41_18-login

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants