html5fallback.js: remove aria-invalid on label if field is invalid. fix #6573

[vinespie]

Removing "aria-invalid" attribute on label when input is not valid.
https://www.w3.org/WAI/GL/wiki/Using_Aria-Invalid_to_Indicate_An_Error_Field
fix #6573

---

Hi, with my fellow worker @vinespie we found a mistake are generate by html5fallback.js

example :
For the mod_login, when you go out of a field like username "html5fallback.js" generate a aria-invalid="false" in the label.

aria-invalid is not used for label.

[zero-24]

@vinespie can you fix also the compressed file? https://github.com/vinespie/joomla-cms/blob/staging/media/system/js/html5fallback.js

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.}

[vinespie]

No, I searched the compression tool used to joomla but I have not found. Can you give me a link / her name?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.}

[Fedik]

@vinespie see https://gist.github.com/phproberto/6933178

[vinespie]

@zero-24 I added the correction in the compressed file
thank you for the help @Fedik

[crommie]

Could you please add step by step testing instructions?

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.}

[hans2103]

Need testinstructions

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.}

[zero-24]

@crommie @hans2103

how to test

first test

• Use a Browser (like old IE)
• go to a mod_login screen
• see the sourecode of the Username field
• see the aria-invalid="false"
• apply the patch
• see it is gone

seccond test

• go to a mod_login screen
• copy the sourecode into http://validator.w3.org/
• see issue about the aria-invalid="false"
• apply the patch
• see it is gone

[matrikular]

I have tested this item 🔴 unsuccessfully on a104968

Either this has already been fixed or I'm missing something.

The html5fallback.js is present in the documents head on: index.php?option=com_users&view=login but there is no aria-attribute on the label. Tested with IE 8.0.7601

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6631.}

[yvesh]

@zero-24 we are a bit irritated about your test instructions here at PBF Munich, the patch is for the label and not the field!? (INPUT) But we couldn't reproduce it either with the windows machines here.

[zero-24]

Thanks @yvesh and @matrikular closing here.