-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for random ordering in mod_articles_category #6648
Conversation
I've added in random ordering in this module since it's something I think should be in the core and it's one of the first things I change in new Joomla installations.
Please provide full test instructions otherwise people will just ignore it. A good starting point would be to state which module it is that you have edited This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6648. |
modules/mod_articles_category/mod_articles_category.xml |
There are no test instructions for previous state as there was no random ordering, In the new situation one can choose "Random" (if it also gets pulled) in ordering at the backend and the selected articles from mod_articles_category will be shown randomly. |
I added the other options into this one. It should now be sufficient to add the "Random" ordering option to the Articles Category module. |
@@ -90,8 +90,9 @@ MOD_ARTICLES_CATEGORY_OPTION_ORDERINGFEATURED_VALUE="Featured Articles Order" | |||
MOD_ARTICLES_CATEGORY_OPTION_RELATIVEDAY_VALUE="Relative Date" | |||
MOD_ARTICLES_CATEGORY_OPTION_STARTPUBLISHING_VALUE="Start Publishing Date" | |||
MOD_ARTICLES_CATEGORY_OPTION_FINISHPUBLISHING_VALUE="Finish Publishing Date" | |||
MOD_ARTICLES_CAREGORY_OPTION_RANDOM_VALUE="Random" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please correct to say CATEGORY not caRegory
Sorry but I am confused. You have added an options called Random to an option
So that definitely isnt the correct place for it
Although that would mean that it was renamed to just Ordering This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6648. |
Unfortunately this will not work in Postrges which does not have a rand function This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6648. |
@xaddict Thanks for your contribution. The last comment on this comes from myself stating that it cannot be accepted as is because the code doesnt work with Postgres. Are you able to update the code so that it will? If not then this will have to be closed This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6648. |
You can go ahead and close this. I'm doing this via a custom written module On Thu, 12 Nov 2015 at 16:06 Brian Teeman notifications@github.com wrote:
|
Closing per request and since it has open issues anyway. |
If there is a willing to make it work on multi database you can use "random" as option value and implement it later with
|
👍 |
see #8538 |
I've added in random ordering in this module since it's something I think should be in the core and it's one of the first things I change in new Joomla installations.