module articles category - add random order option #8538
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| $articles->setState('list.ordering', $params->get('article_ordering', 'a.ordering')); | ||
| $articles->setState('list.direction', $params->get('article_ordering_direction', 'ASC')); | ||
| $ordering = $params->get('article_ordering', 'a.ordering'); | ||
| if (trim($ordering) == 'rand()') |
There was a problem hiding this comment.
can we add a clean line bevor the if? I think as we don't require rand() we should use random as option value as i think it is better readable what do you think?
|
I have just comment on two issues. I can test it later today ;) |
|
I have tested this item ✅ successfully on eb2ddf1 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8538. |
added 2 commits
November 27, 2015 17:49
as for comment use random instead of rand()
as per comment add a blank line before if and changed rand() to random
|
comments should be ok now ;) |
|
Great 👍 |
|
I have tested this item ✅ successfully on 72d60ce This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8538. |
|
Thanks for testing - setting RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8538. |
|
I have tested this item ✅ successfully on 72d60ce This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8538. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up #6648
add random order option to articles category module
How to test
apply the patch
select the random option on
Article Field to Order ByExpected result
the articles are showed randomly orderdered
Additional comment
should work on all supported db's