-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add microdata to breadcrumbs #7613
Conversation
looks good, and I do not see |
@Fedik Thanks for noticing that :) I add the |
thanks! |
Test OK. |
RTC Thanks 😄 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7613. |
hm, @peterlose on your test result still missed |
Strange, my test results where good. Did you fetch the last data? |
Shoundn't position be itemprop as well? meta property is for RDFA
|
@peterlose right, I just noticed this also 😄 |
Changed it, thanks for notice!
Changed it, thx for testing |
@n9iels thanks, now is better 😉 |
This PR add Micro Structured Data to the Joomla! breadcrumbs. I followed this guide lines: https://developers.google.com/structured-data/breadcrumbs
Also add some code style and change some
if ($condition) {
toif ($condition) :
to make the code more readable.Test instructions
Confirm that all parameters are working correct like they used do