Breadcrumbs - fixing invisible menu heading

[teeuwis]

In the breadcrumb module a menu item is not shown when it lacks a link (like a menu heading)
Fixes issue #7838 in the issue tracker

[Bakual]

Copying original issue description:

Steps to reproduce the issue

Create a menu
Add a menu item of menu item type "Menu Heading"
Add a submenu item of menu item type "Individual Article"

Create a breadcrumb module for this menu and navigate to the submenu item.

Expected result

The breadcrumb module should show
Home > Menu Item > Sub Menu Item

Actual result

The breadcrumb module shows
Home > Menu Item

System information (as much as possible)

Not relevant

[justinherrin]

Looks like the issue came from the recent #7613 PR which re-worked the breadcrumbs to include microdata.

@test tested and now the Menu Heading type shows back up in the breadcrumb trail as expected.

[wilsonge]

Merging on reivew with the test

[uudruid74]

I manually fixed this once before. Just updated to 3.4.8 and its still there? How long until this gets pushed to stable?

[rdeutz]

It is merged for 3.5.0 as you can see from the milestone, meanwhile you can copy your fixed version to the template and create an override

[uudruid74]

I know how to fix it as I've done it before. My question was what makes this 3.5 and not a bugfix that should have made it into 3.4.x a couple revisions ago. When I update, bugs should be fixed, not re-added! Nor should I have to go through a complicated overlay procedure to stop new releases from re adding bugs that were fixed months ago!

This is clearly not a new feature nor anything that would break compatibility with existing modules or cause new issues. It's a typo, exactly the sort of thing that new releases are supposed to fix. Bug has been here ... 6 months?

Sure. It's my fault for not using an overlay to fix it. That's it!

[rdeutz]

can't say why it wasn't merged for 3.4.5 from the timeline it should have be merged/included, after that we had only security releases and we decided to merge only the security fixes