-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Behavior Modal loading mootools library unnecessarily #7887
Comments
@dgt41 can you have a look into here? I'm not on the latest state regarding JQuery / Mootools ;) |
SqueezeBox is dependent on MooTools to function (see the project site http://digitarald.de/project/squeezebox/) so it is indeed a required dependency to load it. |
I'm sorry, I have failed to check this without loading mootools. I guess
|
modal.js is the SqueezeBox modal. IMO that shouldn't be touched unless they have a jQuery compatible version of their code, it's not our place to be hacking third party code. |
@akfaisel I thought that converting this script to Jquery would be a good thing. Yesterday. Today I realized that for some events people might be using mootools to program them, so unfortunately this cannot be done keeping backwards compatibility. Best way out of this is by using Bootstrap modal code... |
Steps to reproduce the issue
Importing the modal library loads mootools library which should be removed.
Expected result
Do not load mootools library
Actual result
System information (as much as possible)
In * /libraries/cms/html/behavior.php_, _public static function modal*, the following line is called which is not necessary at all.
If we dig more down the same function, the script declaration has the syntax of jQuery.
Additional comments
The text was updated successfully, but these errors were encountered: