tinyMCE DRY for the inline script

[dgrammatiko]

DRY

Few lines are repeated on the 3 different modes. We don’t have to…

Also instead of using tinyMCE.activeEditor we target exactly the editor we want.

Testing

Use tinyMCE as your editor. Try all different modes (simple, advanced, extended).

[Fedik]

I got Uncaught TypeError: window.parent.jInsertEditorText is not a function when try select something in the modal (from xtd buttons)
seems public function onGetInsertMethod($name) never called .. strange

other things seems work fine 😄

[dgrammatiko]

@Fedik normality restored...

[Fedik]

one more:
When click on "Read More" button Uncaught TypeError: Cannot read property 'getContent' of null

[roland-d]

Using the extension sliders, I get a different popup clicking on the button. This is in J 3.4.5:

and this is in 3.5.0-dev:

@Fedik mentioned in #8378 this is due to Mootools using eval for the code "{handler: 'iframe', size: {x:window.getSize().x-100, y: window.getSize().y-100}}" perhaps we can do the same?

[roland-d]

We are in need of some padding above the Page title field:

Since the article modal needs some padding as well, perhaps we need to a padding all around of let's say10px.

[Fedik]

maybe better idea is to move it to javascript and parse on the client side, with Function constructor:

var getOptions = new Function("return {handler: 'iframe', size: {x:window.getSize().x-100, y: window.getSize().y-100}}");
var options = getOptions();
var width = options.size && options.size.x ?  options.size.x : 0;
var height = options.size && options.size.y ?  options.size.y : 0;

but I have no idea what to do with bootstrap modals, where the width/height need to be set in the iframe layout 🙊

[dgrammatiko]

The buttons are not available with bootstrap modal, yet!

[Fedik]

ignore my previous comment,
I totally missed that getSize() in window.getSize() comes from mootools,
nor eval nor my suggestion will not work here without mootools loaded

[roland-d]

@Fedik we should be able to extract or copy the logic that calculates the modal size or not?

[Fedik]

hm,
I see only 2 way (revert changes I not count):

• or load mootools
• or create own method window.getSize like:

window.getSize = window.getSize || function(){
 return {x: jQuery(window).width(), y: jQuery(window).height() };
};

(but no idea where to place this code)

then it can work with that suggestion https://github.com/dgt41/joomla-cms/pull/27

[dgrammatiko]

@Fedik still got errors, the problem is that we need to revaluate the width and height since it is not just the window size (we should parse the integer and subtract from the window width). I think hardcoding these values is way easier...

[Fedik]

which errors you got?
here "...{x:window.getSize().x-100, y: window.getSize().y-100}.." seems work fine with Fedik@faf1fa5

[dgrammatiko]

@Fedik I am stupid, I had edited the line "...{x:window.getSize().x-100, y: window.getSize().y-100}.." that’s why I was getting an error 🙈
This works fine, thanks again!

[roland-d]

I have tested this item ✅ successfully on 2b774e6

After applying the patch, the modals show up in the desired size and the padding is applied.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8366.}

[Fedik]

I have tested this item ✅ successfully on 2b774e6

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8366.}

[dgrammatiko]

@joomla-cms-bot are you sleeping?

[zero-24]

Cool @dgt41 i also got worried about him. Thanks for wake up @joomla-cms-bot :)