Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: jModalClose is unavailable if no mootools #8380

Closed
wants to merge 2 commits into from
Closed

Regression: jModalClose is unavailable if no mootools #8380

wants to merge 2 commits into from

Conversation

dgrammatiko
Copy link
Contributor

Fixes #8378

Testing

Set tinyMCE as you editor
try the button insert article, the link should be inserted and the modal should close

@dgrammatiko
Copy link
Contributor Author

Just a remark the broken part is the undefined jModalClose function, the rest is just moving js to a part where can be overridden...

@Bakual
Copy link
Contributor

Bakual commented Nov 11, 2015

While this fixes the issue for the article button, it doesn't fix the underlying issue.
All 3rd party plugins with similar code will still be broken, and especially closing the active modal is something many (most?) plugins use in this case.

Unfortunately it looks like the move to use Bootstrap modals instead of SqueezeBox isn' that easy. If we can't proxy the old closing method to close the Bootstrap modal, then I'm afraid that PR isn't B/C and imho needs to be reverted.

@Bakual
Copy link
Contributor

Bakual commented Nov 12, 2015

Can you fix the CS issues Travis complains about?
Also I see some commented out code lines. I guess those are leftovers?

@dgrammatiko
Copy link
Contributor Author

Closing please test #8366

@zero-24 zero-24 removed this from the Joomla! 3.5.0 milestone Nov 12, 2015
@dgrammatiko dgrammatiko deleted the tinyBTNS branch November 18, 2015 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

J3.5: Editor buttons can no longer define popup size
4 participants