Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds language flags to listing tables #8815

Closed

Conversation

andrepereiradasilva
Copy link
Contributor

Description

This PR adds language flags to listing tables in menu items, categories, articles, featured articles, modules, banners, news feeds, tags and contacts (and their modals) in administrator panel.

Example:
langs

How to test

  1. Fresh Joomla install with multilanguage (several languages).
  2. Apply this patch
  3. Check if flags are displayed in menu items, categories, articles, featured articles, modules, banners, news feeds, tags and contacts (and their modals) listings.
  4. Do the same for hathor template.

For com_weblinks check joomla-extensions/weblinks#176

Observations

Suggestions are welcome.

@andrepereiradasilva andrepereiradasilva changed the title Adds language flags to listing tables (menu items, categories, articles, featured articles and modules) Adds language flags to listing tables Dec 30, 2015
@infograf768
Copy link
Member

This works fine.
I propose to add a similar UX for template styles.
I also added the tooltip:

screen shot 2015-12-31 at 08 57 29

Diff available here:
https://www.dropbox.com/s/b9azgs1ck1jb3i7/template_styles.diff?dl=0

1. Convert default image falgs to button like the stars
2. Add tooltip with language description

Changed in templates and menu items views
@andrepereiradasilva
Copy link
Contributor Author

@infograf768 i made some changes.

  • Transformed the image in a button like the "star" buttons. Example:
    image
  • Also had a bootstrap tooltip with the native language like the "star" buttons.
  • Also now uses the same 'jgrid.isdefault' JHtml method like the "star" buttons.

Tested and it works, but still want to do some review to the jgrid code.

Another way, that will be more near to waht you proposed is to put also put the language native name inside the button.

What do you think?

@infograf768
Copy link
Member

The button is a nice idea.
Adding the flag in the tooltip looks a bit overkill. 😃
Putting the language name inside the button would make the button quite enormous.

@andrepereiradasilva
Copy link
Contributor Author

@infograf768 i will make a new PR for the default language buttons in templates and menus. This one will stay just for the language flags in the language columns.

I improved a bit the code and added them to hathor too.

For com_weblinks i created a PR joomla-extensions/weblinks#176 and a change to hathor weblinks override (b40b35e) here.

@andrepereiradasilva
Copy link
Contributor Author

@infograf768 the language buttons are in this PR: #8826

@infograf768
Copy link
Member

I have tested this item ✅ successfully on b40b35e

Once the conflict is solved (tag), perfect improvement. Thanks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

@andrepereiradasilva
Copy link
Contributor Author

Thanks.

Once the conflict is solved (tag)
Didn't understand ...

@dgrammatiko
Copy link
Contributor

@andrepereiradasilva you have to resync this as there is a msg: This branch has conflicts that must be resolved at the end of this page...

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

@andrepereiradasilva
Copy link
Contributor Author

No conflicts now.

@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 84e643a


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

@infograf768
Copy link
Member

@andrepereiradasilva

Could you modify the size of the language column for the menu items list?
from 5% to 15%

<th width="15%" class="nowrap hidden-phone">
                            <?php echo JHtml::_('searchtools.sort', 'JGRID_HEADING_LANGUAGE', 'language', $this->state->get('list.direction'), $this->state->get('list.ordering')); ?>
                        </th>

This will let longer Content Languages names display on one line when screen is larger than 800 px.
screen shot 2016-01-22 at 10 32 19

@brianteeman
Copy link
Contributor

Good spot @infograf768
Looking at the other views it looks like they are all at 10%

@infograf768
Copy link
Member

Looking at the other views it looks like they are all at 10%

yes, but in the menu items list it looks like using 15% is much better because Home is set to 5%

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @brianteeman, @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

@andrepereiradasilva
Copy link
Contributor Author

@infograf768, @brianteeman 15% now.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 850a8e5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 850a8e5


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

@infograf768
Copy link
Member

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8815.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 26, 2016
@wilsonge wilsonge added this to the Joomla! 3.5.0 milestone Jan 26, 2016
@wilsonge wilsonge closed this in e8b9c74 Jan 26, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jan 26, 2016
@andrepereiradasilva andrepereiradasilva deleted the ux-language branch January 27, 2016 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants