New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Comma #9117
Remove Comma #9117
Conversation
I have tested this item 🔴 unsuccessfully on 92ae51f This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
I have tested this item 🔴 unsuccessfully on 92ae51f Following error is reported in browser console:
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
See diverse tips on stackoverflow
@dgt41 See https://github.com/dgt41/joomla-cms/pull/29 for the correction 😄 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
@dgt41 Sorry, with my PR dgt41#29 mentioned above it also does not work. The Javascript error is solved, but the value of the extra class input field is never used with it. I try to find a solution but am neither a Javascript nor a jQuery expert. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
The value of the extra class has to be checked inside the insert functions.
@dgt41 I have just commited a change to my PR dgt41#29 for you, and now all works, just have tested. So if you accept my PR this PR here can be tested with success. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
Check for empty jquery object before value length Thanks @richard67
This PR has received new commits. CC: @richard67, @UncleR This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
This PR has received new commits. CC: @richard67, @UncleR This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
@richard67 thanks, of the patch, I've simplified these lines a bit more |
I have tested this item ✅ successfully on 29f9e6b This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
I have tested this item ✅ successfully on 29f9e6b Everything works fine. |
I have tested this item ✅ successfully on 29f9e6b This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
Thanks for testing - setting RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9117. |
Remove comma if style is not set
See #9116