[com_modules] modules view (modal) - Implement searchtools #9232

andrepereiradasilva · 2016-02-27T17:24:18Z

Description

This PR adds searchtools to com_modules modal layout modules view.

Also, in normal layout:

improves responsive visual (mobile/tablet/desktop)
the acess column now orders by access level designation and not by access level id (it doesn't make a lot of sense order by the access level ID ... but makes sense order by the acess level DESIGNATION).
code improvements

Before PR (modal)

After PR (modal)

How to test

Normal view:

Install latest staging and apply this patch
Go to Extensions -> Modules
Check if search, filters, ordering and pagination are working properly
Test on mobile and tablet (ex: reduce browser width)

Modal view (test in frontend and backend):

Go to any content and click on "+Module" button on the editor to open the modal layout
Check if search, filters, ordering and pagination are working properly.
Test selecting a position or a module.

Observations

Changed the modal default list when in the backend, now also shows other states (trashed, archved and unpublished). Why? To show the same states as "+Article" modal - consistency. In the frontend only shows enabled modules in the current language or in All language.
Added a new /components/com_modules/models/forms/filter_modules.xml file to control the frontend searchtools fields (a similiar one already exists for the com_content in /components/com_content/models/forms/filter_articles.xml). Please tell if there are any problems with this.

…odules-searchtools

brianteeman · 2016-02-28T13:00:27Z

I have tested this item ✅ successfully on ba84682

Tested successfully - I still see zero value in the style box

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9232.}

andrepereiradasilva · 2016-02-28T13:06:00Z

I still see zero value in the style box

sorry, didn't understand your comment.

brianteeman · 2016-02-28T13:12:37Z

Dont worry about it - just personally dont see the need to add a style here
as I think it is better to be done in the module and just confuses the UI
here with a function right at the top that is not easy to understand or
even that most people will even have a clue what it is for

On 28 February 2016 at 13:06, andrepereiradasilva notifications@github.com
wrote:

I still see zero value in the style box

sorry, didn't understand your comment.

—
Reply to this email directly or view it on GitHub
#9232 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

dgrammatiko · 2016-02-28T13:15:55Z

administrator/components/com_modules/views/modules/tmpl/modal.php

+	window.parent.jInsertEditorText("{loadmodule " + type + "," + name + extraVal + "}", "' . $editor . '");
+	window.parent.jModalClose();
+};
+modulePosIns = function(position) {


Can you add back the 2 tabs in this javascript part so the rendered output is more aligned?

ok, will do when i fixed merge conflicts

BTW, just for info, i tried a new javasctipt to add to core.js, it worked good but didn't want to merge in this PR

/** * Insert a loadmodule or loadposiiton text shortcut in modules modal windows. Used in modules modal. * USED IN: administrator/components/com_modules/views/modules/tmpl/modal.php * * @param string component The component in usage (ex: com_content). * @param string type The type of insert (module or position). * @param string what What to insert, the position or module type. * @param string title The title. * * @return boolean False to remove the default click event. */ Joomla.insertEditorShortCode = function(component, type, what, title) { var editor = document.getElementById('editor').value, extraClass = document.getElementById('extra_class').value; if (component === 'com_modules') { window.parent.jInsertEditorText('{load' + type +' ' + what + ((title !== '') ? ',' + title : '') + ((extraClass !== '') ? ',' + extraClass : '') + '}', editor); window.parent.jModalClose(); } return false; }

then call it with

For modules: onclick="Joomla.insertEditorShortCode('com_modules', 'module', '<?php echo $this->escape($item->module); ?>', '<?php echo $this->escape($item->title); ?>');"> For position: onclick="Joomla.insertEditorShortCode('com_modules', 'position', '<?php echo $this->escape($item->position); ?>', '');"

What to you think? for a future PR after this is merged...

also has the advantage that is vanilla js

And of course, could also be modified to use data-* attributes.

You can have vanilla js here:

moduleIns = function(type, name) { var extraVal ,fieldExtra = document.getElementById("extra_class"); extraVal = (fieldExtra.length && fieldExtra.value.length) ? "," + fieldExtra.value : ""; window.parent.jInsertEditorText("{loadmodule " + type + "," + name + extraVal + "}", "' . $editor . '"); window.parent.jModalClose();

I wouldn't abstract the function in core.js as it makes it harder to trace back...
On the other hand that way we discard the inline script, so I see an advantage there as well. You decide here

anibalsanchez · 2016-02-29T21:02:51Z

I have tested this item ✅ successfully on ba84682

Test OK

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9232.}

brianteeman · 2016-02-29T21:24:23Z

RTC thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9232.}

shubhamnba2009 · 2016-03-02T07:39:41Z

Hi, i want to contribute by testing this PR.
I have a ques and this may seem silly to some. What does the term latest staging means?

alikon · 2016-03-02T07:44:50Z

Means the latest "version" on the current branch "staging" it contains all
pr merged
On 2 Mar 2016 8:39 am, "Shubham Rajput" notifications@github.com wrote:

Hi, i want to contribute by testing this PR.
I have a ques and this may seem silly to some. What does the term latest
staging means?

—
Reply to this email directly or view it on GitHub.

anibalsanchez · 2016-03-02T07:55:10Z

The term 'staging' refers to something that's staged to be delivered.

In Joomla context, it is the name of all the latest accepted changes.

Then, to test a new change, you have to download from Github the latest
staging (click in the main repo Download button) and install that version
for testing.

Additionally, some PRs provide the whole Joomla to avoid the hassle of
patching.

Happy testing !
On Mar 2, 2016 8:39 AM, "Shubham Rajput" notifications@github.com wrote:

Hi, i want to contribute by testing this PR.
I have a ques and this may seem silly to some. What does the term latest
staging means?

—
Reply to this email directly or view it on GitHub
#9232 (comment).

shubhamnba2009 · 2016-03-02T08:41:50Z

Just one more small doubt. I have installed joomla version 3.4.8 and using xampp to run it.
So lnstalling latest versiofromn means I have to download latest version github then remove 3.4.8 version and then install latest version of joomla? Is this the procedure or I can upgrade the 3.4.8 version without removing it? Thanks in advance

joomla-cms-bot · 2016-04-13T00:23:34Z

This PR has received new commits.

CC: @anibalsanchez, @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9232.}

joomla-cms-bot · 2016-04-13T00:24:21Z

This PR has received new commits.

CC: @anibalsanchez, @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9232.}

andrepereiradasilva · 2016-04-13T00:26:53Z

ignore again the unit tests label, somehow my git changed the filename of the xcache unit test, i reverted.
Seems my git has some issues with the naming of that file, maybe because is windows...

Conflicts fixed. @brianteeman please remove again the label sorry.

rdeutz · 2016-04-13T05:18:01Z

Two questions:

Why was the type column removed?
Because it changes the interface, shouldn't this go into 3.6.x?

brianteeman · 2016-04-13T06:03:43Z

Dont know abut the removal of the type column (perhaps a mistake I only noticed the removal of the pages column which was meaningless) but this was only a "feature" added in 3.5.0 and to me its a bug fix/improvement

andrepereiradasilva · 2016-04-13T07:56:14Z

the type column is there is only hidden in tablet view.

brianteeman · 2016-04-13T08:02:45Z

As per your screenshot in the first post and a retest I just did right now which shows the same as your screenshot.
Type IS there in the search tools but is NOT there in the displayed columns which as shown in your own screenshots was there before

rdeutz · 2016-04-13T08:37:03Z

@brianteeman what was added in 3.5.0?

brianteeman · 2016-04-13T08:54:03Z

@rdeutz this a new plugin not present util 3.5.0 #8064

rdeutz · 2016-04-13T08:56:53Z

funny I have testet it, I am getting old :-), thanks

andrepereiradasilva · 2016-04-13T10:12:57Z

ok will check the type column, maybe the popup is a tablet size (width) and so it doesn't appear.

andrepereiradasilva · 2016-04-13T10:15:44Z

just tested, yes the popup is tablet size, i will change it.

joomla-cms-bot · 2016-04-13T10:19:18Z

This PR has received new commits.

CC: @anibalsanchez, @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9232.}

andrepereiradasilva · 2016-04-13T10:19:58Z

Done.

BTW not related to this PR, but the popups width shouldn't be fixed!

brianteeman · 2016-04-13T10:28:17Z

All good to me - will let @rdeutz decide on 3.5.2 or 3.6

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9232.}

rdeutz · 2016-04-13T16:28:48Z

I think this here is edge case and I plan to merge it into 3.5.2, because #9208, #9206, #9198 fixing bugs and should be merged in 3.5.2 and this one here would make the interface more consistent

brianteeman · 2016-04-13T16:31:01Z

thanks

On 13 April 2016 at 17:28, Robert Deutz notifications@github.com wrote:

I think this here is edge case and I plan to merge it into 3.5.2, because
#9208 #9208, #9206
#9206, #9198
#9198 fixing bugs and should
be merged in 3.5.2 and this one here would make the interface more
consistent

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9232 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

andrepereiradasilva · 2016-04-13T17:02:15Z

ok will fix the merge conflicts in the other 3 PR when i have time.

andrepereiradasilva added 13 commits February 25, 2016 21:38

implement searchtools on com_modules modal

5cd073a

code improvements and solves bugs

94d008f

mobile view and unset active filters in frontend modal

65e3fd2

remove extra dot

fc7b9b4

Merge remote-tracking branch 'refs/remotes/origin/staging' into com_m…

349a1d7

…odules-searchtools

improve/correct some comments

532c885

Merge remote-tracking branch 'refs/remotes/joomla/staging' into com_m…

a276bc9

…odules-searchtools

fix conflicts

e4d39a0

spaces

be5af71

better filtering

da0d944

if not need to translate use db columns

4db2186

we need them in the filter fields too

d6eb1b7

and in the views too

1fd8cb2

joomla-cms-bot added the PR-staging label Feb 27, 2016

andrepereiradasilva added 4 commits February 27, 2016 17:52

cs

57d952b

question mark ...

93e6749

client_id

313cd1a

avoid merge conflicts

ba84682

dgrammatiko reviewed Feb 28, 2016
View reviewed changes

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 29, 2016

fix conflicts

5bec114

joomla-cms-bot added the Unit/System Tests label Apr 13, 2016

Rename JCacheStorageXCacheTest.php to JCacheStorageXcacheTest.php

5ade952

brianteeman removed the Unit/System Tests label Apr 13, 2016

remove hidden-tablet from the module type column

607851b

rdeutz merged commit 4cdf71a into joomla:staging Apr 14, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 14, 2016

andrepereiradasilva deleted the com_modules-searchtools branch April 14, 2016 07:13

rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[com_modules] modules view (modal) - Implement searchtools #9232

[com_modules] modules view (modal) - Implement searchtools #9232

andrepereiradasilva commented Feb 27, 2016

brianteeman commented Feb 28, 2016

andrepereiradasilva commented Feb 28, 2016

brianteeman commented Feb 28, 2016

dgrammatiko Feb 28, 2016

andrepereiradasilva Feb 28, 2016

dgrammatiko Feb 28, 2016

anibalsanchez commented Feb 29, 2016

brianteeman commented Feb 29, 2016

shubhamnba2009 commented Mar 2, 2016

alikon commented Mar 2, 2016

anibalsanchez commented Mar 2, 2016

shubhamnba2009 commented Mar 2, 2016

joomla-cms-bot commented Apr 13, 2016

joomla-cms-bot commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

brianteeman commented Apr 13, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

rdeutz commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

joomla-cms-bot commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

brianteeman commented Apr 13, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

[com_modules] modules view (modal) - Implement searchtools #9232

[com_modules] modules view (modal) - Implement searchtools #9232

Conversation

andrepereiradasilva commented Feb 27, 2016

Description

Before PR (modal)

After PR (modal)

How to test

Observations

brianteeman commented Feb 28, 2016

andrepereiradasilva commented Feb 28, 2016

brianteeman commented Feb 28, 2016

dgrammatiko Feb 28, 2016

Choose a reason for hiding this comment

andrepereiradasilva Feb 28, 2016

Choose a reason for hiding this comment

dgrammatiko Feb 28, 2016

Choose a reason for hiding this comment

anibalsanchez commented Feb 29, 2016

brianteeman commented Feb 29, 2016

shubhamnba2009 commented Mar 2, 2016

alikon commented Mar 2, 2016

anibalsanchez commented Mar 2, 2016

shubhamnba2009 commented Mar 2, 2016

joomla-cms-bot commented Apr 13, 2016

joomla-cms-bot commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

brianteeman commented Apr 13, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

rdeutz commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

joomla-cms-bot commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016

brianteeman commented Apr 13, 2016

rdeutz commented Apr 13, 2016

brianteeman commented Apr 13, 2016

andrepereiradasilva commented Apr 13, 2016