Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_categories] add searchtools to modal layout and solves bugs #9208

Merged
merged 11 commits into from
Apr 14, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

Description

This PR adds searchtools to com_categories modal layout categories view.

Also, in normal layout:

  • correct bug: the modal on mobile xs show a column without title.
  • correct bug: ordering the view for Association doesn't add the arrow icon (removed ordering in this column).
  • improves responsive visual (mobile/tablet/desktop)
  • solves other minor graphical issues.
  • minor code style improvements
Before PR (modal)

before-pr

After PR (modal)

after-pr

How to test

Normal view:

  1. Install latest staging and apply this patch
  2. Go to Content -> Categories
  3. Check if search, filters, ordering and pagination are working properly
  4. Test on mobile and tablet (ex: reduce browser width)

Modal view:

  1. Enable language associations.
  2. Create some categories in several languages.
  3. Edit one of those categories and go to "Associations" tab and click on "Select" on any language.
  4. Check if search, filters, ordering and pagination are working properly in modal.
  5. Test on mobile and tablet (ex: reduce browser width)

Should be also tested in other extensions that use categories (ex: User Notes, Contacts, Banners and News Feeds)

@andrepereiradasilva andrepereiradasilva changed the title Com categories searchtools [com_categories] add searchtools to modal layout and solves bugs Feb 24, 2016
@infograf768
Copy link
Member

I have tested this item ✅ successfully on 4ce7fae


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 4ce7fae


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

@brianteeman
Copy link
Contributor

RTC - thanks once again


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Feb 28, 2016
@brianteeman brianteeman modified the milestone: Joomla 3.5.2 Apr 12, 2016
@rdeutz
Copy link
Contributor

rdeutz commented Apr 13, 2016

@andrepereiradasilva could you have a look at the merge conflicts, thanks.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @brianteeman, @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @brianteeman, @infograf768


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9208.

@andrepereiradasilva
Copy link
Contributor Author

conflicts fixed.
@brianteeman can you remove the Unit tests label again? sorry

@rdeutz rdeutz merged commit 7d64a26 into joomla:staging Apr 14, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 14, 2016
@andrepereiradasilva andrepereiradasilva deleted the com_categories_searchtools branch April 14, 2016 21:19
@rdeutz rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants