Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

System Information paths #9252

Closed
brianteeman opened this issue Feb 29, 2016 · 9 comments
Closed

System Information paths #9252

brianteeman opened this issue Feb 29, 2016 · 9 comments

Comments

@brianteeman
Copy link
Contributor

The new feature to enable downloading system information by @Radek-Suski and @phproberto will obfuscate certain information in the download.

For example the following values from the configuration file
log_path: xxxxxx
tmp_path: xxxxxx

But the same information is also downloaded as part of the folder permissions and is not obfuscated
Example
/Applications/MAMP/htdocs/joomla-cms-staging/logs: writable
/Applications/MAMP/htdocs/joomla-cms-staging/tmp: writable

@brianteeman
Copy link
Contributor Author

The absolute path is also available in the information downloaded from the PHP information

Example

    error_log
    =============
    Local Value: /Applications/MAMP/logs/php_error.log
    Master Value: /Applications/MAMP/logs/php_error.log

    upload_tmp_dir
    =============
    Local Value: /Applications/MAMP/tmp/php
    Master Value: /Applications/MAMP/tmp/php<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="https://issues.joomla.org/tracker/joomla-cms/9252">issues.joomla.org/joomla-cms/9252</a>.</sub>

@brianteeman
Copy link
Contributor Author

To fix the error_log and the upload_tmp_dir we just need to add them to the phpInfoArray section of the protected $privateSettings

Not sure how to fix the directory path part from the folder permissions section


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9252.

@wilsonge
Copy link
Contributor

wilsonge commented Mar 2, 2016

If you could do those two array elements would be appreciated Brian - then I'll repeatedly annoy @Radek-Suski until I get something back :D

@brianteeman
Copy link
Contributor Author

give me 30

On 2 March 2016 at 00:03, George Wilson notifications@github.com wrote:

If you could do those two array elements would be appreciated Brian - then
I'll repeatedly annoy @Radek-Suski https://github.com/Radek-Suski until
I get something back :D


Reply to this email directly or view it on GitHub
#9252 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@wilsonge
Copy link
Contributor

wilsonge commented Mar 2, 2016

sure :)

@brianteeman
Copy link
Contributor Author

See #9274 for fix for
log_path: xxxxxx
tmp_path: xxxxxx

On 2 March 2016 at 00:10, George Wilson notifications@github.com wrote:

sure :)


Reply to this email directly or view it on GitHub
#9252 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@Radek-Suski
Copy link
Contributor

That should do the trick

@brianteeman
Copy link
Contributor Author

@radek I couldnt work out how to obfuscate the file path to temp etc in the
file permissions tab. George had a go BUT that removed it from the web
interface as well

On 2 March 2016 at 10:20, Radek Suski notifications@github.com wrote:

That should do the trick


Reply to this email directly or view it on GitHub
#9252 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@brianteeman
Copy link
Contributor Author

Sorry just saw your PR

On 2 March 2016 at 10:29, Brian Teeman brian@teeman.net wrote:

@radek I couldnt work out how to obfuscate the file path to temp etc in
the file permissions tab. George had a go BUT that removed it from the web
interface as well

On 2 March 2016 at 10:20, Radek Suski notifications@github.com wrote:

That should do the trick


Reply to this email directly or view it on GitHub
#9252 (comment)
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants