Solves 9326: clean beta 4 install without pre-created database doesn't work

[andrepereiradasilva]

Pull Request for Issue #9326 .

Summary of Changes

Solves #9326

Testing Instructions

1. Use beta 4 or latest staging and proceed with clean joomla install
2. Do step 1 of install
3. Check code difference in this PR and change that file (/libraries/joomla/database/driver.php) before executing step 2 (database) of install.
4. On step 2 of install enter a new database (don't use one that already exists). before this change it wouldn't work, after this change it will work.

[andrepereiradasilva]

@richard67 can you test this?

[Bakual]

I have tested this item ✅ successfully on 7cacd55

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9328.}

[richard67]

@andrepereiradasilva I just was testing new install for several db and php versions but could not confirm problems reported in issue #9326 yet. But in 1 case my server got extremely slow. Because I was dealing with this piece of code, too (also wanted to change it to support utf8mb4), I would say by code review that your change with this PR here corrects a bad mistake.

@wilsonge Should be merged by code review, it is obviosly correcting a bad mistake, no need to test that.

[andrepereiradasilva]

@richard67 it only happens when you create a new database on install on a utf8 capable server. If you use a database that already exists it works before this PR.

[Bakual]

I could replicate the issue and the proposed fix solves it.

Also current code is obviously wrong as there is an undefined variable ($collation)

[richard67]

Yes, just got that after reading comments to the issue. I can test but would be nice if I could save the work because it gets merged before.

[andrepereiradasilva]

yeah sure

[richard67]

Well I start preparing the test ... is a bit uncomfortable because I test on remote shared host, not on local PC.

[richard67]

ahhh ... i cannot test this i am afraid ... will not have privileges maybe to create new db with Joomla! installation.

[richard67]

Maybe @stellainformatica can test?

[AlexRed]

I have tested this item ✅ successfully on 7cacd55

Ok, now I can install Joomla 3.5 beta4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9328.}

[stellainformatica]

I have tested this item ✅ successfully on 7cacd55

Tested in localhost, it solves the issue I reported here https://issues.joomla.org/tracker/joomla-cms/9326

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9328.}

[richard67]

@wilsonge Could be worth to make a Beta 5 just with this Patch included.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9328.}

[wilsonge]

I don't have the resources to release on laptop :(

[mbabker]

@wilsonge Do you need a b5 package posted? Begrudgingly I still have access to everything to do it.

[Kubik-Rubik]

@wilsonge @mbabker Beta 5 should be released to fix this issue. It would be great if you could create it, Michael. Thank you!

[mbabker]

On it. Expect everything to be published in next half hour.

[Kubik-Rubik]

Welcome back, my friend! :-)

Thank you!

[mbabker]

Done. https://www.joomla.org/announcements/release-news/5649-joomla-3-5-beta-5-released.html

[Kubik-Rubik]

Thank you @mbabker!

[wilsonge]

Thanks so much michael!