Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Isis and hathor frontend links: Frontend uri scheme can be different from admin #9712

Merged
merged 12 commits into from May 25, 2016

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented Apr 2, 2016

Pull Request for Issue #8109 .

Summary of Changes

This updates Isis and hathor templates frontend links because joomla allows different schemes for admin and frontend site.

Testing Instructions

  1. Use latest staging.
  2. Set the site to "Force SSL" in "Administrator Only" in global config.
  3. Notice, that you are in https in admin as you selected, but:
    • the frontend preview link (top right) is https
    • the "View site" link in (bottom left) of the admin panel is https
    • the "Go to site home page." link in the backend login page is https (in isis and hathor templates)
  4. Apply the patch.
  5. Repeat steps 2 and 3 and you will notice the links are now http as they should.

@andrepereiradasilva
Copy link
Contributor Author

@stellainformatica can you check this PR solves the issue?

@andrepereiradasilva andrepereiradasilva changed the title Isis preview link: Frontend uri scheme can be different from admin Isis and hathor frontend links: Frontend uri scheme can be different from admin Apr 2, 2016
@richard67
Copy link
Member

I have tested this item ✅ successfully on f8c13c5

Tested with success for both Isis and Hathor templates.

@andrepereiradasilva Maybe you should update the summary of changes ("This updates isis template preview links ..."= so it reflects that also Hathor has been changed.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@andrepereiradasilva
Copy link
Contributor Author

done

@zero-24
Copy link
Contributor

zero-24 commented May 7, 2016

@andrepereiradasilva can you have a look into the merge conflicts?

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @richard67


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@andrepereiradasilva
Copy link
Contributor Author

conflicts fixed

@richard67
Copy link
Member

I have tested this item ✅ successfully on b33de49


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@AlexRed
Copy link
Contributor

AlexRed commented May 25, 2016

I have tested this item ✅ successfully on b33de49

Fantastic!!

Thanks :)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9712.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 25, 2016
@brianteeman brianteeman added this to the Joomla 3.6.0 milestone May 25, 2016
@roland-d roland-d merged commit e149047 into joomla:staging May 25, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 25, 2016
@roland-d
Copy link
Contributor

Thanks everybody

@andrepereiradasilva andrepereiradasilva deleted the solves-8109 branch May 25, 2016 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants