Single registered article guest view #9865

brianteeman · 2016-04-11T23:51:22Z

Pull Request for Issue #9830

Testing Instructions

Create a single article with an intro and full image and a readmore
Set the article to registered only
Create a menu link to the article of type single article
In the menu options make sure show unauthorised links is set to show

Now check the menu item on the front end - you should see the introtext but not the intro image and when you login you see all the text and the full image

Apply the patch
Now check the menu item on the front end - you should see the introtext and the intro image and when you login you see all the text and the full image

Update from upstream

Webdongle · 2016-04-12T01:16:45Z

I have tested this item 🔴 unsuccessfully on 030de77

With Show Voting set to 'Show' ... the voting dropdown box displays twice to guests

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

smz · 2016-04-12T01:51:51Z

components/com_content/views/article/tmpl/default.php

@@ -133,7 +133,14 @@
 	<?php endif; ?>
 	<?php // Optional teaser intro text for guests ?>
 	<?php elseif ($params->get('show_noauth') == true && $user->get('guest')) : ?>
-	<?php echo $this->item->introtext; ?>
+    	<?php echo JLayoutHelper::render('joomla.content.intro_image', $this->item); ?>


Move down below the "if"

No, sorry, I was wrong on this: I mistook the if below as the if on "image_intro", but that's already in the JLayout

smz · 2016-04-12T01:55:32Z

proposed some changes
sorry for the brevity (on the road...)

joomla-cms-bot · 2016-04-12T08:31:05Z

This PR has received new commits.

CC: @Webdongle

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

brianteeman · 2016-04-12T08:31:27Z

Updated to remove double votes

rgmears · 2016-04-12T12:10:24Z

Works for me.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

woluweb · 2016-04-13T20:08:14Z

I have tested this item ✅ successfully on dc144b3

Tested successfully on cc44ae1

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

wojsmol · 2016-04-13T22:04:41Z

@rgmears Please mark test result on https://issues.joomla.org/tracker/joomla-cms/9865

rgmears · 2016-04-14T03:45:55Z

@wojsmol

Please mark test result on ....

I don't know how to do that. Sorry.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

wojsmol · 2016-04-14T04:06:15Z

@rgmears See https://docs.joomla.org/Testing_Joomla!_patches#Recording_test_results

brianteeman · 2016-04-14T09:33:24Z

@rgmears @wojsmol its ok I manually added his test :)

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

smz · 2016-04-14T10:03:13Z

I cannot test now (on a train with no test environ with me) but by simple code review it is evident that lines 137-140 are a duplicate of line 87.

Both echoes the content generated by "afterDisplayTitle" plugins (probably a very seldom used event, but anyway...) which in case will be duplicated...

In Joomla events list (https://docs.joomla.org/Plugin/Events/Content) I don't find "afterDisplayTitle": is it the same as "onContentAfterTitle"?

smz · 2016-04-14T10:16:09Z

In https://docs.joomla.org/Plugin/Events/Content a note in the "onContentAfterTitle" event description says that

... this event has special purpose in com_content for use in handling the introtext.

but I'm unsure of what this is or could be as no further specification is given.

What is evident from code is that content generated by this event is displayed only if the "show_intro" param is ~~set~~ Edit: set to "Hide".

smz · 2016-04-14T23:58:13Z

Confirmed by testing:

Without:

With:

The "Test Aftertitle" plugin is:

<?php
defined('_JEXEC') or die;

class PlgContentTest_aftertitle extends JPlugin {

    // onContentAfterTitle handler
    public function onContentAfterTitle($context, &$article, &$params, $limitstart) {
        return '<h3>This is generated by the "Test Aftertitle" plugin</h3>';
    }

}

smz · 2016-04-15T00:01:07Z

I have tested this item 🔴 unsuccessfully on dc144b3

See above...

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

This solves the duplication of the output for the "onContentAfterTitle" event and also solves the issues that the "onContentPrepare" event is not handled for the intro text. I'm unsure, anyway, if it is correct to fix the latter here or if it would be better to fix it at the "view" level (_so that all templates, even overridden ones_) could benefit of the fix

Update default.php

joomla-cms-bot · 2016-04-15T03:24:59Z

This PR has received new commits.

CC: @rgmears, @smz, @Webdongle, @woluweb

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

Webdongle · 2016-04-15T08:44:21Z

As the patch has been updated because of the fail when tested with the edited plugin ... should the Testing Instructions be updated to take into account that part of the test ?

In https://docs.joomla.org/Plugin/Events/Content a note in the "onContentAfterTitle" event description says that

... this event has special purpose in com_content for use in handling the introtext.

Has me totally confused and am unsure how to perform the test with the edited plugin ?

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

smz · 2016-04-15T12:02:25Z

@Webdongle
TBH, I'm as much confused as you are, and probably quite more (but I'll elaborate about that later on)

As far as regards testing instructions the last word is of course @brianteeman's one, but I can explain what I did in the PR I proposed to Brian and he later incorporated, if this can help.

I eliminated the duplicate display of output generated for the "onContentAfterTitle". This wasn't there at the beginning and was introduced (by mistake, IMHO) in Brian's PR. Eliminating this, thus, doesn't change the expected behaviour and hence testing instructions.
I added an extra processing step so that the intro text is passed to the "onContentPrepare" handler. This fixes the issue of directives like {loadposition} or {loadmodule} appearing verbatim in the generated output instead of being processed. I added this as I interpreted this was Brian wish when (while closing Intro image not showing when not logged in #9830) he said:

... better code than suggested before as it uses the layout correctly and the plugins (i hope) (my emphasis )

This second change requires of course also testing that those directives are indeed honoured (as they are, from my testing).

About this second change I'm also unsure (and I expressed my doubts directly to Brian) if it is correct to do that here or it would be better to perform that at an higher level (at the view level, probably) so that not only this template, but also all other templates using the "intro text" would benefit of the fix.

Unsure if off topic (about the "onContentAfterTitle" event and the "Show Intro Text" option).

The "Show intro text" option seems to be quite a strange beast. The description is:

If set to Show, the Intro Text of the article will show when you drill down to the article. If set to Hide, only the part of the article after the "Read More" break will show.

It indeed does that (intro text not displayed in the "Single Article" view if set to "Hide") but it also controls (with inverted logic) weather the content generated by the "onContentAfterTitle" should be displayed or not.

This is applied, apparently in an inconsistent way, throughout different views. For this, I think we'll need the memory of "old timers" to explain why this is done this way and what's the logic behind it (I'm calling @infograf768 for that, as apparently he did put his hands on that and probably should know...)

conconnl · 2016-04-15T12:37:32Z

I have tested this item ✅ successfully on bc7d64c

Tested successful per instructions

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

Simonkloostra · 2016-04-15T12:53:52Z

I have tested this item ✅ successfully on bc7d64c

Testscenario executed successfully, intro-image is now shown in single-article view

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

rgmears · 2016-04-15T12:58:54Z

I have tested this item ✅ successfully.

Intro Image shows.

{loadposition} and {loadmodule} both display content not code.

joris85 · 2016-04-15T13:39:47Z

Tested successfully,
As quest you do not see the intro image while you should see the intro image.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

klatte88 · 2016-04-15T13:44:11Z

Patch tested succesfully after patch intro image shows up as expected

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

klatte88 · 2016-04-15T13:44:55Z

I have tested this item ✅ successfully on bc7d64c

problem as described recreated and solved after patch

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

brianteeman · 2016-04-15T13:47:45Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9865.}

rgmears · 2016-04-15T13:59:15Z

Forgive the uninformed question, but, what does RTC mean?

smz · 2016-04-15T14:03:59Z

@rgmears

Forgive the uninformed question, but, what does RTC mean?

Ready To Commit

@brianteeman
So you think it is OK to fix the "onContentPrepare" issue here?

rgmears · 2016-04-15T14:05:06Z

Thanks @smz .

brianteeman · 2016-04-15T14:05:12Z

Create a new issue please

On 15 April 2016 at 15:04, Sergio Manzi notifications@github.com wrote:

@rgmears https://github.com/rgmears

Forgive the uninformed question, but, what does RTC mean?

_R_eady _T_o _C_ommit

@brianteeman https://github.com/brianteeman
So you think it is OK to fix the "onContentPrepare" issue here?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#9865 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

smz · 2016-04-15T14:05:29Z

about what?

This was hackish as it would had fixed things only for this template. Not needed anymore now that the problem is fixed in the view.

smz · 2016-04-17T23:19:57Z

... pinging all who were involved in this as I amended it in #9964: thanks for testing and/or review.

brianteeman added 2 commits April 6, 2016 10:53

Merge pull request #8 from joomla/staging

ec54dfc

Update from upstream

Update default.php

030de77

joomla-cms-bot added the PR-staging label Apr 11, 2016

brianteeman mentioned this pull request Apr 11, 2016

Intro image not showing when not logged in #9830

Closed

smz reviewed Apr 12, 2016
View reviewed changes

Update default.php

dc144b3

smz and others added 2 commits April 15, 2016 02:56

Merge pull request #12 from smz/patch-1

bc7d64c

Update default.php

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 15, 2016

brianteeman added this to the Joomla 3.5.2 milestone Apr 15, 2016

rdeutz merged commit 140ecb3 into joomla:staging Apr 15, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 15, 2016

smz added a commit to smz/joomla-cms that referenced this pull request Apr 17, 2016

Partial rollback of joomla#9865

1621e7f

This was hackish as it would had fixed things only for this template. Not needed anymore now that the problem is fixed in the view.

smz mentioned this pull request Apr 17, 2016

Fix introtext treatment in single article view #9964

Closed

rdeutz modified the milestones: Joomla 3.5.2, Joomla! 3.6.0 May 1, 2016

brianteeman deleted the registered-intro branch May 9, 2016 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Single registered article guest view #9865

Single registered article guest view #9865

brianteeman commented Apr 11, 2016

Webdongle commented Apr 12, 2016

smz Apr 12, 2016

smz Apr 12, 2016

smz commented Apr 12, 2016

joomla-cms-bot commented Apr 12, 2016

brianteeman commented Apr 12, 2016

rgmears commented Apr 12, 2016

woluweb commented Apr 13, 2016

wojsmol commented Apr 13, 2016

rgmears commented Apr 14, 2016

wojsmol commented Apr 14, 2016

brianteeman commented Apr 14, 2016

smz commented Apr 14, 2016

smz commented Apr 14, 2016 •

edited

smz commented Apr 14, 2016

smz commented Apr 15, 2016

joomla-cms-bot commented Apr 15, 2016

Webdongle commented Apr 15, 2016

smz commented Apr 15, 2016 •

edited

conconnl commented Apr 15, 2016

Simonkloostra commented Apr 15, 2016

rgmears commented Apr 15, 2016 •

edited

joris85 commented Apr 15, 2016

klatte88 commented Apr 15, 2016

klatte88 commented Apr 15, 2016

brianteeman commented Apr 15, 2016

rgmears commented Apr 15, 2016

smz commented Apr 15, 2016

rgmears commented Apr 15, 2016

brianteeman commented Apr 15, 2016

smz commented Apr 15, 2016

smz commented Apr 17, 2016

Single registered article guest view #9865

Single registered article guest view #9865

Conversation

brianteeman commented Apr 11, 2016

Testing Instructions

Webdongle commented Apr 12, 2016

smz Apr 12, 2016

Choose a reason for hiding this comment

smz Apr 12, 2016

Choose a reason for hiding this comment

smz commented Apr 12, 2016

joomla-cms-bot commented Apr 12, 2016

brianteeman commented Apr 12, 2016

rgmears commented Apr 12, 2016

woluweb commented Apr 13, 2016

wojsmol commented Apr 13, 2016

rgmears commented Apr 14, 2016

wojsmol commented Apr 14, 2016

brianteeman commented Apr 14, 2016

smz commented Apr 14, 2016

smz commented Apr 14, 2016 • edited

smz commented Apr 14, 2016

Without:

With:

smz commented Apr 15, 2016

joomla-cms-bot commented Apr 15, 2016

Webdongle commented Apr 15, 2016

smz commented Apr 15, 2016 • edited

Unsure if off topic (about the "onContentAfterTitle" event and the "Show Intro Text" option).

conconnl commented Apr 15, 2016

Simonkloostra commented Apr 15, 2016

rgmears commented Apr 15, 2016 • edited

joris85 commented Apr 15, 2016

klatte88 commented Apr 15, 2016

klatte88 commented Apr 15, 2016

brianteeman commented Apr 15, 2016

rgmears commented Apr 15, 2016

smz commented Apr 15, 2016

rgmears commented Apr 15, 2016

brianteeman commented Apr 15, 2016

smz commented Apr 15, 2016

smz commented Apr 17, 2016

smz commented Apr 14, 2016 •

edited

smz commented Apr 15, 2016 •

edited

rgmears commented Apr 15, 2016 •

edited