Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant svn $Id$ now that hosting is git based #12

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
4 participants
@PhilETaylor
Copy link
Contributor

PhilETaylor commented Oct 25, 2011

Simply remove a $Id$ from metadata.xml now that hosting is git based and no longer using svn:keywords

@PhilETaylor

This comment has been minimized.

Copy link
Contributor Author

PhilETaylor commented Oct 25, 2011

I have a lot more small tidy up commits I want to submit, along with their tests, but lets see how these two pull requests get on through "the system" first...

@infograf768

This comment has been minimized.

Copy link
Member

infograf768 commented Oct 26, 2011

Please post on Joomlacode tracker. We are not using github yet for CMS tracker/patches.

@PhilETaylor

This comment has been minimized.

Copy link
Contributor Author

PhilETaylor commented Oct 26, 2011

Ha, ok then, I hope that will change soon :-) Pull requests are very cheap and can be reviewed, discussed and merged with very little hard work :-) Creating patches for svn and using joomlacode, as you know, is a hell of a lot more work :-)

Keep up the great work.
Phil.

@elkuku

This comment has been minimized.

Copy link
Member

elkuku commented Oct 26, 2011

I believe we are all waiting impatiently that this is going to happen...

@PhilETaylor

This comment has been minimized.

Copy link
Contributor Author

PhilETaylor commented Oct 26, 2011

I think it will radically change the quality of code and lower the barriers to entry for contributing. For example, this pull request I made without ever downloading the code, I did it all in github as I was browsing, people can instantly see the diff and could merge it easily (if they wanted) or comment or reject it.

For those of use using git and github daily we are already converts - I guess it takes time to convert the masses...

@elinw

This comment has been minimized.

Copy link
Contributor

elinw commented Oct 26, 2011

Hi for now can you just please use the playground.

@PhilETaylor

This comment has been minimized.

Copy link
Contributor Author

PhilETaylor commented Oct 26, 2011

This was not a test, it was a really contribution, but it seems you are not accepting or geared up for that at the moment :-) I know how to use git and GitHub so I don't need to "play" :-)

On 26 Oct 2011, at 22:14, elinw reply@reply.github.com wrote:

Hi for now can you just please use the playground.

Reply to this email directly or view it on GitHub:
#12 (comment)

@elinw

This comment has been minimized.

Copy link
Contributor

elinw commented Oct 26, 2011

But the point is to make stuff available so others can practice and learn since we will no move until everyone feels comfortable. in the meantime, correct as posted all over, please don't use this for real work yet unless is ti a 2.5 feature.

chdemko pushed a commit to chdemko/joomla-cms that referenced this pull request Nov 21, 2011

andreatarr pushed a commit to andreatarr/joomla-cms that referenced this pull request Aug 27, 2012

Merge pull request joomla#12 from andreatarr/usenewfields
Assign classes "span12 small" to sidebar selects for admin edit screens

dextercowley pushed a commit to dextercowley/joomla-cms that referenced this pull request Apr 11, 2013

infograf768 added a commit that referenced this pull request Oct 25, 2014

Merge pull request #12 from rdeutz/infograf768/maildoubledot
changed one condition to let the tests pass, splited one test in two

@maxdel85 maxdel85 referenced this pull request Mar 6, 2015

Closed

Error redirect #6333

@Thovt Thovt referenced this pull request Sep 22, 2015

Closed

Joomla jos-warning #7929

rdeutz pushed a commit that referenced this pull request Apr 15, 2016

Merge pull request #12 from smz/patch-1
Update default.php

laoneo referenced this pull request in Digital-Peak/joomla-cms Jun 21, 2016

mwatt pushed a commit to mwatt/joomla-cms that referenced this pull request Jun 27, 2016

Merge pull request joomla#12 from Erftralle/dgt41-6804
Improve client side validation. Code by @Erftralle. Thanks

mwatt pushed a commit to mwatt/joomla-cms that referenced this pull request Jul 2, 2016

fix for travis (joomla#12)
* fix travis error

* CS

rdeutz added a commit that referenced this pull request Oct 29, 2016

Custom fields (#11833)
* Update gallery.xml

* Update fields.php

* Update internal.php

* Update field.php

* Update dprules.php

* Update section.php

* Update base.php

* Update view.html.php

* Update view.html.php

* Update render.php

* Update modal_article.php

* Update sql.php

* Update fields.php

* Remove commented debug code

* Update fields.php

* #14 fixed Joomla Coding Standards and added function dock blocks code

* #14 fixed Joomla Conding Standards and added function dock blocks

* #14 Fixed class dock block mistake

* we did not require this any more

* #14 fixed Joomla Coding Standards and added function dock block in helper file at back-end

* #14 Fixed only Joomla Coding Standards in FieldsHelper file

* #14 removed where function, added dock blocks and fixed dock bocks coding standards errors

* #14 formatted as the function doc blocks

* #14 formatted as the function doc blocks

* Check the active menu correct

Closes #72

* Move the label field to the options tab

Closes #22

* Label has it's own field and must not stay in params

Regression from #22

* Backport from Digital-Peak/DPFields#32

* Fix the save and copy action

Closes #37

* Store data on reload

Closes #76

* Don't add always the All language to the query

Closes #38

* Count the items in the category manager from com_fields

Closes #61

* Corrected colspan when fields are assigned to a language

* #14 fixed conflict

* Don't save the All category

Closes #19

* Minor language updates

* Fix "Show On" tooltip's description

The tooltip's description for the 'Show On' field is not showing because it is currently looking for the label.

* Don't hardcode com_content.article

Closes #80

* Load the types form when the data is an array

* Create the links correct for the count item feature

Closes #82

* Show the value from com_fields instead of the the users helper

Closes #81

* Set the language correct on the fields cache

Closes #47

* Removed string conversion error

Closes #47

* Changed links to 3.7

* Remove legacy DPFields code

* Get data from state correctly

* Add joins to the com_fields in search plugin (#83)

Add joins to com_fields in the content search plugin

* Add new core rule core.edit.value (#75)

* Add 'onFieldBeforePrepare' and 'onFieldAfterPrepare' events

* Rename "Field Category" to "Field Group"

Closes #91

* Add option to disable custom fields per component

Closes #87

* Use select box to define the images directory

Closes #97

* Truncate correctly

Closes #101

* Change description field to plain textarea

Closes #94
CLoses #99

* Parameters are more clear and improved comment

Adapted change from
32c9048

* onFieldBeforePrepare and onFieldAfterPrepare events now triggered even when custom field value is empty

* Cast before access

* Create params even when they are empty

* Add com_fields menu entries on back end

Closes #109

* Extract the context correctly

Closes #112

* Add custom fields for contact

* Add inline group create

Closes #114

* Add simple context mapping

Closes #117

* Dont assign a not existing category when a field is saved with no catid

* Rename string with group and not category

Closes #124

* Category strings should be named Field Groups

Closes #126

* Show the fields on the blog listing

Closes #108

* Installer crashes somehow

Closes #132

* Merge the types set up into JFormField (#104)

* Merge field types into JFormFields

* Converting the rest of the fields

* Merge DP Field Rendering with Joomla Form Fields

* Remove the gallery scripts

* Rename the interface to JFormDomfieldinterface for auto loading

* Add article field as demo how a component can add fields

* Removing mustache, will be replaced later with a new parser

See #12 for the discussion

* Fixing composer setup, reverting to 3.6.x branch

* Fixing code style errors

Closes #14

* Rename upgrade file to 3.7

* Strip slashes from description

Related to #139

* Removing Simplepie from the database installer script

Reverts 8381e46
See comments for more information

* Show field group description in form

Closes #139

* List field changed key to value and value to name

Closes #121

* Use the first category as field filter when creating an article

Closes #144

* Dont show a user field on the front end

Closes #149

* Add always the fields path when adding the custom fields

Closes #150

* Added hint (placeholder) option

Closes #151

* Correct redirect after checkin action

Closes #154

* Check for group access levels when getting the fields (#153)

* Consider field group state

Closes #155

* Added missing language strings

Closes #129

* JArrayHelper => ArrayHelper

* reduce model method (#160)

* Fixing permission inheritance to edit the value of a field in the form (#157)

* Correct path for parameters folder when not in Joomla libraries

* Type selection (#162)

Closes #134

* Display class attributes (#143)

* User home (#161)

* Add home parameter to media field

* Correct path for paramneters folder when not in Joomla libraries

* Fixing code style errors

* Add new context for com_contact for contact form fields (#115)

* Add new context for com_contact for contact form fields

* Prepare the value on com_contact mail

* Fixing travis code style errors

* Use the correct variable name

Closes #163

* Show the all label when no category is assigned

Closes #165

* Don't set 0 as default hint when not present

Closes #166

* Fix Sniffer Whitespace errors

* Fix Sniffer Whitespace errors (#167)

* Cleanup field model

* Support fields plugins

* Add gallery plugin

* Moved since tag to 3.7

* Some brushup

* Update controller.php

* Update field.php

* Update fields.php

* Update controller.php

* Update fields.php

* Update internal.php

* Update fields.php

* Update fields.xml

* Update field.php

* Update fields.php

* Update type.php

* Update section.php

* Update field.php

* Update field.xml

* Update filter_fields.xml

* Update field.php

* Update view.html.php

* Update edit.php

* Update modal_options.php

* Update view.html.php

* Update default.php

* Update default_batch_body.php

* Update modal.php

* Update field.xml

* Update en-GB.com_fields.sys.ini

* Update en-GB.com_fields.ini

* Update en-GB.plg_fields_gallery.ini

* Update en-GB.plg_fields_gallery.sys.ini

* Update en-GB.plg_system_fields.ini

* Update en-GB.plg_system_fields.sys.ini

* Update modal_article.php

* Update controller.php

* Update field.php

* Update default_custom.php

* Update captcha.php

* Update editor.php

* Update media.php

* Update user.php

* Update editor.xml

* Update media.xml

* Update user.xml

* Update usergrouplist.xml

* Update abstractlist.php

* Update domfieldinterface.php

* Update field.php

* Update email.php

* Update file.php

* Update imagelist.php

* Update sql.php

* Update tel.php

* Update textarea.php

* Update url.php

* Update calendar.xml

* Update checkboxes.xml

* Update imagelist.xml

* Update integer.xml

* Update list.xml

* Update radio.xml

* Update sql.xml

* Update textarea.xml

* Update url.xml

* Update gallery.xml

* plugin

* plugin2

* typo

* Change to uft8mb4

* Add new extensions to the script file

* Revert merge conflict composer changes

* No needed changes

* Library form fields should be unaware of com_fields

* Default to https

* Order the tables correct

* Cleanup language strings

* Code errors from cleanup

* Remove tags support

* Add category filter

* Display fielg group label when editing a group

* Display all fields which are assigned to all languages correct

* Don't show fields on categories as it is not ready yet

* Update fields.php

* Don't transofrm the category name

* Correct quote name function used

* Revert "Display fielg group label when editing a group"

This reverts commit 1331332.

* Disable tags on custom field groups

* Don't include category state in filter on back end

* Remove debug code

* CS fix

* Shortening the line length

* Install SQL files for postgres

* Use JDatabaseQuery

* Option to show the user custom fields on the front on the contact view

* Comment for item_id table column

* Remove class for textareas

* Fix no menu item pages giving wrong links (#12020)

* [plg_system_logout] Load language files only when needed (#11736)

* Update logout.php

* cs and stuff

* Update logout.php

* Adding Options Button (#12033)

* fix paths (#12032)

* Fix routing for non-sef menu items with Modern Routing (#12021)

* [com_banners] - publishing time does not honor timezone (#11978)

* [com_banners ] -  publishing time does not honor timezone

* impress only when needed

impress only when needed

* CS fix

cs fix

* Order stylesheet attributes the same as link attributes (#12052)

* use joomla-projects docker

* Phase out JString calls in libraries (#12058)

* Admin app - JString -> StringHelper (#12056)

* Site app & Plugins - JString -> StringHelper (#12057)

* New Feature, Multilanguage: Add the possibility of displaying associations in article info and in articles list. Replaces #11935 (#12042)

* Replaces

* Modifying to fit Thomas proposal

* modifying fetching flags param

* adding showon + some

* [JAccess] Improve ACL asset preloading performance/memory consumption (#12028)

* improve component asset preload speed

* Update user.php

* Update access.php

* Update access.php

* Update access.php

* Update access.php

* not convinced yet, but revert changes in juser

* make sure that components are always preloaded

* only a logged users (with user id) can be root.

* [com_contact] - moved the captchaEnabled var from default to view (#11964)

* [com_contact] - moved the captchaEnabled var out of the default.php file to the view.html.php file

moved the captchaEnabled var out of the default.php file to the view.html.php file.

* moved captchaEnabled to the view

moved captchaEnabled to the view

* missed var  declarationi/initialization

missed var   $captchaSet  declarationi/initialization

* Session interaction refactoring (#10905)

* Allow lazy starting a session

* Defer starting sessions in the installer

* Defer starting session in JApplicationCms

* Deprecate creating sessions in JFactory

* Start restructuring session load sequence in JApplicationCms

* Add JSession object to onAfterSessionStart event trigger

* Override afterSessionStart for install app to not store the user

* Expand the database storage object for better API

* Fix session listener declaration

* Restructure session bootup and when the session metadata operations run

* 3.5 -> 3.6

* Remove option, out of scope

* Tweak things so the behavior is closer to current API

* Undefined variable

* Get store name from session object

* Remove this, out of scope

* PHPCS fix

* Deep rooted application dependencies are my absolute favorite

* Move comment, doc blocks, consistent method signature

* Again on the consistency, we don't like E_STRICT errors

* Nevermind, confused myself with checkSession, carry on...

* Until the day the unit tests no longer follow the doc block code styles...

* Lost line in merge

* One more merge conflict fix

* This internal coupling is addressed

* Fix query from merge

* [com_content] - add articles ordering by votes, ratings (#11225)

* Add setDocumentTitle() function in JViewLegacy (#11399)

* setDocumentTitle() function in JViewLegacy

* PHPCS

* JED turned to https (#12076)

* JED truned to https

JED truned to https
Minor fixes on proper use of Joomla!

* Update README.txt

Same as #12076

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED and community turned https

* JED, community and org turned https

* JED and community turned https

* JED and community turned https

* correct/add quotename (#12070)

* Label: Users Options: Login name > Username (#12073)

The language label "Change Login Name" is not consistent with the front-end label "Username".

This PR changes the language label to "Change Username" and the decription to "Allow users to change their Username when editing their profile."

The front-end login screens use the label "Username"
Login Component:
![login-component](https://cloud.githubusercontent.com/assets/1217850/18627996/579510ca-7e5e-11e6-9161-6268e9ccb213.png)

Login Module:
![login-module](https://cloud.githubusercontent.com/assets/1217850/18627997/579595ae-7e5e-11e6-8920-edf34631a3c7.png)

### Testing Instructions
#### Before the PR
Users > Manage > [Options] > [User Options]
The last entry is "Change Login Name" 
+ hover description "Allow users to change their Login name when editing their profile."

![login-back-end-options](https://cloud.githubusercontent.com/assets/1217850/18627995/5791ac32-7e5e-11e6-8b18-94a34372c422.png)


#### After the PR
Users > Manage > [Options] > [User Options]
The last entry is "Change Username" 
+ hover description "Allow users to change their Username when editing their profile."

![login-back-end-options-after](https://cloud.githubusercontent.com/assets/1217850/18627998/5799ceb2-7e5e-11e6-9a5e-234dcf2db14e.png)

* Update .travis.yml (#12079)

* Add vote order check

* [a11y] Protostar back to top (#12446)

* [a11y] Protostar - back to top link

* Oops Andre was right

* add anchor for non-js enabled browsers

* Added missing com_fields component from last merge

wilsonge added a commit that referenced this pull request Oct 29, 2016

[4.0] Merge staging (#12622)
* added show/hide introtext parameter to mod_articles_news

* added <?php if (!$params->get('intro_only')) : ?> back again since it might be a B/C setting/parameter

* added tabs in code

* Update mod_articles_news.xml

* Update _item.php

* corrected typo from last merge

* changed label and description

* Add JHtmlBootstrap for front-end editing. Fixes #11562

* Implementing Menu Items modals (New feature)

* Wrong class for chosen (#11820)

* 3.7.0: Using the new modal_menu field in various core places (#11694)

* Using the new modal_menu field in various core places

* Simplifying clearField

* Simplify conditional

* Parenthesis replaced by mdash

* Using modal_category field in various core locations

* 3.7.0: New Feature=>editor-xtd to insert menu items links in content (#11721)

* 3.7.0: New Feature=>editor-xtd to insert menu items links in content

* correcting some errors

* quoting for sql azure

* one more

* Changed icon + lang constants

* Chosen upgrade. Fixes #11779

Squashed commit of the following:

commit 48051c7
Author: Brian Teeman <brian@teeman.net>
Date:   Thu Aug 25 14:31:04 2016 +0100

    css change only

commit 90a89fd
Author: Brian Teeman <brian@teeman.net>
Date:   Thu Aug 25 14:28:58 2016 +0100

    Revert "css fix thanks @C-Lodder"

    This reverts commit f7320cf.

commit f7320cf
Author: Brian Teeman <brian@teeman.net>
Date:   Thu Aug 25 14:09:03 2016 +0100

    css fix thanks @C-Lodder

commit 42c9de3
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 18:10:33 2016 +0100

    fix permissions

commit b8fdd34
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 18:07:53 2016 +0100

    add minified version of js

commit 0ef056d
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 17:59:55 2016 +0100

    add documented js hacks

commit c68c275
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 17:48:01 2016 +0100

    add comment block

commit 983dbf5
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 17:08:47 2016 +0100

    rename liszt: chosen:

commit 8caad73
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 17:07:47 2016 +0100

    Revert "rename liszt: chosen: and add JUI hacks"

    This reverts commit 8611671.

commit 8611671
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 17:06:21 2016 +0100

    rename liszt: chosen: and add JUI hacks

commit 535bea0
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 16:45:14 2016 +0100

    replace chosen: with liszt:

commit 2686df5
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 16:43:35 2016 +0100

    replace _chosen with _chzn

commit 691be65
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 16:42:49 2016 +0100

    replace chosen- with chzn-

commit 863b5f9
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 16:37:20 2016 +0100

    update js with original version

commit 537735c
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 16:36:19 2016 +0100

    remove min js

commit e739562
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 16:35:21 2016 +0100

    replace chosen- with chzn-

commit db82431
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 16:33:46 2016 +0100

    update css file with original version

commit 24a955b
Author: Brian Teeman <brian@teeman.net>
Date:   Wed Aug 24 16:29:34 2016 +0100

    update sprites

commit 4856d5e
Merge: 4ddd833 f10ab35
Author: Brian Teeman <brian@teeman.net>
Date:   Tue Aug 23 16:23:34 2016 +0100

    Merge branch 'staging' of https://github.com/joomla/joomla-cms into staging

commit 4ddd833
Merge: b5ffa27 8258906
Author: Brian Teeman <brian@teeman.net>
Date:   Mon Aug 22 10:30:58 2016 +0100

    Merge branch 'staging' of https://github.com/joomla/joomla-cms into staging

commit b5ffa27
Merge: 24e6c45 e80e319
Author: Brian Teeman <brian@teeman.net>
Date:   Sun Aug 21 17:45:45 2016 +0100

    Merge branch 'staging' of https://github.com/joomla/joomla-cms into staging

commit 24e6c45
Merge: 962b424 c1b0295
Author: Brian Teeman <brian@teeman.net>
Date:   Fri Aug 19 21:08:30 2016 +0100

    Merge branch 'staging' of https://github.com/joomla/joomla-cms into staging

commit 962b424
Merge: 14f5b1c 4c539c4
Author: Brian Teeman <brian@teeman.net>
Date:   Thu Aug 18 12:06:49 2016 +0100

    Merge branch 'staging' of https://github.com/joomla/joomla-cms into staging

commit 14f5b1c
Merge: 2baa00b edb70c2
Author: Brian Teeman <brian@teeman.net>
Date:   Mon Aug 15 10:06:07 2016 +0100

    Merge branch 'staging' of https://github.com/joomla/joomla-cms into staging

commit 2baa00b
Merge: 97d1fb7 f827dfc
Author: Brian Teeman <brian@teeman.net>
Date:   Sun Aug 14 22:38:02 2016 +0100

    Merge branch 'staging' of https://github.com/joomla/joomla-cms into staging

commit 97d1fb7
Author: Brian Teeman <brian@teeman.net>
Date:   Sun Aug 14 16:28:13 2016 +0100

    Revert "toolbar"

    This reverts commit 8f995f1.

commit 8f995f1
Author: Brian Teeman <brian@teeman.net>
Date:   Sun Aug 14 16:27:57 2016 +0100

    toolbar

* Two search modules on same page: Invalid HTML. (#11229)

* Add postfix for unique id ($module->id)

* Respect postfixes for unique id in mod_search

* Reduce use of JFactory::getConfig() where practical

* Allow registering callback functions for the debug console. Fixes #11700

* Allow adding script options without inline JavaScript. Fixes #11671

* Adding "category on fly" functionality when create/edit contact. Fixes #11354

* New method for retrieving the strings from the store. Fixes #11692

* [html5] Hathor administrator template. Fixes #10634

* [Optimize] Generate thumbnail image method to avoid pixelated error in thumbnails. Fixes #7919

* Fix since tag

* Normalise Block this User button styling. Fixes #11421

* [html5] System administrator template. Fixes #10638

* URL checking improved in com_wrapper. Fixes #4670

    When adding the scheme to an URL use correct scheme (http or https) and port.
    Checking for "http" or "https" via strstr() in the URL matched also these strings embedded in the URL (e.g. in /static/http/index.html), due to that checks changed to strpos().

* Update en-GB.com_users.ini (#11909)

* Templates are in the scope of JDocument. Fixes #10847

* Small review/cleanup in JHtml. Fixes #10771

* Fix form field unit tests. Fixes #11910 Fixes #11413

* Improvements to article modals (with Create Article button). Fixes #11830

* [com_content] - Allow captcha when submit article. Fixes #10976

* Proxy JData to the Framework. Fixes #11588

* [newsfeed modal field] Adds Create News Feed button and other improvements. Fixes #11862

* Allow force refreshing the cache when getting fields in JTable. Fixes #11046

* Allow a custom page title to be defined for an article without a menu item. Fixes #10838

* Code review on com_content component. Fixes #10851

* [category modal field] Adds Create Category button and other improvements. Fixes #11857

* Joomla.JText uses scriptOptions 'joomla.jtext'. Fixes #11690

* Remove legacy frame breaking js code. Fixes #11679

* [contact modal field] Adds Create Contact button and other improvements. Fixes #11858

* Support collection of custom stats in admin stats module. Fixes #10870

* Use intro_image in newsfeed. Fixes #11402

* [com_tags] - Add count and link to tagged items. Fixes #10895

* Allow the vote plugin's position to be configured. Fixes #11375

* Return a 403 status code instead of a 404 for a not accessible category. Fixes #11624

* Add Sort by Modified Date in the Module mod_articles_news (#11128)

* Update mod_articles_news.xml

At present the sorting by date has the options to sort the articles by Published Up date and Created Date.  Adding another sort option to sort the articles by the Modified Date has been added.  This addition would be of help to list the articles that are modified recently.

* Update en-GB.mod_articles_news.ini

Added the following language string that would be used in the xml file of the module mod_articles_news.
MOD_ARTICLES_NEWS_FIELD_ORDERING_MODIFIED_DATE="Modified Date"

* Update mod_articles_news.xml

The value a.modified has been added to the Direction

* Cleanup deprecated unused files. Fixes #11762

* Add Polyfill js for legacy browsers (adds events and classlist polyfills). Fixes #11686

* [com_content] Add icons layout. Fixes #10423

* [3.7.x] Fixes issues with the category article view after #11624 (#11943)

* Update category.php

* Update category.php

* Fixing missing getItems in mock JMenu for (routing) unittests. Fixes #11936

* Enable caching of menu data in JMenuSite (#10797)

* Enable caching of menu data in JMenuSite

* Use a lambda function for the query instead

* Add Microseconds to JDate('now') (#11890)

* Update date.php

* Update date.php

* cleaner code

* simplify

* Update date.php

* Router options (#11962)

* Router options

* switch sentences

* [unit tests] Just need to check one microsecond now (3.7.x Branch) (#11966)

* Update JHtmlDateTest.php

* Update JFactoryTest.php

* Fix button classes (#11971)

* Fix javascript tests (#11993)

* fix javascript tests

* typo

* change the order to test Joomla.optionsStorage = null

* ordering again

* Add chosen to module order field (#11992)

* remove crap, add chosen

* s

* New Routing: Fix category routing without menu items

* [category item modal field] Apply on more fields for categories. Fixes #11920

* Patch #6712 - FieldCheckbox attribute default (#6794)

* Patch 6712 - FieldCheckbox attribute default

Checkbox field does not allow defining a value without being checked
#6712

* fix code style

* Added a clean line

Added a clean line befor the if @zero-24

* IS (list views) - Replace html/pagination.php::pagination_list_footer() by JLayouts. Fixes #11246

* Fix no menu item pages giving wrong links (#12020)

* Fix routing for non-sef menu items with Modern Routing (#12021)

* Phase out JString calls in libraries (#12058)

* Admin app - JString -> StringHelper (#12056)

* Site app & Plugins - JString -> StringHelper (#12057)

* New Feature, Multilanguage: Add the possibility of displaying associations in article info and in articles list. Replaces #11935 (#12042)

* Replaces

* Modifying to fit Thomas proposal

* modifying fetching flags param

* adding showon + some

* [JAccess] Improve ACL asset preloading performance/memory consumption (#12028)

* improve component asset preload speed

* Update user.php

* Update access.php

* Update access.php

* Update access.php

* Update access.php

* not convinced yet, but revert changes in juser

* make sure that components are always preloaded

* only a logged users (with user id) can be root.

* [com_content] - add articles ordering by votes, ratings (#11225)

* Add setDocumentTitle() function in JViewLegacy (#11399)

* setDocumentTitle() function in JViewLegacy

* PHPCS

* set new counts too center

* fir for  #11225

* There is no need for the extra spaces at the end of the line :)

* fix typo

fixed typo

* allow to hide session too in plugin system debug

* deprecate keychain for 3.0

* deprecate fof

* deprecate fof

* Update include.php

* deprecate old ciphers

* Fix Travis error in keychain (#12157)

* fix travis

* space

* Allow JHtmlDate::relative to set a custom format (#12164)

* Updated installation language files.

* Fix typo in cache memcached storage (#12150)

* div doesn't support type=button (#12131)

* JFile - error fix "Cannot pass parameter 2 by reference" (#11952)

* Fix of an error "Only variables should be passed by reference"

If you pass a string to methods ````append```` or ````write````, you will have an error ````Only variables should be passed by reference````

* Update file.php

* Update file.php

* Custom calendar is not applied to version history preview and compare dates (#12138)

* Custom calendar is not applied to version history preview and compare

* simplify code. Thanks Thomas.

* Update preview.php

* Update compare.php

* Update MediaElement.js to 2.23.0 (#11981)

* Allow JHtmlDate::relative to set a custom format

* Add doc block comment

* Proposed onAfterRenderModules event in modules rendering (#10113)

* Updated pull request #3105 to latest stage (2016-04-24) inclusive unit test

* CS fix

* Update JDocumentRendererHtmlModulesTest.php

* fix expected value for the unit test

in #10113 a unit test was added but failed, this is a fix

* Deprecate web router classes

* Localise the format for the calendar formfield (#12102)

* Localise the format for the calendar formfield

* Adding comment

* Support all formats

* Label - Mass Mail Users v2 (#12084)

* Added optional suffix text to Mass Mail Form page (#12078)

* Add Unpublished Content Language on Language Package Install (#11867)

* initial commit

* Update language.php

* Update en-GB.lib_joomla.ini

* Update en-GB.lib_joomla.ini

* ups

* Update language.php

* Update language.php

* Update language.php

* change native to $siteLanguageManifest['name']

* allow to install published content languages on install 1

* allow to install published content languages on install 2

* solve remaining issues

* cs

* fix language names and simplify

* cs

* improve code and deprecate unneed code

* fix title issues (as possible with current xml scenario)

* remove non existent metadata values

* shoudl not be row, it should be tableLanguage

* don't fallback to en-GB native title

* tinyMCE use document "scriptoptions", and allow to override tinyMCE Javascript parameters (#11157)

* tinymce initialization, use addScriptOptions and tinymce-init.js

* Finalize tinymce-init.js

* Small improve for code duplication

* Allow multiple editors with diferent options

* Setup default options for the editor script only once

* Minified version of tinymce-init

* code style

* Improve a bit

* Reply to email (#11015)

*  Reply to email

* Reply to email: configuration file chnages resolved

* #11015 Reply to email: suggested changes fixed

* Media form field bootstrapped with static preview (#10889)

* Bootstrap popup with mootols compatibility

* restore static preview

* 💩

* 😡

* fixes

- Delete extra </div>
- Move preview under the input field
- respect landscape/portrait images

* typo

* Utilise unionAll element in the select query, previously it was always being ignored. (#10817)

Rearrange union > unionAll > order to render a valid query when all these three are used together in a query.
Fix return type in method doc blocks.

Update test case for the JDatabaseQuery::toString method to test all the element for select query.

* Introduce new method isClient($identifier) in JApplicationCms class (#8971)

* Introduce new method isClient($identifier) in JApplicationCms class as a substitute for isSite and isAdmin methods.

Hence, remove usage of descendant class reference in the JApplication (legacy) and JApplicationCms for better OO structure and support more extensibility.

* Added unit tests for JApplicationCms::isClient($identifier);

* Fix, null == 0 passes. Avoiding strict check to allow use of '0' or '1' as string as well as integer.

* Removed support for integer argument which matched client_id as discussed with @mbabker, thanks.

* fix com_finder regression (#12236)

* Core.js AJAX method (#11585)

* Core.js even listeners

* Core.js: method for ajax requests

* Code style

* Some example and minified version

* Core.js even listeners, use IE fallback

* Core.js remove even listeners fallback

* 370: solving #11225 merge regression (#12238)

* 3.7.x: Porting #11225 to beez (#12240)

* Move keepalive to external js (#8545)

* Keepalive with data attributes

* cs

* cs

* cs empty line

* Not seconds ...

* object

* No double entities

We have to use JRoute without xhtml or else the admin keep alive URL get
double entities `&amp;amp;?`

* From chocolate to vanilla ...

Works with vanilla js!
Works if onload event is already fired when script is executed.
This way the js file can be loaded on render, asyncronous or deferered
to after the onload event.
Should be cross-browser compatible.

* improvements

* cs

* default options, move to jui folder, asynchronous loading

* simple correct to work with new script attributes PR (11289). Adds auto version hash.

* update to match #11289 JHtml script behaviour

* use __DEPLOY_VERSION__

* cs and simplify

* Update behavior.php

* Update keepalive.js

* Update keepalive.min.js

* Update keepalive.js

* Update keepalive.min.js

* fix conflicts 1

* use new addScriptOptions and Joomla.request methods

* fix unit tests

* fix last unit test

* [menu item modal field] Adds Create Menu Item button and other improvements (3.7.x branch) (#11916)

* Update modal.php

* Update edit.php

* Update view.html.php

* Update item_alias.xml

* Update default.xml

* Update logout.xml

* Update mod_login.xml

* Update mod_login.xml

* Update mod_menu.xml

* Update item.php

* Update menu.php

* Update menu.php

* Update en-GB.com_menus.ini

* minor cs

* corrections

* solve no item text issue

* New show_info option (hide/show) in com_contact and some minor changes (#8607)

* several improvments

* lang changes

* minor changes

* fix conflicts

* fix conflicts 2

* revert

* fix conflicts final

* [3.7.x] Lets use the correct API to get this string translated (com_postinstall) (#12247)

* add files joomla

* lets make the languagestring checker happy

* cs

* add missing string (#12246)

* fix missing string (#12245)

* Deprecate MooTools based helpers (#12268)

* Deprecate MooTools based helpers

* PHPCS sucks...

* fix redirect plugin messages (#12280)

* remove dublicate message (#12279)

* Allow users to share sessions between apps (#12068)

* Allow users to share sessions between apps

* Address all metadata related stuff

* warning (#12285)

merged on review

* [3.7.x] Fix Regression #12277: language selector blocked on edit when there are no associations (multilanguage) (#12283)

* category edit: check if there are associations

* contact edit: check if there are associations

* articles edit: check if there are associations

* menus edit: check if there are associations

* newsfeed edit: check if there are associations

* Admin - Simplify instantiation of Registry (#12270)

* [j3.7] New Feature Contact editor-xtd plugin (#12252)

* New editor-xtd contact plugin

* docs

* update sql

* add contact icon

* prevent loading in com_banners where it is useless

* Installation sql

* correct installation

* extra line feed

* __DEPLOY_VERSION__

* __DEPLOY_VERSION__

* com_admin script

* Update contact.php

* Update contact.php

* Update contact.php

* Update contact.xml

* Update en-GB.plg_editors-xtd_contact.sys.ini

* Update en-GB.plg_editors-xtd_contact.ini

* Update 3.7.0-2016-10-01.sql

* Update 3.7.0-2016-10-01.sql

* Update 3.7.0-2016-10-01.sql

* Routing: Remove IDs from SEF URLs (#11320)

Also fixes various bugs in the new router

* Run SEF plugin also when SEF URLs are not enabled (#11035)

* remove menu button

* Update note.xml

* string, not array

* Redo Isis flat repaint (Closes #11832) (#12319)

* Isis flat repaint - Initial commit

* Tags field refinement

* Fixed field height inconsistency

* RTL support added

* Minor fixes

* Installation flat repaint

* Revert install flat repaint

* Chzn flat styling separated to chzn-override.less

* Missing the in language string

* TinyMCE xtd-button close (again, really) and drop jquery (#12324)

* drop jquery, fix jModalClose()

* classList polyfill not needed here

* window.width (seriously?), merge options

* use Joomla.extend()

* my bad

* IE<9

* Add attribs to the script tag, add version to JHtml script methods and deprecate MD5SUM (alternative to 8540) (#11289)

* new method to add attrbibs to the script tag

* corrections

* defaultJsMimes

* add deprecated comment

* travis

* further simplify

* remove extra space

* forgot to convert mime to type

* add UTF-8, ENT_COMPAT to htmlspecialchars (like previous done in all other places)

* cs line size fix

* better coding

* small typo

* elseif

* deprecate MD5SUM and don't allow two version hashes

* add JLog deprected warnings for new method signatures

* cs line size

* fix conflicts 1

* fix conflicts 2

* refactor JHtml script method signature

* deprecate addScriptVersion add options for version and conditional statements

* Update head.php

* cs

* cs fix

* Change all self::getMd5Version to static::getMd5Version

* has changed

* has changed

* fix conflicts - part one

* fix conflicts

* correct unit test

* [3.7] Readme updates (#12387)

* [languages] Organize and new metadata (Native language and calendar type) (#12036)

* Update en-GB.xml

* Update en-GB.xml

* Update en-GB.xml

* Update en-GB.xml

* Update en-GB.xml

* Update en-GB.xml

* Update en-GB.xml

* fix unit tests

* add to install.xml in unit tests

* correct unit tests

* remove extra tab

* ident with tabs, not spaces!

* installation should have en-GB in name

* en-GB ...

* correct db jos_languages csv stub also

* add missing pkg_en-GB extension to extension stub and correct language extension names

* correct sql files

* correct sql files

* correct sql files

* add en-GB, instead of UK, to batch test

* correct JTableLanguageTest::testStore

* Update install.xml

* Update install.xml

* same replacements in test stub

* Update en-GB.com_languages.ini

* correct last unit test

* Update en-GB.xml

* Update JLanguageTest.php

* Update en-GB.xml

* Update en-GB.xml

* use the new nativeName is exists

* Make language flags in backend optional (#12051)

* Allow to select none image in language

* admin menu module: fall back to a label if no image is selected or image doesn't exist

* "Default" buttons in template styles and menuitems list views

* remove unneeded variable

* Remove empty flag span

* Show language code instead of flag in associations tooltip if no image is selected

* show language label instead of flag if no images is assigned

* Adjust Hathor overrides

* Codestyle fixes

* Missed contact JHtmlContact::association()

* Use a popover for the association tooltips

* Taking care of mod_languages

* Fix flag preview

* show sef in module assignments.

* Fixing frontend Associations

* Fixing menu assignment modal

* a e

* a i

* a o

* a u

* a a - javascript

* js

* Replace uses of JRegistry

* Simplify instantiation of Registry objects

* [3.7] Isis Flat Repaint - Minor Fixes (#12349)

* Removed text shadow

* Remove text-shadow

* Modal save mouseover fix

* Changed to individual removal of text-shadow

* sidebar-nav margin fix

* Fix hover color on all BS btn

* Re-align permissions chzn

* Show configured upload limit when uploading files (redo of #11255) (#12396)

* * Show configured upload limit when uploading installer package. Otherwise when uploading a larger file than the configured limit, the page reloads without any information about what went wrong.
* Show upload limits for file input everywhere. Refactor the calculation part to JUtility class.

* Honour template manager configuration to display upload size limit

* In Hathor: Honour template manager configuration to display upload size limit

* Add deprecated message that in 4.0 the html5 property will be default true (#12430)

* Will be replaced by $html5 and the default value will be true.

* Update html.php

* CodeMirror 5.19 (#12300)

* corrections/improvements (#12429)

* Fixing notice for non-existing views (#12434)

* [3.7.x] Admin login language field fix (#12442)

* Admin login lang fix

* Admin login lang field alignment

* New xtd_contact lang files missing in install.xml (#12452)

* Make more use of the autoloader (#12060)

* Fix error in mergeHeadData method for html document (#12013)

* Extend test for document html links

* Fix mergeHeadData method for html document->_links

* correct table html errors (#12129)

* [users list modal] ismoo parameter need to still exist after form submit (solve #12122) (#12137)

* ismoo parameter need to exist after form submit

* int

* default to 1

* Replaced rand() with mt_rand() projectwide (#12169)

* Replaced rand() with mt_rand() projectwide

* session package is from the framework so we need to revert that change at this point

* fof is an external lib so we need to revert that change at this point

* fof is an external lib so we need to revert that change at this point

* Use global as default option (#12186)

* Solving 12214 Plugin tooltip (#12215)

* JLayoutFile wrong type hint (#12231)

* JLayoutFile wrong type hint

* CS

* CS / Review for the editor plugins (#12260)

* cs review for the editor plugin

* cs

* Update image.php

* Call to undefined method stdClass::get()

* use the warning and error (#12265)

* error not notice (#12273)

* Remove deprecated function (#12296)

* Minor language string change for com_contact (#12339)

* Redo Isis flat repaint Installation (Closes #11917) (#12342)

* Installation flat repaint - Initial commit

* Install flat repaint - Initial commit

* Add missing period (#12356)

* Change language string (#12364)

* Allow loading plugin language strings from extension folder (#12403)

* some cs changes after #12396 (#12431)

* [3.7.x] Update js polyfills to 3.13.0 (#12513)

* Update polyfill.event-uncompressed.js

* Update polyfill.event.js

* update classlist polyfill

* Update polyfill.classlist.js

* minor changes

* minor changes in doc block

* move jquery to template (#12521)

* fixing typo in the comment (#12523)

Just a small typo in the comment.

* Update CREDITS (#12534)

* Update CREDITS

Removing old content that has been moved to a dedicated page on the Joomla! Documentation and adding a link to new contributors page on GitHub.

* Update CREDITS

* Updated installation language files

* 2fa handeling for mcrypt and openssl (#12497)

* handeling for mcrypt and openssl

* Language changes suggested bei Brian

* Prepare 3.6.4 Stable Release

* Mark _autoload function as public and not private. (#12478)

* Mark _autoload function public.

*  whitespace was hanging out

* Revert _load to private

* issing language strings in frontend lib.joomla.ini (#12468)

* forum link to https (#12467)

* [a11y] Protostar back to top (#12446)

* [a11y] Protostar - back to top link

* Oops Andre was right

* add anchor for non-js enabled browsers

* [3.7.x] Convert installation template to html5 (also move inline scripts to js) (#12444)

* convert to html5, use the api for inline scripts

* stupid mistake

* ok let's remove all that inline js ...

* Fix early exit from foreach in JForm::removeGroup (#11856)

* Fix early exit from foreach in JForm::removeGroup

The method is supposed to remove all instances of <fields> element but it exits the loop on first iteration only. Looks like a quick copy-paste from removeField may have caused this.

* Never returns false

* keepalive for editing forms (#12163)

* Remove retina 2x sprite (#12528)

* Set a proper default value for getParams always (#12463)

* Correct spelling (#12564)

* Remove JFilter mock (#12484)

We don't need JFilter hanging out in the JInstaller Adapter tests

* Stop allowing failures on PHP 7.1 (#12599)

* Improvements in the Associations Edit Workflow (#12344)

* changes in model preprocessForm to allow all associations fields to be dumped

* adjustement

* there is no need to block the language field now

* simplify association tab in the templates files

* let's make the layout more dynamic

* add the js behaviours

* solve one of strange bug ...

* improvements and allow associations on create

* correct language string

* render a warning message

* solve categoies issue

* add new language methods getContentLanguages and getInstalledLanguages

* let's now load all content languages, including the unpublished ones

* correct label for bug in categories modal field! all other model fields have this

* ups correction in js

* default pivot is language code

* doc blocks corrections

* cs

* language correction thanks brian

* fix conflicts final

* When $this->cursor is false, throw an Exception (#12359)

A call to pg_result_error_field() when $this->cursor is false from a query failing will result in an error `pg_result_error_field() expects parameter 1 to be resource, boolean given`

Try to get a valid error message and throw a JDatabaseExceptionExecuting Exception

* Implement a check / notification for an invalid or missing access file (#12608)

* Implement a check / notification for an invalid or missing access file

* Add language string for invalid or missing access file notification

* Add language string for invalid or missing access file notification

* Reduce log message as suggested by mbabker

* Reduce log message for #12608 as suggested by mbabker

* Reduce log message for #12608 as suggested by mbabker

* Change string to match actual translation text

* Grid within well changed to row-fluid (#11995)

* update doc block (#12569)

* Folder icons in front end (#12551)

* Add folder size to protostar .less

* compiled protostar

* rename folder value (#12579)

* [3.7.x] Regression Hathor modules and users manager (#12412)

* Native language (adjustments after 12036 merge) (#12394)

* restore native language

* remvoe space

* correct

* simplify

* improve code

* ups

* native language in unit test too

* Add detachObserver (#11037)

* Add detachObserver

Adds ability to detach observers

* Simple CS fix

* 3.6.4 Sample data: Escape quota in json data (#12501)

* [fix] new extensions not installed on already existing packages (#12545)

* $menu->params is already a Registry object. (#12557)

* Overridden strings in both back-end and front-end (#12576)

* [imp] remove hardcoded published column (#12585)

* Fix JUri path in language filter plugin (#12600)

* Custom fields (#11833)

* Update gallery.xml

* Update fields.php

* Update internal.php

* Update field.php

* Update dprules.php

* Update section.php

* Update base.php

* Update view.html.php

* Update view.html.php

* Update render.php

* Update modal_article.php

* Update sql.php

* Update fields.php

* Remove commented debug code

* Update fields.php

* #14 fixed Joomla Coding Standards and added function dock blocks code

* #14 fixed Joomla Conding Standards and added function dock blocks

* #14 Fixed class dock block mistake

* we did not require this any more

* #14 fixed Joomla Coding Standards and added function dock block in helper file at back-end

* #14 Fixed only Joomla Coding Standards in FieldsHelper file

* #14 removed where function, added dock blocks and fixed dock bocks coding standards errors

* #14 formatted as the function doc blocks

* #14 formatted as the function doc blocks

* Check the active menu correct

Closes #72

* Move the label field to the options tab

Closes #22

* Label has it's own field and must not stay in params

Regression from #22

* Backport from Digital-Peak/DPFields#32

* Fix the save and copy action

Closes #37

* Store data on reload

Closes #76

* Don't add always the All language to the query

Closes #38

* Count the items in the category manager from com_fields

Closes #61

* Corrected colspan when fields are assigned to a language

* #14 fixed conflict

* Don't save the All category

Closes #19

* Minor language updates

* Fix "Show On" tooltip's description

The tooltip's description for the 'Show On' field is not showing because it is currently looking for the label.

* Don't hardcode com_content.article

Closes #80

* Load the types form when the data is an array

* Create the links correct for the count item feature

Closes #82

* Show the value from com_fields instead of the the users helper

Closes #81

* Set the language correct on the fields cache

Closes #47

* Removed string conversion error

Closes #47

* Changed links to 3.7

* Remove legacy DPFields code

* Get data from state correctly

* Add joins to the com_fields in search plugin (#83)

Add joins to com_fields in the content search plugin

* Add new core rule core.edit.value (#75)

* Add 'onFieldBeforePrepare' and 'onFieldAfterPrepare' events

* Rename "Field Category" to "Field Group"

Closes #91

* Add option to disable custom fields per component

Closes #87

* Use select box to define the images directory

Closes #97

* Truncate correctly

Closes #101

* Change description field to plain textarea

Closes #94
CLoses #99

* Parameters are more clear and improved comment

Adapted change from
32c9048

* onFieldBeforePrepare and onFieldAfterPrepare events now triggered even when custom field value is empty

* Cast before access

* Create params even when they are empty

* Add com_fields menu entries on back end

Closes #109

* Extract the context correctly

Closes #112

* Add custom fields for contact

* Add inline group create

Closes #114

* Add simple context mapping

Closes #117

* Dont assign a not existing category when a field is saved with no catid

* Rename string with group and not category

Closes #124

* Category strings should be named Field Groups

Closes #126

* Show the fields on the blog listing

Closes #108

* Installer crashes somehow

Closes #132

* Merge the types set up into JFormField (#104)

* Merge field types into JFormFields

* Converting the rest of the fields

* Merge DP Field Rendering with Joomla Form Fields

* Remove the gallery scripts

* Rename the interface to JFormDomfieldinterface for auto loading

* Add article field as demo how a component can add fields

* Removing mustache, will be replaced later with a new parser

See #12 for the discussion

* Fixing composer setup, reverting to 3.6.x branch

* Fixing code style errors

Closes #14

* Rename upgrade file to 3.7

* Strip slashes from description

Related to #139

* Removing Simplepie from the database installer script

Reverts 8381e46
See comments for more information

* Show field group description in form

Closes #139

* List field changed key to value and value to name

Closes #121

* Use the first category as field filter when creating an article

Closes #144

* Dont show a user field on the front end

Closes #149

* Add always the fields path when adding the custom fields

Closes #150

* Added hint (placeholder) option

Closes #151

* Correct redirect after checkin action

Closes #154

* Check for group access levels when getting the fields (#153)

* Consider field group state

Closes #155

* Added missing language strings

Closes #129

* JArrayHelper => ArrayHelper

* reduce model method (#160)

* Fixing permission inheritance to edit the value of a field in the form (#157)

* Correct path for parameters folder when not in Joomla libraries

* Type selection (#162)

Closes #134

* Display class attributes (#143)

* User home (#161)

* Add home parameter to media field

* Correct path for paramneters folder when not in Joomla libraries

* Fixing code style errors

* Add new context for com_contact for contact form fields (#115)

* Add new context for com_contact for contact form fields

* Prepare the value on com_contact mail

* Fixing travis code style errors

* Use the correct variable name

Closes #163

* Show the all label when no category is assigned

Closes #165

* Don't set 0 as default hint when not present

Closes #166

* Fix Sniffer Whitespace errors

* Fix Sniffer Whitespace errors (#167)

* Cleanup field model

* Support fields plugins

* Add gallery plugin

* Moved since tag to 3.7

* Some brushup

* Update controller.php

* Update field.php

* Update fields.php

* Update controller.php

* Update fields.php

* Update internal.php

* Update fields.php

* Update fields.xml

* Update field.php

* Update fields.php

* Update type.php

* Update section.php

* Update field.php

* Update field.xml

* Update filter_fields.xml

* Update field.php

* Update view.html.php

* Update edit.php

* Update modal_options.php

* Update view.html.php

* Update default.php

* Update default_batch_body.php

* Update modal.php

* Update field.xml

* Update en-GB.com_fields.sys.ini

* Update en-GB.com_fields.ini

* Update en-GB.plg_fields_gallery.ini

* Update en-GB.plg_fields_gallery.sys.ini

* Update en-GB.plg_system_fields.ini

* Update en-GB.plg_system_fields.sys.ini

* Update modal_article.php

* Update controller.php

* Update field.php

* Update default_custom.php

* Update captcha.php

* Update editor.php

* Update media.php

* Update user.php

* Update editor.xml

* Update media.xml

* Update user.xml

* Update usergrouplist.xml

* Update abstractlist.php

* Update domfieldinterface.php

* Update field.php

* Update email.php

* Update file.php

* Update imagelist.php

* Update sql.php

* Update tel.php

* Update textarea.php

* Update url.php

* Update calendar.xml

* Update checkboxes.xml

* Update imagelist.xml

* Update integer.xml

* Update list.xml

* Update radio.xml

* Update sql.xml

* Update textarea.xml

* Update url.xml

* Update gallery.xml

* plugin

* plugin2

* typo

* Change to uft8mb4

* Add new extensions to the script file

* Revert merge conflict composer changes

* No needed changes

* Library form fields should be unaware of com_fields

* Default to https

* Order the tables correct

* Cleanup language strings

* Code errors from cleanup

* Remove tags support

* Add category filter

* Display fielg group label when editing a group

* Display all fields which are assigned to all languages correct

* Don't show fields on categories as it is not ready yet

* Update fields.php

* Don't transofrm the category name

* Correct quote name function used

* Revert "Display fielg group label when editing a group"

This reverts commit 1331332.

* Disable tags on custom field groups

* Don't include category state in filter on back end

* Remove debug code

* CS fix

* Shortening the line length

* Install SQL files for postgres

* Use JDatabaseQuery

* Option to show the user custom fields on the front on the contact view

* Comment for item_id table column

* Remove class for textareas

* Fix no menu item pages giving wrong links (#12020)

* [plg_system_logout] Load language files only when needed (#11736)

* Update logout.php

* cs and stuff

* Update logout.php

* Adding Options Button (#12033)

* fix paths (#12032)

* Fix routing for non-sef menu items with Modern Routing (#12021)

* [com_banners] - publishing time does not honor timezone (#11978)

* [com_banners ] -  publishing time does not honor timezone

* impress only when needed

impress only when needed

* CS fix

cs fix

* Order stylesheet attributes the same as link attributes (#12052)

* use joomla-projects docker

* Phase out JString calls in libraries (#12058)

* Admin app - JString -> StringHelper (#12056)

* Site app & Plugins - JString -> StringHelper (#12057)

* New Feature, Multilanguage: Add the possibility of displaying associations in article info and in articles list. Replaces #11935 (#12042)

* Replaces

* Modifying to fit Thomas proposal

* modifying fetching flags param

* adding showon + some

* [JAccess] Improve ACL asset preloading performance/memory consumption (#12028)

* improve component asset preload speed

* Update user.php

* Update access.php

* Update access.php

* Update access.php

* Update access.php

* not convinced yet, but revert changes in juser

* make sure that components are always preloaded

* only a logged users (with user id) can be root.

* [com_contact] - moved the captchaEnabled var from default to view (#11964)

* [com_contact] - moved the captchaEnabled var out of the default.php file to the view.html.php file

moved the captchaEnabled var out of the default.php file to the view.html.php file.

* moved captchaEnabled to the view

moved captchaEnabled to the view

* missed var  declarationi/initialization

missed var   $captchaSet  declarationi/initialization

* Session interaction refactoring (#10905)

* Allow lazy starting a session

* Defer starting sessions in the installer

* Defer starting session in JApplicationCms

* Deprecate creating sessions in JFactory

* Start restructuring session load sequence in JApplicationCms

* Add JSession object to onAfterSessionStart event trigger

* Override afterSessionStart for install app to not store the user

* Expand the database storage object for better API

* Fix session listener declaration

* Restructure session bootup and when the session metadata operations run

* 3.5 -> 3.6

* Remove option, out of scope

* Tweak things so the behavior is closer to current API

* Undefined variable

* Get store name from session object

* Remove this, out of scope

* PHPCS fix

* Deep rooted application dependencies are my absolute favorite

* Move comment, doc blocks, consistent method signature

* Again on the consistency, we don't like E_STRICT errors

* Nevermind, confused myself with checkSession, carry on...

* Until the day the unit tests no longer follow the doc block code styles...

* Lost line in merge

* One more merge conflict fix

* This internal coupling is addressed

* Fix query from merge

* [com_content] - add articles ordering by votes, ratings (#11225)

* Add setDocumentTitle() function in JViewLegacy (#11399)

* setDocumentTitle() function in JViewLegacy

* PHPCS

* JED turned to https (#12076)

* JED truned to https

JED truned to https
Minor fixes on proper use of Joomla!

* Update README.txt

Same as #12076

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED turned https

* JED and community turned https

* JED, community and org turned https

* JED and community turned https

* JED and community turned https

* correct/add quotename (#12070)

* Label: Users Options: Login name > Username (#12073)

The language label "Change Login Name" is not consistent with the front-end label "Username".

This PR changes the language label to "Change Username" and the decription to "Allow users to change their Username when editing their profile."

The front-end login screens use the label "Username"
Login Component:
![login-component](https://cloud.githubusercontent.com/assets/1217850/18627996/579510ca-7e5e-11e6-9161-6268e9ccb213.png)

Login Module:
![login-module](https://cloud.githubusercontent.com/assets/1217850/18627997/579595ae-7e5e-11e6-8920-edf34631a3c7.png)

### Testing Instructions
#### Before the PR
Users > Manage > [Options] > [User Options]
The last entry is "Change Login Name" 
+ hover description "Allow users to change their Login name when editing their profile."

![login-back-end-options](https://cloud.githubusercontent.com/assets/1217850/18627995/5791ac32-7e5e-11e6-8b18-94a34372c422.png)


#### After the PR
Users > Manage > [Options] > [User Options]
The last entry is "Change Username" 
+ hover description "Allow users to change their Username when editing their profile."

![login-back-end-options-after](https://cloud.githubusercontent.com/assets/1217850/18627998/5799ceb2-7e5e-11e6-9a5e-234dcf2db14e.png)

* Update .travis.yml (#12079)

* Add vote order check

* [a11y] Protostar back to top (#12446)

* [a11y] Protostar - back to top link

* Oops Andre was right

* add anchor for non-js enabled browsers

* Added missing com_fields component from last merge

* Replace Platform version numbers in libraries/legacy (#12242)

* Remove variable declaration (Fix #12619)

* Misc. fixes

* Test fixes

mbabker added a commit that referenced this pull request Mar 25, 2018

[com_fields] Normalise the request com_fields data (#19884)
* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

Ruud68 added a commit to Ruud68/joomla-cms that referenced this pull request Mar 26, 2018

[com_fields] Normalise the request com_fields data (joomla#19884)
* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (joomla#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (joomla#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (joomla#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (joomla#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

Ruud68 added a commit to Ruud68/joomla-cms that referenced this pull request Mar 31, 2018

[com_fields] Normalise the request com_fields data (joomla#19884)
* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (joomla#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (joomla#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (joomla#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (joomla#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

Ruud68 added a commit to Ruud68/joomla-cms that referenced this pull request Apr 3, 2018

[com_fields] Normalise the request com_fields data (joomla#19884)
* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (joomla#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (joomla#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (joomla#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (joomla#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

mbabker added a commit that referenced this pull request Apr 7, 2018

Custom Fields toggle display on read only rights (#20068)
* [com_fields] Normalise the request com_fields data (#19884)

* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

* Custom fields view on form via toggle on read-only rights

* fix back-end new article

* first / seperate check on read-only access

* refactor code so show_on parameter is part of helper function

* implement inherit value in fields + language things

* loadmodel only when needed

* changed function comment

* change values order so default value (inherit) is displayed first

* Must use self:: for local static member reference

SharkyKZ added a commit to SharkyKZ/joomla-cms that referenced this pull request Apr 27, 2018

Sync (#2)
* Refresh Manifest Cache failed: Extension is not currently installed (joomla#19560)

* Refresh Manifest Cache failed: Extension is not currently installed

PR for joomla#17604

Change the message to include the name of the extension.

I have no idea how to test this - sorry - only code review - unless someone knows how?

* partial revert

* revert comment

* Remove rtrim() since it allows invalid emails (joomla#20080)

* Custom Fields toggle display on read only rights (joomla#20068)

* [com_fields] Normalise the request com_fields data (joomla#19884)

* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (joomla#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (joomla#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (joomla#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (joomla#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

* Custom fields view on form via toggle on read-only rights

* fix back-end new article

* first / seperate check on read-only access

* refactor code so show_on parameter is part of helper function

* implement inherit value in fields + language things

* loadmodel only when needed

* changed function comment

* change values order so default value (inherit) is displayed first

* Must use self:: for local static member reference

* Fixed page with multiple codemirror editors fields with different syntax highlighting (joomla#20063)

* Fix for: Can't choose module using editor plugin if you search first (joomla#20005)

* fixit

* cs

* Update modal.php

* Basic check to make sure the bulk import seperator is being used. (joomla#19982)

* Basic check to make sure the bulk import seperator is being used.
Added Import State function as to how the urls should be imported, enabled or disabled.

* force int.

* Update config.xml

* Update links.php

* Update en-GB.com_redirect.ini

* Update config.xml

* Update links.php

* Update en-GB.com_redirect.ini

* Update config.xml

As per standards i.e:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/model/form/application.xml

i.e. endtag inline with options and closing tag inline with opening tag.

* Update links.php

* Changed none selected to none, to be used when there are none availab… (joomla#19977)

* Changed none selected to none, to be used when there are none available to select and when none are selected.
Set select to be readonly is they cannot select any options

* Update plugins.php

* Update plugins.php

* Update en-GB.ini

* Update en-GB.ini

* Update plugins.php

* Update plugins.php

* Update plugins.php

* Update plugins.php

* Update plugins.php

Space/tabbing for drone.

* Update plugins.php

* Corrected bug on empty subject of com_mailto (joomla#19956)

* Corrected bug on empty subject

If the subject is empty, the posted value is an empty string (exists) so the default value is never added.

* Updated code to include null value

* text corrections (joomla#20111)

* Typo and copy paste error (joomla#20123)

Someone couldn't spell and then someone else must have copy pasted the error

No idea how to test but this has been wrong since 3.5

* correct the use of the use command and move it below the defined command (joomla#20130)

* Prepare 3.8.7 RC

* Reset for dev

* Add a security policy (joomla#20163)

* Add a security policy

Many projects now add a SECURITY.md document to their repository. Often this is related to using HackerOne but not always.

This PR adds a policy to our github repo. It is based on the existing policy on the d.j.o web site

The file doesn't need to be distributed so it has been added to the exclude list in the github repo.

* tweek

* copy paste

* Update SECURITY.md

* Update SECURITY.md

* Prepare 3.8.7 release

* Reset for dev

* Introduce CODEOWNERS (joomla#20137)

* Tidy writeDynaList() (joomla#12184)

* Cleaned writeDynaList() in core.js

* Removed explanation comments

* removed all API changes

* updated compressed core.js

* [fix] publish/unpublish does not work with tables using null as default checked_out value (joomla#20204)

* Fix overwrite by .table-striped (joomla#20180)

Fix overwrite by administrator/templates/isis/css/template.css line 1787

table.table-striped tbody > tr:nth-child(odd) > td,
table.table-striped tbody > tr:nth-child(odd) > th {
	background-color: #f9f9f9;
}

* Fix overwrite by .table-striped (joomla#20179)

Fix overwrite by administrator/templates/isis/css/template.css line 1787

table.table-striped tbody > tr:nth-child(odd) > td,
table.table-striped tbody > tr:nth-child(odd) > th {
	background-color: #f9f9f9;
}

* Tooltips not loading com_users (joomla#20177)

The edit profile form is not loading the bootstrap tooltip code. So any tooltip (not popovers) are displayed as html as seen in the screenshot below when TFA is enabled.

This was spotted by @o2tsen and @sandewt while testing joomla#20051 but as it is a bug effecting more than that PR I have created a new PR. (a pr should only fix one problem)

* [a11y] Headings consecutive order Debug Console (joomla#20167)

> Headings communicate the organization of the content on the page. Web browsers, plug-ins, and assistive technologies can use them to provide in-page navigation.

> Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a < h2> is not followed directly by an < h4>, for example.

Source (https://www.w3.org/WAI/tutorials/page-structure/headings/)

The headings were probably chosen for cosmetic reasons and not structural reasons which they should have been

This PR changes the heading in the debug console from h1 to h2

There is a very small visual change as a result but imho the benefits outweigh the small cost

* [a11y] Headings consecutive order (joomla#20166)

* [WIP] [a11y] Headings consecutive order

> Headings communicate the organization of the content on the page. Web browsers, plug-ins, and assistive technologies can use them to provide in-page navigation.

> Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a <h2> is not followed directly by an <h4>, for example.

Source (https://www.w3.org/WAI/tutorials/page-structure/headings/)

This PR changes the heading in the plugin and modules from h3 to h2 and in the template styles to h4

### todo
joomla.edit.item_title layout uses h4 but before I change it I need to check everywhere that it is being used

* layout

* Fix typos in InstallerControllerUpdate (joomla#20154)

* Fix typos in InstallerControllerUpdate

* Fix same error on other places. Thanks @Quy

* Remove similar unnecessary code

* Revert "Remove similar unnecessary code"

This reverts commit 56410c0.

* One more

* Revert "One more"

This reverts commit aa1b101.

* [com_contact] Don't hide contact filter form (joomla#20126)

* Update default_items.php

* Correct implode order.

* Codestyle

* More codestyle

* Fix for JUserHelper::addUserToGroup() when user group title is a number. (joomla#20091)

* Update UserHelper.php

* Update UserHelper.php

* Fix count() in PHP 7.2 (joomla#20044)

* [com_content][Multilanguage] - remove duplicated queries (joomla#19683)

* [com_content][Multilanguage] - remove duplicated queries

* cs

* add $db->qn()

* removed ()

* Make CodeMirror work in repeatable subforms (joomla#12542)

* One function to initialize any and all CodeMirror instances rather than individual functions to initialize one-by-one. Call on page load and also on subform-row-add

* Minor js changes

* Codemirror fullscreen modifier message (do we still need this?)

wilsonge added a commit that referenced this pull request Jun 14, 2018

[4.0] Replace "label" classes with the new "badge" ones (#20328)
* Prepare 3.8.4 Release Candidate

* Reset for dev

* Regression in the ISIS backed css

PR for #19411

* Regression: Isis RTL forgotten in 19417 (#19423)

* [com_content] - archived legacy SEF fix (#19397)

* [com_content] - archived legacy sef fix

* cs

* Fix media manager 'up' button (#19443)

* Regression at createUri from #19099 (#19415)

* [installer] - sanitize extensions type as lower case (#18416)

* Fix filter by multiple categories (#19450)

* Fix filter by multiple categories

* Remove debug code

* 2nd Release Candidate for 3.8.4

* Do not add unnecessary parameters in the archive link (#19447)

* Do not add unnecessary parameters in the archive link

* Remove php notice

* Unset parameter month=0 when year is not set

* Prepare 3.8.4 release

* Reset for development

* Move from protocol relative links to https for google fonts imports (#19488)

* move to protocol relative links to https

* fix one broken font link

* Revert "Regression at createUri from #19099 (#19415)"

This reverts commit 128a4d4.

* Revert "Correctly redirect after logging into the multilingual joomla with association enabled (#19295)"

This reverts commit 5994eb1.

* Revert "Fix parser error in plugin languagefilter on php5 (#19268)"

This reverts commit 05fd1d9.

* Revert "Do not add default or active Itemid to every link without own menu item (#19099)"

This reverts commit d068868.

* Update CMSApplication.php (#19514)

* CodeMirror Updated to 5.34.0 (#19533)

* Prepare 3.8.5 release candidate

* Reset to dev

* Revert "Do not add unnecessary parameters in the archive link (#19447)"

This reverts commit 0155f35.

* Revert "[com_content] - archived legacy SEF fix (#19397)"

This reverts commit 01a9147.

* Prepare 3.8.5 release

* Reset for dev

* Changed parameter to bool (#19573)

* Removed orphan weblinks languages (#19495)

* Changing loading order for between Redirect and Logout system plugins at (#19489)

install time

* mod_articles_news. Define $item_heading only if needed (#19439)

* mod_articles_news. Define $item_heading only if needed

* Update _item.php

* Update _item.php

* Fix count() in PHP 7.2 (#19396)

* Fix count()

* Simplify check

* [CS] Code style Tabs must be used to indent lines; round 1 (#19350)

* Tabs must be used to indent lines; round 1

Tabs must be used to indent lines; spaces are not allowed

* Fix some indent issues not fixed by the auto fixer

nothing is perfect, sometimes we need to make some minor adjustments.

* fix line issue

* Make suggested changes to reflect general code style

* Add space after ;

- correct indenting
- remove extra ;
- correct spaces

* &nbsp; was on it's own line

* fix missing semicolon

* align equals

replace tab with spaces on line 25

* remove extra space

* fix missing semicolons

fix some spacing around operators

* com_mailto remove unused params (#19290)

I was checking to see why we had an untranslated string and as far as i can tell this entire params section is not used

To test apply pr and make sure that the send to friend functionality works as before

* [com_fields] Fields are not copied when batch duplicating an article (#16958)

* [#16740] - [com_fields] Fields are not copied when batch duplicating an article

* user deploy version over the wrong since tag ;)

* [#16740] - [com_fields] Fields are not copied when batch duplicating an article

* Handle modified date in Document objects consistently (#19592)

* Delete existing user_keys, if password is changed (#17827)

* Delete existing user_keys, if password is changed

* corrected styling issues

* deploy version - as I said, this is my first pr

* pushing to patch-2

* newline after }

* push to patch-2

* push to patch-2

* Update en-GB.com_users.ini

* Update remember.php

* Update remember.xml

* configuration option in XML file

radio button option to activate/deactivate the "reset RememberMe" functionality on password-change.

* Update en-GB.plg_system_remember.ini

* hm...

* Update remember.php

* Update remember.php

* XML styles

* commenting out the user message

* Update remember.php

* Update en-GB.plg_system_remember.ini

* btn-group-yesno

* Update remember.php

* Update remember.php

* reference to Alice Ruggles removed!

* making it mandatory

* Update remember.php

* making it mandatory

* making it mandatory

* making it mandatory

* as per the remarks of Quy

changed

* changed as per Quy's remarks

* [CS] Code style Tabs must be used to indent lines; round 2 (#19351)

* [CS] Code style Tabs must be used to indent lines; round 2

- Tabs must be used to indent lines; spaces are not allowed

* fix some indenting not fixed by the auto fixer

* Fix some more indenting and spacing

* use and/or in template mixed HTML/PHP files

For consistancy, Until a decision is made on joomla/coding-standards#191
use `and`/`or` in template mixed HTML/PHP files rather than our normal
required `&&`/`||` requierment that we have for full PHP files

* Use the && and || operators

preferences to Use the && and || operators

* Remove space indent exceptions (#19609)

* remove space indent exceptions

* tab indent not spaces

* Tabs must be used to indent lines; spaces are not allowed

* Tabs must be used to indent lines; spaces are not allowed

try using the concatenation to fix space indent strangeness

* Tabs must be used to indent lines; spaces are not allowed

* [3.9] Tweak update percentage message to include %-sign (#19628)

* Tweak update percentage message to include %-sign

* Add minified version.

* Typo Joomla is vegetarian (#19649)

Quick fix to the spelling of meet

* Plain English cont. (#19654)

The accessibility standard Web Content Accessibility Guidelines (WCAG) 2.0 Section 3 states https://www.w3.org/TR/WCAG20/#understandable

>### 3. Understandable
> Information and the operation of user interface must be understandable.

>#### Guideline 3.1 Readable
> Make text content readable and understandable.

> #### Success Criterion 3.1.5 Reading Level
> When text requires reading ability more advanced than the lower secondary education level after removal of proper names and titles, supplemental content, or a version that does not require reading ability more advanced than the lower secondary education level, is available.

To achieve this we should use "plain language" wherever possible

1. Word choice: use the simplest word that conveys your meaning.
http://plainlanguagenetwork.org/plain-language/what-is-plain-language/

2. Prefer the short word to the long.
https://www.plainlanguage.gov/guidelines/words/

This PR continues the work and removes the superfluous text " to make it possible"

* Plain English (#19629)

* accordingly

* advised => recommended

* assist => help

* attempt=>try

* concerning => relevant

* contains => has

* containing -> with

* contains=-> has

* Currently -> (omit)

* designated -> marked

* initial -> first

* initialise->start

* in order to -> to

* it is -> (omit)

* optimal -> best

* regarding->on

* remain -> stay

* terminated -> stopped

* word order

* Fix PHP Warning for Session on PHP 7.2 (#19199)

* Fix PHP Warning for Session on PHP 7.2

* CS

* Correctly call function with the parameter by reference (#19233)

* Better code for set category view layout (#19238)

* [Modern Routing] make a simpler loop in StandardRules::build (#19271)

* Simpler loop in build method of StandardRules

* Now use last_id only

* Remove useless code

* Remove support for new router configuration

* Improve performance of the com_content category view for a huge number of articles (#19284)

* Multilingual: Associated categories should display only when published (#19551)

* Multilingual: Associated categories should display only when published

* cs

* cs

* [CS] Array list style (#19610)

* array list style

* array list style

* array list style

* array list style

* Prevent compounding inputmode attribute (#19632)

* Fix user profile plugin (#19633)

* Update pagebreak plugin description (#19653)

Simple PR to update the very outdated text suggesting that the page break button is normally found under the article text area.

* Chinese calendar js files don't load on Linux because they are not (#19662)

lowercase.

* Typo (#19675)

Simple PR to fix a typo in a string

* Implement Session GC Cli (#19548)

* Implement Session GC Cli

* CS add new line

* Add deprecate log message for the pathway name attribute (#19700)

* Add deprecate log message for the name attribute

* Spelling

* typo (#19691)

* typo

can be merged on review

* more

* Possible misprint (#19688)

I think $ids array stores articles ids, because $articleModel->getItem()->id. Maybe copy-paste from line 159/line 206?
Also, this possible misprint can be found in  4.0 branch.

* Add the missing import in the application (#19709)

* Add the missing import in the application

* Use the local logger

* fix 404 on github dokukmentation links (#19775)

* Articles - Latest (#19664)

The descriptions says "This module shows a list of the most recently published and current Articles."

So if they are "current" then they cant also "may have expired"

Simple PR to correct that on the front end

For the admin version of the module the change is a little different as here the list will show all the articles irrespective of their current published state so the string change is different and is just a simplification and not a correction

* reCAPTCHA V1 stops on March 31 (#19648)

* reCAPTCHA V1 stops on March 31

Google have emailed directly anyone using v1 reCAPTCHA keys but users don't read their email.

This PR adds a post-installation message IF they have the reCAPTCHA plugin enabled AND they are using v1 keys.

This PR also updates the messages in the plugin informing them that V1 will not work after march 31

@mbabker already completely refactored the plugin for J4 to remove V1 etc this PR is ust for the messages

* CS - new lines

* use query to find the extension_id and not haardcoded

* docblock

* 3.8.6

* Update actions.php

* System Information (#19764)

* System Information

We had the db version and the db collation but not the type
This PR adds the database type eg postgresql, mysql etc

* Update sysinfo.php

* rename and move

* rename

* Overrides do not find 3rd party plugins languages when files are in the (#19740)

plugin

* Com_redirect: Differentiating utf8 old_url (#19734)

* TinyMCE: uglify the inline XTD-btns script (#19731)

* remove tabs and returns and spaces

* more compression

* Add some comments so others can follow the code

* Doh, this code was for J4

* reninitialise the array 😡

* Update bootstrap-rtl.css (#19715)

* Update bootstrap-rtl.css

Duplicate entry .radio.btn-group > label:first-of-type

* Update bootstrap-rtl.less

Removed 2nd occurrence of  .btn-group > .btn:first-child, .radio.btn-group > label:first-of-type

* Hide global configuration and system information from non super users (#19697)

* Hide global configuration and system information from non super users

* Use identical operator

* [a11y] Cache toolbar (#19686)

We use the icon name to populate the ID. This toolbar has the same icon for both buttons so we have two buttons with the same id which is an accessibility failure

This pr ensures every id attribute value is unique

Because the icon has multiple names we can simply use one of the alternative names as a quick and dirty fix.

There is no visual change

* Wrong desc fixed. Changed title to document! (#19685)

* Wrong desc fixed. Changed title to document!

* Update Document.php

* Move custom buttons to the other buttons in TinyMCE (#19656)

* Proxy to a higher error handler if there is one available (#19645)

* Correct output_buffering check in 3.8.x (#19611)

* correct output_buffering check in 3.8.x

* simplified the check @Quy

* this is why we can not have nice things.. fixing the check for output_buffering

* Pass the configuration tmp_path to the archive package for extension installations (#19608)

* pass the configuration tmp_path to the archive package for extension installations

* add missing \

* Improve header handling in PageController cache (#19591)

* Defining typeAlias (#19647)

* Fix JRoute('&var=...') not adding current URL variables when current URL is the home page (#19582)

* Fix loosing current URL vars when in home page

* Update SiteRouter.php

* Test units

* Test units

* [TemplateAdapter.php] Rewrote hardcoded SQL to query object (#17923)

* rewrote hardcoded SQL to query object

* correction in SQL for home field is declared as char/varchar

* correction in SQL for home field is declared as char/varchar + ->q()

* the requested change from @Quy

* added microdata (#17689)

* [Schema checker] (Database FIX) Add support for checking NULL and DEFAULT column attributes (#17351)

* [Schema checker] (Database FIX) Add support for checking NULL and DEFAULT column attributes

* CS

* Update en-GB.com_installer.ini

* english

* The One Right Session Management Configuration For Joomla! 3 (#19687)

* Session garbage collection plugin

* Session metadata manager

* Expand metadata manager to allow all apps, CLI for metadata cleaner

* Move metadata cleanup to the plugin

* Misc fixes from feedback

* Language tweaks

* Change to uint filter, if it'll get people to review and accept the damn PR...

* Fix mssql installation (#19796)

* Prepare 3.8.6 RC1 Release

* Reset for dev

* Update Greek Installation language files (#19806)

* Another typo in Greek (#19816)

* checksum extensions light (#17619)

* [3.8] - checksum extensions

porting checksum extensions from 4.0

* install checksum

add install checksum

* update checksum

add update checksum

* lang

add lang string

* doc block

add missing parameter

* tab

tab

* PHP cs

* PHP CS

* return integer

return integer instead of mixed

* switch

switch inteder

* switch

switch integer

* add CONST and remove sha1/md5

add CONST and remove sha1/md5

* hash algos

hash algos

* sha256,sh384,sha512

hash algos

* alpha order

alpha order

* fix docbloc

fix docbloc

* Revert "checksum extensions light (#17619)" (#19873)

This reverts commit 4d79fe2.

* Update spanish installation language (#19878)

* implement check provided by @ggppdk (#19791)

* Fix undefined index: password_clear (#19892)

* Prepare 3.8.6 release

* Reset for development

* Fix appveyor builds and bump driver dll version (#19805)

* bump driver dll version and add php 7.2

* remove php 7.2 until drivers are available

* Use powershell 'Invoke-WebRequest' Workaround

When you use appveyor command-line utility to download, its user-agent is empty, 
Some sites do not allow empty user-agents to download. 
Use powershell 'Invoke-WebRequest' Workaround until appveyor fixes their command-line utility to have a user agent

* Don't have a metadataManager class property to avoid circular dependency problem when instantiating multiple applications (#19912)

* typo (#19910)

typo

* Clear button in article publish date (#17809)

* For clear button issue

* Update calendar.js

* Update module.php

* Remove commented line

* [com_templates] Rewrote hardcoded SQL to query object (#17921)

* rewrote hardcoded SQL to query object

* correction in SQL for home field is declared as char/varchar

* correction in SQL for home field is declared as char/varchar + ->q()

* Break where clauses up

* Fix Help URLs and update to Help38 (#19181)

* Fix Help URLs

* Update to Help38

* Fixed trig on change event (#19538)

* [com_content] - fix link when layout and association (#19681)

* Date format localise (#19690)

* Add new date format LC6

* LC6

* commit 2

* [behavior.formvalidator] - pattern attribute behaviour fix (#19771)

* [behavior.formvalidator] - pattern behaviour fix

* minify

* Fix a subform table layout to be more strict to rows container (#19774)

* mod_breadcrumbs. remove JHtml::bootstrap.tooltip (#19787)

* Debug plugin style (#19790)

* Debug plugin style

Wrong css on the buttons for Log Category Mode

It should be green for the positive action (include) and red for the negative action (exclude)

This simple PR ensures that is the case

* oops

* Front end menu items translated in error (#19802)

* Front end menu items translated in error

PR #13606 introduced translatable admin menu item creation but the code didnt check if the menu item was for the frontend or the admin before doing the translation

### Test Instructions
1. Install any additional language eg italian
2. Create a menu item called "Sun"
3. On the list of all the menu items you will see it is displayed as "Dom" - the italian translation
4. Enable language debug
5. On the list of all the menu items you will see all your menu item titles are surrounded by ?? - to indicate no translation found -  except for "Dom" which has ** instead to show it has been translated
6. Apply this PR
7. Sun still says Sun
8. There are NO ?? or ** when in language debug mode
9. Bonus - check a custom admin menu item and you will see it can be translated

* code style

* cs

* CodeMirror 5.35.0 (#19809)

* Correcting finder feeds items date when language is not English (#19815)

* Correcting finder feeds items date when language is not English

* typo

* [com_ajax] Change modules check (#19818)

* Add com_ajax check in getModuleList query

* Restore getModuleList query

* Change module check inside com_ajax

* Categories: Allow sorting by Associations (#19821)

* Categories: Allow sorting by Associations

* moving assoc sorting after access

* Article and contact modal should not use addslashes (#19826)

* Menu tems select field: no need to escape string value (#19828)

* Allow limiting calendar field to current year (#19846)

* Allow locking to min and / or max year to current year

* Update calendar.php

* Cleared non-set variable notices

* Update JHtml::calendar to support relative years limits (#19847)

* Simplify switch statement (#19849)

* [CS] Code style Fix some inline doc blocks for IDE hinting - round 1 (#19862)

* Fix Operator Spacing

* Fix inline doc blocks for IDE hinting

* Fix some docblocks and comments (#19863)

* Custom admin menus: Translating menu items titles (#19900)

* adapt default values (#19924)

* Use getter method (#19925)

* Custom Admin menu item edit: Display Title, Parent Item and Ordering translations (#19916)

* Admin menu item edit: Display Title, Parent Item and Ordering
translations

* Modifs suggested by izharaazmi

* cs

* display translated title only when item exists

* Correcting label alignment

* Cosmetic changes

* In theory, you may not always be working with the default database. So use the correct one. (#19474)

* [plugin][content] - loadmodule by id (#19362)

* [plugin][content] - loadmodule by id

* [plugin][content] - loadmodule by id

* getModuleById

* getModuleById

* id not found

* id not found

* simple syntax

* js side

* modal

* minify js

* regex only digits

* remove title

* use static load()

* regex

* cs

* return

* cs tabs removed

* simplify code

* clean code

* no style

* replace loadmodule with loadmoduleid

* cs

* replace loadmodule with loadmoduleid

* replace

* missed echo

* moved back

* Update loadmodule.php

fixed cs

* Revert "[plugin][content] - loadmodule by id (#19362)" (#19931)

This reverts commit 4172f79.

* Category Modal - add notes (#19131)

* Category Modal - add notes

If you add a note to a category then it is displayed in the category list but not displayed in the category modal (eg when you select a category for a blog menu item)

This PR adds the note, alias, and full path (on hover) to the modal to make it consistent with the list view

* space

* Please consider a blank line preceding your comment (#19936)

* Fix typo in editor field (#19938)

* [CS] long form function return types; round 1 (#19934)

* PHPCS2 - fixes

* 2 spaces after

* Expected 2 spaces after the longest param type

* [libraries][legacy][request] - fix php 7.1 warning not numeric (#19710)

* [libraries][legacy][request] - fix php 7.1 warning not numeric

* dry

* [com_fields] Normalise the request com_fields data (#19884)

* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

* [event dispatcher]  - use strict comparison (#19907)

* [com_users] Fix display of custom field of value 0 (#19933)

* [CS] long form function return types; round 2 (#19935)

* PHPCS2 Auto Fixes

- Expected "boolean" but found "bool" for function return type
- Expected "integer" but found "int" for function return type

* Manual correction of docBlock spacing

* Manual correction of docBlock spacing

* Manual correction of docBlock spacing

* Manual correction of docBlock spacing

* Add some Member var comments

* Manual correction of docBlock spacing

* Add some Member Var comments

* return tag after access tag

* 3 spaces after var tag before the type

* add tag since 3.1 to Class Properties and align var tags

* add tag since 3.1 and align var tag

* adjust some tag alignments

* Two spaces after type

* integer not int

* Redirects Plugin - Make Relative or Absolute. (#19942)

* Redirects Plugin - Make Relative or Absolute.

* Orderiing and capital I.

* Update en-GB.plg_system_redirect.ini

* Update en-GB.plg_system_redirect.ini

updated as per @quys comment.

* Update en-GB.plg_system_redirect.ini

* Make calendar output usable in other css-frameworks (#19944)

* Revert changes expect css

* Make calendar output usable in other css-frameworks

* A min-width makes look better

* Fix for duplicate url check bug introduced by #19734 and support utf8… (#19950)

* Fix for duplicate url check bug introduced by #19734 and support utf8 on old_urls.
Couldn't find a solution to handle this within mysql. So a simple foreach handles it perfectly.

* Update link.php

* solved issue number #19930 (#19969)

corrected typo to ensure proper checkbox functionality

* Removed text-output and enabled a disabled tick box for consistency (#19974)

* Change to allow str_pos to match when the exclude term is at the root… (#19979)

* Change to allow str_pos to match when the exclude term is at the root of the path

* updated redirect.php - clearly I was tired with the first pr.

* Fix for #11070 (tag-category) - Improve also views newsfeed-category … (#16627)

* Fix for #11070 (tag-category) - Improve also views newsfeed-category and category-list

* Correctly modifying .LESS and regenerate .CSS (#16627)

* Simple enhancement to allow the user to make all Post Install Messages read (#19958)

* Simple enhancement to allow the user to make all Post Install Messages as read.

* Update message.php

* Update messages.php

* Update messages.php

* Added onDisplay function for handling the display of the button.

* removed blank lines.

* updated quotes around ints.

As per @alikon comments

* Added (int) just to be safe.

* Update messages.php

* Update messages.php

* Update messages.php

* [com_mailto] Add missing placeholder (#19999)

* Make sure items is an array. (#20000)

* Make sure items is an array.

Resolved #19998

* Update default_items.php

* Update tag.php

* Update tag.php

* Update tag.php

* Update tag.php

* [com_fields] Fix fields display HTML prepared 4 or 5 times per article, make it be prepared only twice (#17895)

* Pass field displayType (aka event type) to getFields

* Update getFields to respect the 'display' parameter of every field

* Update onContentPrepare to respect 'display' parameter of every field

* Prepare for manual display

* Do not create $item->jcfields multiple times

* Revert the code for manual display to always prepare the field value

* Wrong function name

* Fix docblock

* Better comment for parameter of getFields method

* fix media field in ISIS Template (#17205)

* fix media field in ISIS Template

* fix media field in ISIS Template

* [3.x] New sessiongc plugin is not declared as core plugin for manifest cache refresh (#20038)

* add sessiongc plugin to the core plugins

* alphasorting thanks @brianteeman

* [module] [articles category] filter by multiple tags (#19983)

* [module] [articles category] filter by multiple tags

* multiple tags

* spelling

* [com_finder] Remove unused params (#20009)

* [com_finder] Unused params

* Update en-GB.com_finder.ini

* Update sample_learn.sql

* Update sample_testing.sql

* Update sample_learn.sql

* Update sample_testing.sql

* Update sample_learn.sql

* Update sample_testing.sql

* Update jos_menu.csv

* Restore and deprecate strings

* Two new fonts for CodeMirror: IBM Plex Mono, Nanum Gothic Coding (#20017)

* CategoryEdit field published filter (#20018)

* Smart Search: Highlighting terms also in fulltext when using readmore (#20019)

* Smart Search: Highlighting terms also in fulltext when using readmore

* parsing summary + body to get text only

* Escape full query in NestedTable debug mode (#20024)

* Changed viewname filter in RouteHelper (#20031)

* Fix GMail plugin so it doesn't crash and burn on 4.0 upgrades (#20043)

* Tweak build script for added flexibility (#19848)

* Refresh Manifest Cache failed: Extension is not currently installed (#19560)

* Refresh Manifest Cache failed: Extension is not currently installed

PR for #17604

Change the message to include the name of the extension.

I have no idea how to test this - sorry - only code review - unless someone knows how?

* partial revert

* revert comment

* Remove rtrim() since it allows invalid emails (#20080)

* Custom Fields toggle display on read only rights (#20068)

* [com_fields] Normalise the request com_fields data (#19884)

* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

* Custom fields view on form via toggle on read-only rights

* fix back-end new article

* first / seperate check on read-only access

* refactor code so show_on parameter is part of helper function

* implement inherit value in fields + language things

* loadmodel only when needed

* changed function comment

* change values order so default value (inherit) is displayed first

* Must use self:: for local static member reference

* Fixed page with multiple codemirror editors fields with different syntax highlighting (#20063)

* Fix for: Can't choose module using editor plugin if you search first (#20005)

* fixit

* cs

* Update modal.php

* Basic check to make sure the bulk import seperator is being used. (#19982)

* Basic check to make sure the bulk import seperator is being used.
Added Import State function as to how the urls should be imported, enabled or disabled.

* force int.

* Update config.xml

* Update links.php

* Update en-GB.com_redirect.ini

* Update config.xml

* Update links.php

* Update en-GB.com_redirect.ini

* Update config.xml

As per standards i.e:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/model/form/application.xml

i.e. endtag inline with options and closing tag inline with opening tag.

* Update links.php

* Changed none selected to none, to be used when there are none availab… (#19977)

* Changed none selected to none, to be used when there are none available to select and when none are selected.
Set select to be readonly is they cannot select any options

* Update plugins.php

* Update plugins.php

* Update en-GB.ini

* Update en-GB.ini

* Update plugins.php

* Update plugins.php

* Update plugins.php

* Update plugins.php

* Update plugins.php

Space/tabbing for drone.

* Update plugins.php

* Corrected bug on empty subject of com_mailto (#19956)

* Corrected bug on empty subject

If the subject is empty, the posted value is an empty string (exists) so the default value is never added.

* Updated code to include null value

* text corrections (#20111)

* Typo and copy paste error (#20123)

Someone couldn't spell and then someone else must have copy pasted the error

No idea how to test but this has been wrong since 3.5

* correct the use of the use command and move it below the defined command (#20130)

* Prepare 3.8.7 RC

* Reset for dev

* Add a security policy (#20163)

* Add a security policy

Many projects now add a SECURITY.md document to their repository. Often this is related to using HackerOne but not always.

This PR adds a policy to our github repo. It is based on the existing policy on the d.j.o web site

The file doesn't need to be distributed so it has been added to the exclude list in the github repo.

* tweek

* copy paste

* Update SECURITY.md

* Update SECURITY.md

* Prepare 3.8.7 release

* Reset for dev

* Introduce CODEOWNERS (#20137)

* Tidy writeDynaList() (#12184)

* Cleaned writeDynaList() in core.js

* Removed explanation comments

* removed all API changes

* updated compressed core.js

* [fix] publish/unpublish does not work with tables using null as default checked_out value (#20204)

* Fix overwrite by .table-striped (#20180)

Fix overwrite by administrator/templates/isis/css/template.css line 1787

table.table-striped tbody > tr:nth-child(odd) > td,
table.table-striped tbody > tr:nth-child(odd) > th {
	background-color: #f9f9f9;
}

* Fix overwrite by .table-striped (#20179)

Fix overwrite by administrator/templates/isis/css/template.css line 1787

table.table-striped tbody > tr:nth-child(odd) > td,
table.table-striped tbody > tr:nth-child(odd) > th {
	background-color: #f9f9f9;
}

* Tooltips not loading com_users (#20177)

The edit profile form is not loading the bootstrap tooltip code. So any tooltip (not popovers) are displayed as html as seen in the screenshot below when TFA is enabled.

This was spotted by @o2tsen and @sandewt while testing #20051 but as it is a bug effecting more than that PR I have created a new PR. (a pr should only fix one problem)

* [a11y] Headings consecutive order Debug Console (#20167)

> Headings communicate the organization of the content on the page. Web browsers, plug-ins, and assistive technologies can use them to provide in-page navigation.

> Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a < h2> is not followed directly by an < h4>, for example.

Source (https://www.w3.org/WAI/tutorials/page-structure/headings/)

The headings were probably chosen for cosmetic reasons and not structural reasons which they should have been

This PR changes the heading in the debug console from h1 to h2

There is a very small visual change as a result but imho the benefits outweigh the small cost

* [a11y] Headings consecutive order (#20166)

* [WIP] [a11y] Headings consecutive order

> Headings communicate the organization of the content on the page. Web browsers, plug-ins, and assistive technologies can use them to provide in-page navigation.

> Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a <h2> is not followed directly by an <h4>, for example.

Source (https://www.w3.org/WAI/tutorials/page-structure/headings/)

This PR changes the heading in the plugin and modules from h3 to h2 and in the template styles to h4

### todo
joomla.edit.item_title layout uses h4 but before I change it I need to check everywhere that it is being used

* layout

* Fix typos in InstallerControllerUpdate (#20154)

* Fix typos in InstallerControllerUpdate

* Fix same error on other places. Thanks @Quy

* Remove similar unnecessary code

* Revert "Remove similar unnecessary code"

This reverts commit 56410c0.

* One more

* Revert "One more"

This reverts commit aa1b101.

* [com_contact] Don't hide contact filter form (#20126)

* Update default_items.php

* Correct implode order.

* Codestyle

* More codestyle

* Fix for JUserHelper::addUserToGroup() when user group title is a number. (#20091)

* Update UserHelper.php

* Update UserHelper.php

* Fix count() in PHP 7.2 (#20044)

* [com_content][Multilanguage] - remove duplicated queries (#19683)

* [com_content][Multilanguage] - remove duplicated queries

* cs

* add $db->qn()

* removed ()

* Make CodeMirror work in repeatable subforms (#12542)

* One function to initialize any and all CodeMirror instances rather than individual functions to initialize one-by-one. Call on page load and also on subform-row-add

* Minor js changes

* Codemirror fullscreen modifier message (do we still need this?)

* Call the popover init function when creating new subform rows. (#20222)

* Call the popover init function when creating new subform rows.

* Update teh popover test

* [a11y] post-installation message in control panel (#20220)

> Headings communicate the organization of the content on the page. Web browsers, plug-ins, and assistive technologies can use them to provide in-page navigation.

> Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a < h2> is not followed directly by an < h4>, for example.

Source (https://www.w3.org/WAI/tutorials/page-structure/headings/)

The heading was probably chosen for cosmetic reasons and not structural reasons which they should have been

This PR changes the heading for the post-installtion message i the control panel from h4 to h3

There is a very small visual change as a result but imho the benefits outweigh the small cost

* Solves issue #20195 (#20214)

* [plugin][search][content] give priority on result when title is matched (#20197)

* [plugin][search][content] give priority on result when title is matched

* Missed comma

* Add relevance weighting according to number of words

* Relevance by number of words in title only, removed introtext relevance

* Fix order string concatenation

* You've Got Mail (#20162)

* You've Got Mail

Since 2003 the internet has changed. We no longer get a message to say that we have a message. Instead we just give you the message. You probably never use the messages component (especially for private message to a specific user) as they are the equivalent of https://www.youtube.com/watch?v=gFBLiHpkcOk

The Joomla com_messages component is used in two instances

1. Notification of a new article
2. Sending a message to another user

### Current email for Notification of a new article
Subject: A new private message has arrived from [sitename]
Body:
> Please log in to [link] to read your message.

### New email for Notification of a new article
Subject: New message from [user] at [sitename]
Body:
> New Article
A new Article has been submitted by 'user' entitled 'blog post'.
> Please log in to [link] to read your message.

### Current email when sending a message to another user
Subject: A new private message has arrived from [sitename]
Body:
> Please log in to [link] to read your message.

### New email when sending a message to another user
Subject: New message from [user] at [sitename]
Body:
> [subject]
 [message]
[login link]

## Backwards Compatibility
No issues. The message contains the old login message PLUS the content of the message. So if you were using this message in a custom workflow there is no change required to that workflow

* subj

* cs

* add new string and mark existing string for deprecation

* Support Codemirror's included key mappings (#19833)

* Support Codemirror's included key mappings

* Use a list instead of radio buttons

* Don't expose LDAP authentication usage. (#18531)

* Don't expose LDAP authentication usage.

* Use new language strings for LDAP authentication.

* remove bind string

* remove bind string

* use connect string

* alpha order

* alpha order

* Handle the case that JFolder::files returns 'false' (#11715)

* Initialize tooltips when a new a row is added in a subform (#12996)

* Initialize tooltips when a new a row is added in a subform

* Fix a test since the init function has changed

* Replace htaccess which was removed inexplicably

* Missing space (#20260)

* Tiny JLanguage::loadLanguage() code improvement (#20257)

* [com_content] Remove redundant check (#20254)

* Update articles.php (#20245)

* [com_config] Capitalize label (#20299)

* Implement Issue Templates as discussen in #20298

#20298

* [fix] openbase_dir processing (#20280)

* CodeMirror updated to version 5.37.0 (#20269)

* Use title from menu item (#20267)

* Change the defaults for new installs to disable com_mailto in articles (#20266)

* change the defaults for new installs to disable com_mailto in articles

* change more defaults to 0 thanks @Quy

* Don't enable sending the PW on new installs (#20247)

* disable plaun pw sending per default on new installs

* make sure we have to set a PW when we dont send the plain pw via mail

* chagne the default in the xml to thanks @Quy

* update the sample data thanks @Quy

* make sure the mail to user does not include the PW too

* Revert "make sure the mail to user does not include the PW too"

This reverts commit 9095819.

* address comments by @Bakual thanks

* Optimization and fix of multilingual associations and add layouts to com_content links (#20229)

* Revert #19681

* Revert #19683

* Remove addition query and check after #19314

* Add layout to com_content links

* Add layout to com_content article associations

* Add layout to category associations

* add advanced where clause param

* add advanced where clause for com_content article associations

* drone code formatting fix

* drone code formatting fix

* drone code formatting fix

* Line exceeds 150 characters

* PHPCS rules

* Remove parenthesis

* Change queryKey

* Fix typo

* Improve description

* Add checksum generation to the build script

* Replace "label" classes with the new "badge" ones

* Replace "label" classes with the new "badge" ones

* Siwtch back comment about labels

* Revert "Merge branch 'staging' into 4.0-dev"

This reverts commit 831e986, reversing
changes made to b8c7f7f.

* Replace label classes on js files

* Replace missing label classes

* Use the "danger" to replace "important" in badges

* Use the "danger" to replace "important" in badges

* Replace label classes on a language file

bosunski pushed a commit to bosunski/joomla-cms that referenced this pull request Jun 19, 2018

joomlabeat added a commit to joomlabeat/joomla-cms that referenced this pull request Aug 2, 2018

update fork (#1)
* [com_ajax] Change modules check (joomla#19818)

* Add com_ajax check in getModuleList query

* Restore getModuleList query

* Change module check inside com_ajax

* Categories: Allow sorting by Associations (joomla#19821)

* Categories: Allow sorting by Associations

* moving assoc sorting after access

* Article and contact modal should not use addslashes (joomla#19826)

* Menu tems select field: no need to escape string value (joomla#19828)

* Allow limiting calendar field to current year (joomla#19846)

* Allow locking to min and / or max year to current year

* Update calendar.php

* Cleared non-set variable notices

* Update JHtml::calendar to support relative years limits (joomla#19847)

* Simplify switch statement (joomla#19849)

* [CS] Code style Fix some inline doc blocks for IDE hinting - round 1 (joomla#19862)

* Fix Operator Spacing

* Fix inline doc blocks for IDE hinting

* Fix some docblocks and comments (joomla#19863)

* Custom admin menus: Translating menu items titles (joomla#19900)

* adapt default values (joomla#19924)

* Use getter method (joomla#19925)

* Custom Admin menu item edit: Display Title, Parent Item and Ordering translations (joomla#19916)

* Admin menu item edit: Display Title, Parent Item and Ordering
translations

* Modifs suggested by izharaazmi

* cs

* display translated title only when item exists

* Correcting label alignment

* Cosmetic changes

* In theory, you may not always be working with the default database. So use the correct one. (joomla#19474)

* [plugin][content] - loadmodule by id (joomla#19362)

* [plugin][content] - loadmodule by id

* [plugin][content] - loadmodule by id

* getModuleById

* getModuleById

* id not found

* id not found

* simple syntax

* js side

* modal

* minify js

* regex only digits

* remove title

* use static load()

* regex

* cs

* return

* cs tabs removed

* simplify code

* clean code

* no style

* replace loadmodule with loadmoduleid

* cs

* replace loadmodule with loadmoduleid

* replace

* missed echo

* moved back

* Update loadmodule.php

fixed cs

* Revert "[plugin][content] - loadmodule by id (joomla#19362)" (joomla#19931)

This reverts commit 4172f79.

* Category Modal - add notes (joomla#19131)

* Category Modal - add notes

If you add a note to a category then it is displayed in the category list but not displayed in the category modal (eg when you select a category for a blog menu item)

This PR adds the note, alias, and full path (on hover) to the modal to make it consistent with the list view

* space

* Please consider a blank line preceding your comment (joomla#19936)

* Fix typo in editor field (joomla#19938)

* [CS] long form function return types; round 1 (joomla#19934)

* PHPCS2 - fixes

* 2 spaces after

* Expected 2 spaces after the longest param type

* [libraries][legacy][request] - fix php 7.1 warning not numeric (joomla#19710)

* [libraries][legacy][request] - fix php 7.1 warning not numeric

* dry

* [com_fields] Normalise the request com_fields data (joomla#19884)

* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (joomla#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (joomla#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (joomla#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (joomla#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

* [event dispatcher]  - use strict comparison (joomla#19907)

* [com_users] Fix display of custom field of value 0 (joomla#19933)

* [CS] long form function return types; round 2 (joomla#19935)

* PHPCS2 Auto Fixes

- Expected "boolean" but found "bool" for function return type
- Expected "integer" but found "int" for function return type

* Manual correction of docBlock spacing

* Manual correction of docBlock spacing

* Manual correction of docBlock spacing

* Manual correction of docBlock spacing

* Add some Member var comments

* Manual correction of docBlock spacing

* Add some Member Var comments

* return tag after access tag

* 3 spaces after var tag before the type

* add tag since 3.1 to Class Properties and align var tags

* add tag since 3.1 and align var tag

* adjust some tag alignments

* Two spaces after type

* integer not int

* Redirects Plugin - Make Relative or Absolute. (joomla#19942)

* Redirects Plugin - Make Relative or Absolute.

* Orderiing and capital I.

* Update en-GB.plg_system_redirect.ini

* Update en-GB.plg_system_redirect.ini

updated as per @quys comment.

* Update en-GB.plg_system_redirect.ini

* Make calendar output usable in other css-frameworks (joomla#19944)

* Revert changes expect css

* Make calendar output usable in other css-frameworks

* A min-width makes look better

* Fix for duplicate url check bug introduced by joomla#19734 and support utf8… (joomla#19950)

* Fix for duplicate url check bug introduced by joomla#19734 and support utf8 on old_urls.
Couldn't find a solution to handle this within mysql. So a simple foreach handles it perfectly.

* Update link.php

* solved issue number joomla#19930 (joomla#19969)

corrected typo to ensure proper checkbox functionality

* Removed text-output and enabled a disabled tick box for consistency (joomla#19974)

* Change to allow str_pos to match when the exclude term is at the root… (joomla#19979)

* Change to allow str_pos to match when the exclude term is at the root of the path

* updated redirect.php - clearly I was tired with the first pr.

* Fix for joomla#11070 (tag-category) - Improve also views newsfeed-category … (joomla#16627)

* Fix for joomla#11070 (tag-category) - Improve also views newsfeed-category and category-list

* Correctly modifying .LESS and regenerate .CSS (joomla#16627)

* Simple enhancement to allow the user to make all Post Install Messages read (joomla#19958)

* Simple enhancement to allow the user to make all Post Install Messages as read.

* Update message.php

* Update messages.php

* Update messages.php

* Added onDisplay function for handling the display of the button.

* removed blank lines.

* updated quotes around ints.

As per @alikon comments

* Added (int) just to be safe.

* Update messages.php

* Update messages.php

* Update messages.php

* [com_mailto] Add missing placeholder (joomla#19999)

* Make sure items is an array. (joomla#20000)

* Make sure items is an array.

Resolved joomla#19998

* Update default_items.php

* Update tag.php

* Update tag.php

* Update tag.php

* Update tag.php

* [com_fields] Fix fields display HTML prepared 4 or 5 times per article, make it be prepared only twice (joomla#17895)

* Pass field displayType (aka event type) to getFields

* Update getFields to respect the 'display' parameter of every field

* Update onContentPrepare to respect 'display' parameter of every field

* Prepare for manual display

* Do not create $item->jcfields multiple times

* Revert the code for manual display to always prepare the field value

* Wrong function name

* Fix docblock

* Better comment for parameter of getFields method

* fix media field in ISIS Template (joomla#17205)

* fix media field in ISIS Template

* fix media field in ISIS Template

* [3.x] New sessiongc plugin is not declared as core plugin for manifest cache refresh (joomla#20038)

* add sessiongc plugin to the core plugins

* alphasorting thanks @brianteeman

* [module] [articles category] filter by multiple tags (joomla#19983)

* [module] [articles category] filter by multiple tags

* multiple tags

* spelling

* [com_finder] Remove unused params (joomla#20009)

* [com_finder] Unused params

* Update en-GB.com_finder.ini

* Update sample_learn.sql

* Update sample_testing.sql

* Update sample_learn.sql

* Update sample_testing.sql

* Update sample_learn.sql

* Update sample_testing.sql

* Update jos_menu.csv

* Restore and deprecate strings

* Two new fonts for CodeMirror: IBM Plex Mono, Nanum Gothic Coding (joomla#20017)

* CategoryEdit field published filter (joomla#20018)

* Smart Search: Highlighting terms also in fulltext when using readmore (joomla#20019)

* Smart Search: Highlighting terms also in fulltext when using readmore

* parsing summary + body to get text only

* Escape full query in NestedTable debug mode (joomla#20024)

* Changed viewname filter in RouteHelper (joomla#20031)

* Fix GMail plugin so it doesn't crash and burn on 4.0 upgrades (joomla#20043)

* Tweak build script for added flexibility (joomla#19848)

* Refresh Manifest Cache failed: Extension is not currently installed (joomla#19560)

* Refresh Manifest Cache failed: Extension is not currently installed

PR for joomla#17604

Change the message to include the name of the extension.

I have no idea how to test this - sorry - only code review - unless someone knows how?

* partial revert

* revert comment

* Remove rtrim() since it allows invalid emails (joomla#20080)

* Custom Fields toggle display on read only rights (joomla#20068)

* [com_fields] Normalise the request com_fields data (joomla#19884)

* Normalise the request com_fields data

* CS

* PHP 5.3 compat

* Fields in com_fields array (joomla#9)

Fields should be set in com_fields array and not direcly in $data

* Spelling

* Also normalise request data on front-end user profile save (joomla#10)

* Also normalise request data on front-end user profile save

* correct context and option

* Handle 0 properly in empty check

* Simplify

* allowing value 0 to be saved (joomla#11)

when setting a value of 0 in a text field the function empty will return true > setting the value to null

* correct needsUpdate when strlen (or count) = 1 which incorrectly equa… (joomla#12)

* correct needsUpdate when strlen (or count) = 1 which incorrectly equaled to 'true'

* Update field.php

* Update field.php

* Custom fields view on form via toggle on read-only rights

* fix back-end new article

* first / seperate check on read-only access

* refactor code so show_on parameter is part of helper function

* implement inherit value in fields + language things

* loadmodel only when needed

* changed function comment

* change values order so default value (inherit) is displayed first

* Must use self:: for local static member reference

* Fixed page with multiple codemirror editors fields with different syntax highlighting (joomla#20063)

* Fix for: Can't choose module using editor plugin if you search first (joomla#20005)

* fixit

* cs

* Update modal.php

* Basic check to make sure the bulk import seperator is being used. (joomla#19982)

* Basic check to make sure the bulk import seperator is being used.
Added Import State function as to how the urls should be imported, enabled or disabled.

* force int.

* Update config.xml

* Update links.php

* Update en-GB.com_redirect.ini

* Update config.xml

* Update links.php

* Update en-GB.com_redirect.ini

* Update config.xml

As per standards i.e:
https://github.com/joomla/joomla-cms/blob/staging/administrator/components/com_config/model/form/application.xml

i.e. endtag inline with options and closing tag inline with opening tag.

* Update links.php

* Changed none selected to none, to be used when there are none availab… (joomla#19977)

* Changed none selected to none, to be used when there are none available to select and when none are selected.
Set select to be readonly is they cannot select any options

* Update plugins.php

* Update plugins.php

* Update en-GB.ini

* Update en-GB.ini

* Update plugins.php

* Update plugins.php

* Update plugins.php

* Update plugins.php

* Update plugins.php

Space/tabbing for drone.

* Update plugins.php

* Corrected bug on empty subject of com_mailto (joomla#19956)

* Corrected bug on empty subject

If the subject is empty, the posted value is an empty string (exists) so the default value is never added.

* Updated code to include null value

* text corrections (joomla#20111)

* Typo and copy paste error (joomla#20123)

Someone couldn't spell and then someone else must have copy pasted the error

No idea how to test but this has been wrong since 3.5

* correct the use of the use command and move it below the defined command (joomla#20130)

* Prepare 3.8.7 RC

* Reset for dev

* Add a security policy (joomla#20163)

* Add a security policy

Many projects now add a SECURITY.md document to their repository. Often this is related to using HackerOne but not always.

This PR adds a policy to our github repo. It is based on the existing policy on the d.j.o web site

The file doesn't need to be distributed so it has been added to the exclude list in the github repo.

* tweek

* copy paste

* Update SECURITY.md

* Update SECURITY.md

* Prepare 3.8.7 release

* Reset for dev

* Introduce CODEOWNERS (joomla#20137)

* Tidy writeDynaList() (joomla#12184)

* Cleaned writeDynaList() in core.js

* Removed explanation comments

* removed all API changes

* updated compressed core.js

* [fix] publish/unpublish does not work with tables using null as default checked_out value (joomla#20204)

* Fix overwrite by .table-striped (joomla#20180)

Fix overwrite by administrator/templates/isis/css/template.css line 1787

table.table-striped tbody > tr:nth-child(odd) > td,
table.table-striped tbody > tr:nth-child(odd) > th {
	background-color: #f9f9f9;
}

* Fix overwrite by .table-striped (joomla#20179)

Fix overwrite by administrator/templates/isis/css/template.css line 1787

table.table-striped tbody > tr:nth-child(odd) > td,
table.table-striped tbody > tr:nth-child(odd) > th {
	background-color: #f9f9f9;
}

* Tooltips not loading com_users (joomla#20177)

The edit profile form is not loading the bootstrap tooltip code. So any tooltip (not popovers) are displayed as html as seen in the screenshot below when TFA is enabled.

This was spotted by @o2tsen and @sandewt while testing joomla#20051 but as it is a bug effecting more than that PR I have created a new PR. (a pr should only fix one problem)

* [a11y] Headings consecutive order Debug Console (joomla#20167)

> Headings communicate the organization of the content on the page. Web browsers, plug-ins, and assistive technologies can use them to provide in-page navigation.

> Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a < h2> is not followed directly by an < h4>, for example.

Source (https://www.w3.org/WAI/tutorials/page-structure/headings/)

The headings were probably chosen for cosmetic reasons and not structural reasons which they should have been

This PR changes the heading in the debug console from h1 to h2

There is a very small visual change as a result but imho the benefits outweigh the small cost

* [a11y] Headings consecutive order (joomla#20166)

* [WIP] [a11y] Headings consecutive order

> Headings communicate the organization of the content on the page. Web browsers, plug-ins, and assistive technologies can use them to provide in-page navigation.

> Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a <h2> is not followed directly by an <h4>, for example.

Source (https://www.w3.org/WAI/tutorials/page-structure/headings/)

This PR changes the heading in the plugin and modules from h3 to h2 and in the template styles to h4

### todo
joomla.edit.item_title layout uses h4 but before I change it I need to check everywhere that it is being used

* layout

* Fix typos in InstallerControllerUpdate (joomla#20154)

* Fix typos in InstallerControllerUpdate

* Fix same error on other places. Thanks @Quy

* Remove similar unnecessary code

* Revert "Remove similar unnecessary code"

This reverts commit 56410c0.

* One more

* Revert "One more"

This reverts commit aa1b101.

* [com_contact] Don't hide contact filter form (joomla#20126)

* Update default_items.php

* Correct implode order.

* Codestyle

* More codestyle

* Fix for JUserHelper::addUserToGroup() when user group title is a number. (joomla#20091)

* Update UserHelper.php

* Update UserHelper.php

* Fix count() in PHP 7.2 (joomla#20044)

* [com_content][Multilanguage] - remove duplicated queries (joomla#19683)

* [com_content][Multilanguage] - remove duplicated queries

* cs

* add $db->qn()

* removed ()

* Make CodeMirror work in repeatable subforms (joomla#12542)

* One function to initialize any and all CodeMirror instances rather than individual functions to initialize one-by-one. Call on page load and also on subform-row-add

* Minor js changes

* Codemirror fullscreen modifier message (do we still need this?)

* Call the popover init function when creating new subform rows. (joomla#20222)

* Call the popover init function when creating new subform rows.

* Update teh popover test

* [a11y] post-installation message in control panel (joomla#20220)

> Headings communicate the organization of the content on the page. Web browsers, plug-ins, and assistive technologies can use them to provide in-page navigation.

> Skipping heading ranks can be confusing and should be avoided where possible: Make sure that a < h2> is not followed directly by an < h4>, for example.

Source (https://www.w3.org/WAI/tutorials/page-structure/headings/)

The heading was probably chosen for cosmetic reasons and not structural reasons which they should have been

This PR changes the heading for the post-installtion message i the control panel from h4 to h3

There is a very small visual change as a result but imho the benefits outweigh the small cost

* Solves issue joomla#20195 (joomla#20214)

* [plugin][search][content] give priority on result when title is matched (joomla#20197)

* [plugin][search][content] give priority on result when title is matched

* Missed comma

* Add relevance weighting according to number of words

* Relevance by number of words in title only, removed introtext relevance

* Fix order string concatenation

* You've Got Mail (joomla#20162)

* You've Got Mail

Since 2003 the internet has changed. We no longer get a message to say that we have a message. Instead we just give you the message. You probably never use the messages component (especially for private message to a specific user) as they are the equivalent of https://www.youtube.com/watch?v=gFBLiHpkcOk

The Joomla com_messages component is used in two instances

1. Notification of a new article
2. Sending a message to another user

### Current email for Notification of a new article
Subject: A new private message has arrived from [sitename]
Body:
> Please log in to [link] to read your message.

### New email for Notification of a new article
Subject: New message from [user] at [sitename]
Body:
> New Article
A new Article has been submitted by 'user' entitled 'blog post'.
> Please log in to [link] to read your message.

### Current email when sending a message to another user
Subject: A new private message has arrived from [sitename]
Body:
> Please log in to [link] to read your message.

### New email when sending a message to another user
Subject: New message from [user] at [sitename]
Body:
> [subject]
 [message]
[login link]

## Backwards Compatibility
No issues. The message contains the old login message PLUS the content of the message. So if you were using this message in a custom workflow there is no change required to that workflow

* subj

* cs

* add new string and mark existing string for deprecation

* Support Codemirror's included key mappings (joomla#19833)

* Support Codemirror's included key mappings

* Use a list instead of radio buttons

* Don't expose LDAP authentication usage. (joomla#18531)

* Don't expose LDAP authentication usage.

* Use new language strings for LDAP authentication.

* remove bind string

* remove bind string

* use connect string

* alpha order

* alpha order

* Handle the case that JFolder::files returns 'false' (joomla#11715)

* Initialize tooltips when a new a row is added in a subform (joomla#12996)

* Initialize tooltips when a new a row is added in a subform

* Fix a test since the init function has changed

* Replace htaccess which was removed inexplicably

* Missing space (joomla#20260)

* Tiny JLanguage::loadLanguage() code improvement (joomla#20257)

* [com_content] Remove redundant check (joomla#20254)

* Update articles.php (joomla#20245)

* [com_config] Capitalize label (joomla#20299)

* Implement Issue Templates as discussen in joomla#20298

joomla#20298

* [fix] openbase_dir processing (joomla#20280)

* CodeMirror updated to version 5.37.0 (joomla#20269)

* Use title from menu item (joomla#20267)

* Change the defaults for new installs to disable com_mailto in articles (joomla#20266)

* change the defaults for new installs to disable com_mailto in articles

* change more defaults to 0 thanks @Quy

* Don't enable sending the PW on new installs (joomla#20247)

* disable plaun pw sending per default on new installs

* make sure we have to set a PW when we dont send the plain pw via mail

* chagne the default in the xml to thanks @Quy

* update the sample data thanks @Quy

* make sure the mail to user does not include the PW too

* Revert "make sure the mail to user does not include the PW too"

This reverts commit 9095819.

* address comments by @Bakual thanks

* Optimization and fix of multilingual associations and add layouts to com_content links (joomla#20229)

* Revert joomla#19681

* Revert joomla#19683

* Remove addition query and check after joomla#19314

* Add layout to com_content links

* Add layout to com_content article associations

* Add layout to category associations

* add advanced where clause param

* add advanced where clause for com_content article associations

* drone code formatting fix

* drone code formatting fix

* drone code formatting fix

* Line exceeds 150 characters

* PHPCS rules

* Remove parenthesis

* Change queryKey

* Fix typo

* Improve description

* Add checksum generation to the build script

* Hide Enabled/Disabled users column headers and be a11y compliant (joomla#20279)

* Code mirror autofocus issue (joomla#20270)

* Pass the autofocus param to the plugin.

While we're at it, pretty up this function a little.

* Get autofocus from $params, not $this->params.

Also, make sure we only autofocus one CodeMirror per page.

* We won't be needing these things anymore.

* Keep the unused strings.

* Add a deprecated flag in database query for a few union/unionAll/unionDistinct (joomla#20219)

* Add showon attribute (joomla#20156)

* [com_contact] Display 0 value with custom field (joomla#20124)

* Display 0 value

* Display 0 value

* fix custom fields with tab format (joomla#20023)

* Show a sample editor on the CodeMirror plugin config page. (joomla#17042)

* Show a sample editor on the CodeMirror plugin config page.

* Call it a 'Preview'

* Reordered attributes as per the Joomla coding standards for xml

* hiddenFieldsets & configFieldsets needs to be defined (joomla#16856)

* hiddenFieldsets & configFieldsets needs to be defined

* use getter

* Fix subform repeat counter. (joomla#19693)

* Fix subform repeat counter.

As normal rows should be zero indexed.

When length === count === 0, first row should be 0.

Note: PHP creates existing rows with zero index - so if min=1, you
currently get row 0 on form load then row 2, 3 etc. as you add them.

* Update unit tests

* Additional test fixes.

* Fix typo in comment.

* Reminify subform-repeatable.js

* Fixing so that editors-xtd plugins works with com_ajax (joomla#17939)

* Fixing so that editors-xtd plugins works with com_ajax

* Code formatting fix

* [Plugins] Add filters to manifest files. (joomla#20410)

* URL Menu Item Type link should be required. (joomla#20392)

* Fix up the protostar template.js (joomla#20224)

Don't use unnecessary closure, just use jQuery ready function.
Use javsacript strict mode
use event delegation where possible
Make tooltips and button groups work properly with repeatable subforms

* Bootstrap alert compatible (joomla#18909)

* Bootstrap alert compatible

Alert compatibility with new Bootstrap versions.

* Strict comparison

* Bootstrap alert compatible minified file

Alert compatibility with new Bootstrap versions.

* Add PHP 7.3 polyfill (joomla#20441)

* [com_finder] Fix regression joomla#19969 (joomla#20411)

* [com_finder] - fix update inner join syntax for postgres (joomla#19964)

* [com_finder] - fix update inner join syntax for postgres

* drone fix

cs

* quoteName vs qn

* cs

* Update tag.php (joomla#19951)

There is a bug in getItem, the function parameter is called $pk, but in code it is using $id, so whenever the parameter  is passed it is not used in the function.

* Change the Administrator group's filtering to use the default blacklist

* Add postinstall message explaining revised default settings

* Prepare 3.8.8 Release Candidate

* Reset for dev

* Typo in nl-NL installation language file (joomla#20460)

* Update joomla/filter package

* Update joomla/application package

* Store plaintext passwords in a separate options key, do not display passwords on summary page

* Prepare 3.8.8 release

* When JFeed was moved, old files were never deleted

* Reset for dev

* Correctly escape the random image module output (joomla#20533)

* Finally com_mailto allow the usage of a captcha by using JForm (joomla#20265)

* finaly com_mailto allow the usage of a captach by using JForm

* remove unused $session variable

* Line ending to LF

* fix typo thanks @brianteeman

* no need to use set and get thanks @mbabker

* expend the popup & fix the auto population thanks @Quy

* captcha handling

* fix the captcha check

* commit header check thanks for reporting @brianteeman @mbabaker and for the improved code @Quy

* style changes affected hight thanks @brianteeman

* line ending again

* close <fieldset> thanks @Quy

* make the iframe a bit bigger  thnks @Quy

* commit proposed changes by @Quy

* implement suggested improvments

* use <?php echo $field->renderField(); ?> thanks @laoneo

* Remove check for a valid form from two places in plugins (joomla#20277)

* If that is not a valid form our system is broken at all

* Typehint the form argument

* Fallback to integer (joomla#20338)

* [plg_user_profile] Misc fixes (joomla#20412)

* Update profile.xml

* Update profile.xml

* Update profile.php

* Update tos.php

* [plg_fields] Manifest cleanup, filters, Editor plugin fix (joomla#20422)

* Update calendar.xml

* Update checkboxes.xml

* Update checkboxes.xml

* Update editor.xml

* Update editor.xml

* Update editor.php

* Update imagelist.xml

* Update imagelist.xml

* Update integer.xml

* Update integer.xml

* Update list.xml

* Update list.xml

* Update media.xml

* Update radio.xml

* Update radio.xml

* Update checkboxes.xml

* Update list.xml

* Update sql.xml

* Update sql.xml

* Update textarea.xml

* Update textarea.xml

* Update url.xml

* Update url.xml

* Update usergrouplist.xml

* Update usergrouplist.xml

* Restore empty value

* [plg_system] Manifest file filters (joomla#20456)

* [CS] fix some doc comment types (joomla#20522)

* PHPCS2 manual fixes

- Variables passed by reference should not have the `&` prefixed in the doc comment
  - Joomla.Commenting.FunctionComment.MissingParamTag
  - Joomla.Commenting.FunctionComment.ParamNameNoMatch
- correct return statement

* exclude administrator/components/ folder

"Having a "&" in the docblock (whether it's in front of the type or name) is not valid. References are to be expressed solely by the function/method declaration."

so we need to exclude this sniff while we trasition to the PHPCS 2.x version

* [styles] Fix checkboxes/buttons not clickable under Menu Assignment in Chrome (joomla#20542)

* Remove css

* Remove css

* Remove css rtl

* cs

* [Regression] Menu item type url with rel attribute nofollow (joomla#19949)

* Menu item url attribute rel nofollow with target blank

* logic

* cs

* cs fix - thx Quy

* concat

* To many elements to index (joomla#13868)

* To many elements to index

I don't know why in the query `#__tags` is twice. Once as a `a` and second time as a `b`. For me it works perfectly when we remove `b`. I had a problem with this - for 1100 tags on my websites, Smart Search Indexer found more than 1233000 items to index.

* Mistake with query

I corrected a bug with calling the `#__tags` table in the query.

* Update joomla/filter package (joomla#20579 and joomla#20580)

* Fix folder browsing and file upload that broke in 3.8.8 due to escaping (joomla#20586)

* Fix de-escaping of slash in folder name

* code style

* Update popup-imagemanager.js

* standardise contact strings (joomla#20577)

as spotted by @MartijnMaandag

* Enable to change FormData in com_menu (joomla#20313)

* Set as object to allow for alterations

* Cast to object directly

* fix typo in installation string (joomla#20607)

It is IN each catefgory not ON each category

INSTL_DEFAULTLANGUAGE_INSTALL_LOCALISED_CONTENT_DESC="If active, Joomla will automatically create one content category per each installed language. Also, one featured article with dummy content will be created in each category."

* Resync deleted files list back to 1.7.3 tag (joomla#20564)

* Add additional check that view exists before proceeding (joomla#18757)

* Add additional check that view exists before proceeding

We assume the array key exists with view but not ID. I have come across some installations where view does not exist and it causes php warnings. So just check it does exist before actually proceeding further as we do with ID.

* Update legacyrouter.php

* Update legacyrouter.php

* Default installation value in configuration.php-dist (joomla#20655)

* Default installation value in configuration.php-dist

The config file to use in manual installs has incorrect advice and paths for tmp and logs as they are referring to server paths and not paths within a joomla installation

* oops

* CodeMirror updated to 5.38.0 (joomla#20636)

* Bump Composer dependencies (joomla#20583)

* Bump Composer dependencies

* Bad user data

* Try changing test to fix PHP 5.3 behavior

* Another attempt at fixing this

* Try upstream changes without tag yet

* Back to empty array

* Now with release tag

* Update app package with UA fix

* [fix] Error decoding JSON data: Syntax error (joomla#20663)

* [fix] Error decoding JSON data: Syntax error

* [test] ensure that empty params do not cause user loading issues

* Don't try to json_decode() a null value (joomla#20675)

* Don't try to json_decode() a null value

* Add Registry package fix to make sure broken code can continue to work

* Joomla\CMS\Categories\Categories fix (joomla#20680)

A constructor can't return a value.

* [CS] fix some doc comment types (round 2) (joomla#20647)

* PHPCS2 manual changes

- Doc comment for parameter does not match actual variable name
- Comment closer must be on a new line (just convert to single line comment)
- be more specific with the rules we want to exclude

* fix spaces

Expected only 2 spaces after the longest variable name

* one more fix for doc comment

- Doc comment for parameter does not match actual variable name

* [Newsfeeds] Use item link instead of guid. (joomla#20717)

* Feed links

* Restore http check for now

* CS

* Some cleanups

* Verb wrong tense (joomla#20708)

* Verb wrong tense

Clearly using the present tense is incorrect for an error message and it should be the past tense

* no error

* Replace UCMType::getType() by UCMType::getTypeByAlias($this->alias) (joomla#20672)

* JTableAsset::loadByName(): replace two sql queries by one (joomla#20671)

* Display 404 page if banner not found (joomla#20664)

* Update strings (joomla#20591)

* Fix stale session data wrongly overriding configuration file when editing global configuration (joomla#20590)

* Fix stale session data wrongly overriding configuration file when editing global configuration

* Use $this variable

* [com_menus] - fix php warning (joomla#18471)

* Singular not plural (joomla#20751)

* Singular not plural

Obvious correction. sorry I dont know what I did to display the error.

* Update en-GB.mod_sampledata.ini

* [com_tags] Image caption in Tags view (joomla#20648)

* Put all build packages in one directory (joomla#20745)

* [com_tags] Tagged item link in feed (joomla#20723)

* [com_tags] Tagged item feed links

* Nesting error

* [mod_tags_similar] Link cleanup (joomla#20730)

* [mod_tags_similar] Link cleanup

* CS

* Com_finder meta data (joomla#20772)

* Com_finder meta data

com_finder aka smart search was not following any meta data set in the menu item

#### to test

 - setup and configure smart search
 - create a menu item for smart search and set the meta description and meta keywords
 - open the menu item on the front end - check source and the meta data set in the menu is not present
 - do a search
 - check source and the meta data has been generated from the search

Apply this PR
 - open the menu item on the front end - check source and the meta data set in the menu is present
 - do a search
 - check source and the meta data has been generated from the search

* remove copy paste error

* Add UTF-8 encoding to phpcs in .drone.yml (joomla#20769)

* Login to view the article redirect fix (joomla#20732)

Without the view=login parameter JRoute can not resolve the Itemid. 
So the menu item assigned to 'login' is not active.

Seems there is a related hack here:
/com_content/views/article/tmpl/default.php ~line 143

This can also cause problems with third party extensions like sh404sef.

* Mouse over edit - rename (joomla#20743)

At the time this feature was introduced we weren't happy with the name "Mouse over edit" but couldn't really think of anything else.

I believe that today the term "inline editing" is far more understood and is a more appropriate name

* Better mode autoloading. (joomla#20746)

* Respect access of editor plugin inside profile form (joomla#20713)

* Respect access of editor plugin inside profile form

* Use value string 'true', '*' instead of integer for useaccess parameter

* Additional Escaping Of Paths In com_media (joomla#20616)

* Additional Escaping Of Paths In com_media

* Additional Override Escaping

* carefully revert some escaping (security)

* more specific and special reverse encoding of slash

* C&P Error

* [com_tags] Images in Tagged Items view (joomla#20601)

* [com_contenthistory] - fix for not delete keep forever items (joomla#20430)

* [com_contenthistory] - fix for not delete kepp forever items

* don't stop delete

* cs

* cs removed spaces at end of line

* Fixing com_fields integration in com_contact (joomla#20413)

* Fixing com_fields integration

Custom fields in com_contact currently doesnt work propertly. Chosing a category on which they should appear doesn't work cause fields plugin has no informations about contact catid as not data is passed to form when contact form is displayed. This fixes it.

* Fixing code style

* Removing whitespace, fixing spelling

* enable mod_sampledata extension

* [ModuleHelper] owncache param as integer (joomla#20626)

* Changed return 0 to continue

To prevent the entire function to quit, it just needs to go to the next file.
Fix joomla#17954

* [mod_articles_category] Fatal error (joomla#20834)

* Prepare 3.8.9 Release Candidate

* Reset for dev

* Very small language file cs (joomla#20844)

* Whitelist allowed global access

* Bump joomla/input package

* Use new method for dynamically resolving Input based on request method

* Prepare 3.8.9 release

* Reset for development

* Fix the autoloader for Windows platforms (joomla#20877)

* Prepare 3.8.10 release

* Reset for dev, again

* Don't delete file that is still in use (Fix joomla#20881)

* [plg_user_profile] Add RTL check to ToS field

* FIX: Install Languages Manager language badges wrongly set to not match since upgrade to 3.8.10 (joomla#20906)

* FIX: Install Languages Manager language badges wrongly set to not match
since upgrade to 3.8.10

* Correcting Installed languages too

* Replace the URL parameter "limitstart=0" with "start=0" if the SEF mode is on (joomla#19452)

* Replace &limitstart=0 to &start=0 if SEF is ON

* Replace URL param start=x to limitstart=x even if start is 0

* Remove non callable array items from field categories (joomla#20093)

* Update default.php

* Update fields.php

* Update default.php

* Update fields.php

* Update fields.php

* Update fields.php

* [Site Modules] Manifest file filters, part 1 (joomla#20845)

* [Modules] Manifest file filters

* Chosen placeholders

* [cs] leading spaces (joomla#20858)

* [cs]leading spaces

While checking joomla#20844 I saw that these strings all have a leading space which should not be there

* oops

* [Site Modules] Manifest file filters, part 2 (joomla#20856)

* [Site Modules] Manifest file filters, part 2

* Update default.php

* Update default.php

* Update default.php

* [Site Modules] Manifest file filters, part 3 (joomla#20857)

* [Admin Modules] Manifest file filters (joomla#20868)

* [Admin Modules] Manifest file filters

* Default values

* Fix OpenSearch implementation

* [mod_articles_category] Showon

* Add showon to levels

* Update string

* Remove CSS

* Add security issue template

* Formatting

* Let the table check the data before storing.

* [Templates] Escape sitename (joomla#21008)

* Checking return value and catching whole stuff

* Updating Bosnian installation language files

* Updated 3.9-dev and added 3.10-dev (joomla#21097)

* Exceptions in Joomla\CMS\Table\Usergroup refer to categories (joomla#21098)

* Exceptions in Joomla\CMS\Table\Usergroup refer to categories

Pull Request for Issue joomla#21092 .

### Summary of Changes
remove todo that is clearly a copy paste error from somewhere else
change exception message to usergroups from catergory

NOTE the first exception` if ($this->id == 0)`
I am not sure if that should even be present - doesn't look like it to me - please advise

* Update Usergroup.php

* Deprecate sef_advanced strings (joomla#21116)

* [com_content] Featured articles tag filtering (joomla#21138)

* Update ModuleHelper.php (joomla#20273)

* The JPATH_ constants are not magic strings (joomla#21151)

* Remove if/else in user debug models that can never hit else conditions (joomla#21188)

* [com_content] Featured articles access filter (joomla#21168)

* Media manager doesn't obey relative pathes for video files (joomla#21156)

* correct video url

fixes joomla#21145 (comment)

* fix

* Speed up regex in emailcloak plugin (joomla#20956)

* Speed up regex in emailcloak plugin

* Fix comment

* Fix subform.repeatable-table multi field styling (joomla#20209)

* Fix subform.repeatable-table multi field styling

* Fix staging less/css

* revert previous

* Update FormField.php (joomla#20168)

* Update HTMLHelper.php (joomla#19770)

* Fix a problem with older Joomla versions language packs registration and update sites rebuild (joomla#16355)

* Fix a problem with older language packs

Language packs installed under older Joomla versions are registered in the database under their package name, not under their name and since rebuild function fails on them.

e.g. package with 
  <name>Afrikaans (South Africa)</name>
  <packagename>af-ZA</packagename>

has name column in #_extensions table set as 	af-ZA and since existing query fails.

* Update updatesites.php

* missing single quote (joomla#21213)

* Add a note field from the #__fields_groups table to the field list query

* [3.x FIX] Getting the correct associations in sidebyside view for contact and newsfeeds (joomla#21180)

* [3.x FIX] Getting the correct associations in sid