Correct isis message close buttons behaviour #9962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on a86f0a9 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9962. |
1 similar comment
|
I have tested this item ✅ successfully on a86f0a9 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9962. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9962. |
|
Merged - thanks :) |
|
@richard67 @MATsxm thanks for testing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for New Issue.
Summary of Changes
Small PR for solving the following issue.
Isis system message close buttons are wrongly placed with causes when you close a message to closes all the messages.
This PR will make isis system messages working like the other templates.
Before patch
After patch
Testing Instructions
Very easy test. Just use the patchtester without github credentials.
Apply any other patch.
Check the two messages that appear in the patch tester.
You only have one close button that close both messages.
Apply this patch.
Check the two messages that appear in the patch tester.
You should have two close buttons, each close each message.