-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modals] Add tooltip placement bottom (articles and modules) #10076
Conversation
I have tested this item ✅ successfully on 6f49e9c This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10076. |
Yes, but not listed all the places where articles modal is used, as the changes are really minor, and if working in one "redo" bs modal, it should work too in other places (loading the same code! ;-) ) Thank you for testing! 👍 |
Clearly. great job! |
You did a big part of it! Thank you for testing all those PRs! ;-) |
I have tested this item 🔴 unsuccessfully on 6f49e9c Apply PR(10147) (I haven't tested the code below but it may fix the issue) @media {max-width 375px){ This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10076. |
@Twincarb Your unsuccessfull test is not related to this PR, nor the other PR you mentionned. The purpose of this PR is only a tooltip position fix. So, about the current PR, your test is wrong as not related to the issue fixed: tooltip position and padding of content (very minor changes here for the content of the modal, and not the TinyMCE modal. |
@Twincarb Again me! First, could you confirm you test on last staging, and if you have clean your cache on your mobile too ? Could you tell me which mobile OS and browser, and attach a screenshot ? Thank you for your contribution 👍 |
@JoomliC I have also tested it on an ipod touch and have the identical results, the issue itself is with TinyMCE, I have now finished having a good read through the TinyMCE Github Issues page, it appears there is a plan for a seperate lightweight version for mobile support, I guess we will have to live with the non mobile friendly modals we have. I will change my test to positive in light of the above. 😄 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10076. |
I have tested this item ✅ successfully on 6f49e9c PR works as expected. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10076. |
I have tested this item ✅ successfully on 6f49e9c This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10076. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10076. |
Minor redo #10013 .
Missing tooltip placement bottom, when this modal view is loaded in association modal.
Minor changes related only to
modules
andarticles
modalsSummary of Changes
Testing Instructions (Multilanguages is enabled)
Articles modal
Note: Hathor overrides to be updated later in a PR i will do with all the modals updated the last days ;-)