New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update jquery.minicolors.js (color picker) + add rgb(a) & CSS-wide keywords support + fix RTL #10129
Conversation
Update jquery.minicolors.js v.2.2.3 (https://github.com/claviska/jquery-minicolors)
Update jquery.minicolors.js v.2.2.3 (minified) https://github.com/claviska/jquery-minicolors/blob/master/jquery.minicolors.min.js
I have tested this item ✅ successfully on 2211e19 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10129. |
library jquery.minicolors.js latest version 2.2.4 released on 18 Mar. Can you clarify which one is in use here. I have tested with no issues detected and functionality is as described 😄 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10129. |
@Twincarb Yes you're right, i've mentionned 2.2.3, but it's 2.2.4! 👍 (will update description) |
I have tested this item ✅ successfully on 2211e19 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10129. |
@andrepereiradasilva, @Twincarb Thanks for testing! |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10129. |
Just mentioned here PR #10199 concerning version adjusted to 3.6.0 for new attributes. Now, will work on the documentation for JDocs ;-) |
New Pull Request for #7602 and Issue #7401 .
As requested by @wilsonge to contribute these changes back to the library (https://github.com/claviska/jquery-minicolors/), i did it 😄 . The updated library includes other fixes.
A special thanks to @claviska for his suggestions, help and the time he took in make it happen! 👍
All documentation on this color picker library available here: http://labs.abeautifulsite.net/jquery-minicolors/
Summary of Changes
format
andkeywords
hex
(current format),rgb
andrgba
transparent
,initial
,inherit
Documentation
New XML attributes
keywords (optional)
CSS-wide keywords can be assigned by setting the
keywords
attribute to a comma-separated list of valid keywords:transparent
,inherit
,initial
XML:
keywords="transparent,inherit,initial"
Usage: enter the keyword in the field input (script will allow only a keyword listed in the xml attribute)
See screen shot for testing.
format (optional)
For Joomla, i've integrate the rgb(a) format option as a one xml attribute. (no need to set a data-opacity attribute).
Format could be:
hex
(default),rgb
orrgba
(with opacity slider)XML:
format="rgba"
Usage: Will return a validated color hex or rgb(a)
See screen shot for testing.
RTL support
Add RTL support. If position is default, the picker will be on the left if RTL language (currently it's right on LTR).
The input value was converted to RTL before, but with issue in some cases. To prevent this, the input value will always be LTR as it is not to be translated or converted as a CSS code value.
NOTE: When this PR will be merged, i will update JDocs accordingly ;-)
Testing Instructions
Add these fields to the settings part of an xml file of one extension (eg. template Isis). Then go to that extension settings in the admin and test the different color fields.