Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upCreate a Last Visit Date filter on the user list #10137
Conversation
This comment has been minimized.
This comment has been minimized.
Can you change the order please so that last visit is before registration in the list of filters - that way it matches the column order This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
This comment has been minimized.
This comment has been minimized.
@brianteeman Thank you for the suggestion. Will do. |
onchange="this.form.submit();" | ||
> | ||
<option value="">COM_USERS_OPTION_FILTER_LAST_VISIT_DATE</option> | ||
</field> |
This comment has been minimized.
This comment has been minimized.
brianteeman
Apr 30, 2016
Contributor
Can you change the order please so that last visit is before registration in the list of filters - that way it matches the column order
<option value=""><?php echo JText::_('COM_USERS_OPTION_FILTER_LAST_VISIT_DATE');?></option> | ||
<?php echo JHtml::_('select.options', Usershelper::getRangeOptions(), 'value', 'text', $this->state->get('filter.lastvisitrange'));?> | ||
</select> | ||
|
This comment has been minimized.
This comment has been minimized.
brianteeman
Apr 30, 2016
Contributor
Can you change the order please so that last visit is before registration in the list of filters - that way it matches the column order
This comment has been minimized.
This comment has been minimized.
Its something we've been trying to do everywhere to ensure consistency On 30 April 2016 at 10:59, RolandD notifications@github.com wrote:
Brian Teeman |
This comment has been minimized.
This comment has been minimized.
@brianteeman You are absolutely correct, it just never crossed my mind :) Change has been committed. |
This comment has been minimized.
This comment has been minimized.
And in the hathor override please On 30 April 2016 at 11:03, RolandD notifications@github.com wrote:
Brian Teeman |
This comment has been minimized.
This comment has been minimized.
Hathor is there as well now. |
This comment has been minimized.
This comment has been minimized.
I have tested this item This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
This comment has been minimized.
This comment has been minimized.
I have tested this item I suggest to add "Never" as final option in the Select Last Visit Date drop down list. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
This comment has been minimized.
This comment has been minimized.
RTC - new feature so 3.6 milestone This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
This comment has been minimized.
This comment has been minimized.
joomla-cms-bot
commented
May 1, 2016
This PR has received new commits. CC: @brianteeman, @pe7er This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
This comment has been minimized.
This comment has been minimized.
@pe7er Good suggestion to add the never option. This has now been added. |
This comment has been minimized.
This comment has been minimized.
Set back to pending as there have been changes that need new tests This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
This comment has been minimized.
This comment has been minimized.
I have tested this item This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
This comment has been minimized.
This comment has been minimized.
I have tested this item This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
This comment has been minimized.
This comment has been minimized.
Back to RTC ;) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
roland-d commentedApr 30, 2016
•
edited by joomla-cms-bot
Summary of Changes
The user list has a number of filters, one of them is the registration date. However I think that the last visit date is more useful as it can show when a user last came to the site. If that is too long ago the user account may be considered obsolete. So this PR adds a filter for the last visit date.
Testing Instructions