Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a Last Visit Date filter on the user list #10137

Merged
merged 6 commits into from May 2, 2016

Conversation

@roland-d
Copy link
Contributor

roland-d commented Apr 30, 2016

Summary of Changes

The user list has a number of filters, one of them is the registration date. However I think that the last visit date is more useful as it can show when a user last came to the site. If that is too long ago the user account may be considered obsolete. So this PR adds a filter for the last visit date.

Testing Instructions

  1. Go to Users -> Manage
  2. Click on Search Tools, you will see these filters:
    image
  3. Apply the patch
  4. Go to Users -> Manage
  5. Click on Search Tools, you will see these filters:
    image
  6. You now have a filter for the Last Visit Date
  7. Check if the filter works as expected.
@roland-d roland-d added this to the Joomla! 3.6.0 milestone Apr 30, 2016
@joomla-cms-bot joomla-cms-bot removed this from the Joomla! 3.6.0 milestone Apr 30, 2016
@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented Apr 30, 2016

Can you change the order please so that last visit is before registration in the list of filters - that way it matches the column order


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137.

@roland-d

This comment has been minimized.

Copy link
Contributor Author

roland-d commented Apr 30, 2016

@brianteeman Thank you for the suggestion. Will do.

onchange="this.form.submit();"
>
<option value="">COM_USERS_OPTION_FILTER_LAST_VISIT_DATE</option>
</field>

This comment has been minimized.

Copy link
@brianteeman

brianteeman Apr 30, 2016

Contributor

Can you change the order please so that last visit is before registration in the list of filters - that way it matches the column order

<option value=""><?php echo JText::_('COM_USERS_OPTION_FILTER_LAST_VISIT_DATE');?></option>
<?php echo JHtml::_('select.options', Usershelper::getRangeOptions(), 'value', 'text', $this->state->get('filter.lastvisitrange'));?>
</select>

This comment has been minimized.

Copy link
@brianteeman

brianteeman Apr 30, 2016

Contributor

Can you change the order please so that last visit is before registration in the list of filters - that way it matches the column order

@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented Apr 30, 2016

Its something we've been trying to do everywhere to ensure consistency

On 30 April 2016 at 10:59, RolandD notifications@github.com wrote:

@brianteeman https://github.com/brianteeman Thank you for the
suggestion. Will do.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10137 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@roland-d

This comment has been minimized.

Copy link
Contributor Author

roland-d commented Apr 30, 2016

@brianteeman You are absolutely correct, it just never crossed my mind :) Change has been committed.

@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented Apr 30, 2016

And in the hathor override please

On 30 April 2016 at 11:03, RolandD notifications@github.com wrote:

@brianteeman https://github.com/brianteeman You are absolutely correct,
it just never crossed my mind :) Change has been committed.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10137 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

@roland-d

This comment has been minimized.

Copy link
Contributor Author

roland-d commented Apr 30, 2016

Hathor is there as well now.

@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented Apr 30, 2016

I have tested this item successfully on ba59e2e


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137.

@pe7er

This comment has been minimized.

Copy link
Contributor

pe7er commented Apr 30, 2016

I have tested this item successfully on ba59e2e

Tested successfully.

I suggest to add "Never" as final option in the Select Last Visit Date drop down list.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137.

@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented Apr 30, 2016

RTC - new feature so 3.6 milestone


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137.

@joomla-cms-bot joomla-cms-bot added the RTC label Apr 30, 2016
@brianteeman brianteeman added this to the Joomla! 3.6.0 milestone Apr 30, 2016
@joomla-cms-bot

This comment has been minimized.

Copy link

joomla-cms-bot commented May 1, 2016

This PR has received new commits.

CC: @brianteeman, @pe7er


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137.

@roland-d

This comment has been minimized.

Copy link
Contributor Author

roland-d commented May 1, 2016

@pe7er Good suggestion to add the never option. This has now been added.

@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented May 1, 2016

Set back to pending as there have been changes that need new tests


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137.

@joomla-cms-bot joomla-cms-bot removed the RTC label May 1, 2016
@MATsxm

This comment has been minimized.

Copy link
Member

MATsxm commented May 1, 2016

I have tested this item successfully on 1357626

everything looks good - function/order/Never option...
Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137.

@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented May 1, 2016

I have tested this item successfully on 1357626


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137.

@brianteeman

This comment has been minimized.

Copy link
Contributor

brianteeman commented May 1, 2016

Back to RTC ;)


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137.

@joomla-cms-bot joomla-cms-bot added the RTC label May 1, 2016
@rdeutz rdeutz merged commit 93794d8 into joomla:staging May 2, 2016
2 checks passed
2 checks passed
JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@brianteeman brianteeman removed the RTC label May 11, 2016
@roland-d roland-d deleted the roland-d:add-lastvisitdate-to-userlist branch Jan 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.