New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a Last Visit Date filter on the user list #10137
Conversation
Can you change the order please so that last visit is before registration in the list of filters - that way it matches the column order This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
@brianteeman Thank you for the suggestion. Will do. |
onchange="this.form.submit();" | ||
> | ||
<option value="">COM_USERS_OPTION_FILTER_LAST_VISIT_DATE</option> | ||
</field> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you change the order please so that last visit is before registration in the list of filters - that way it matches the column order
Its something we've been trying to do everywhere to ensure consistency On 30 April 2016 at 10:59, RolandD notifications@github.com wrote:
Brian Teeman |
@brianteeman You are absolutely correct, it just never crossed my mind :) Change has been committed. |
And in the hathor override please On 30 April 2016 at 11:03, RolandD notifications@github.com wrote:
Brian Teeman |
Hathor is there as well now. |
I have tested this item ✅ successfully on ba59e2e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
I have tested this item ✅ successfully on ba59e2e I suggest to add "Never" as final option in the Select Last Visit Date drop down list. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
RTC - new feature so 3.6 milestone This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
This PR has received new commits. CC: @brianteeman, @pe7er This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
@pe7er Good suggestion to add the never option. This has now been added. |
Set back to pending as there have been changes that need new tests This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
I have tested this item ✅ successfully on 1357626 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
I have tested this item ✅ successfully on 1357626 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
Back to RTC ;) This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10137. |
Summary of Changes
The user list has a number of filters, one of them is the registration date. However I think that the last visit date is more useful as it can show when a user last came to the site. If that is too long ago the user account may be considered obsolete. So this PR adds a filter for the last visit date.
Testing Instructions