Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Search PHP Notice when saving filter #10192

Merged
merged 1 commit into from May 3, 2016

Conversation

chrisdavenport
Copy link
Contributor

@chrisdavenport chrisdavenport commented May 2, 2016

Pull Request for Issue #10187 .

Summary of Changes

Start and end dates for filters are stored in params and not as individual table columns.

Testing Instructions

  • Set error reporting to maximum.
  • Create a new filter or modify an existing one. You should see "PHP Notice: Undefined property: FinderTableFilter::$d2 in ROOT/administrator/components/com_finder/tables/filter.php on line 83"
  • Apply this PR and try again.
  • Also try entering a start date which is after the end date. After saving the dates should be swapped.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 2be76dd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10192.

1 similar comment
@brianteeman
Copy link
Contributor

I have tested this item ✅ successfully on 2be76dd


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10192.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10192.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label May 2, 2016
@brianteeman brianteeman added this to the Joomla! 3.6.0 milestone May 2, 2016
@rdeutz rdeutz merged commit ecac79d into joomla:staging May 3, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label May 3, 2016
@chrisdavenport chrisdavenport deleted the patch-3 branch May 3, 2016 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants