[com_categories] Cleaner tree view #10213

andrepereiradasilva · 2016-05-03T13:45:38Z

Pull Request for Improvement.

Summary of Changes

This PR is a proposal to make a better visual to the trees in the list views of isis.

If accepted i can do in the other tree views (tags, menu items, etc).

As you can see from the code difference is just one line of code that changes.

Before PR (current scenario)

After PR (proposed scenario)

Testing Instructions

Use latest staging (the difference is more visible)
Apply patch
Go to content categories and check the visual difference
Do also some searches (with and without patch to check the difference)

brianteeman · 2016-05-03T14:15:14Z

Not convinced myself that this is any better than the current option. I
find that as the symbol looks like a letter L my eyes try to read it.

On 3 May 2016 at 14:45, andrepereiradasilva notifications@github.com
wrote:

Pull Request for Improvement.
Summary of Changes

This PR is a proposal to make a better visual to the trees in the list
views of isis.

If accepted i can do in the other tree views (tags, menu items, etc).

As you can see from the code difference is just one line of code that
changes.
Before PR (current scenario)

[image: image]
https://cloud.githubusercontent.com/assets/9630530/14984924/1e3146f2-113d-11e6-8782-1528e84ea7a8.png
After PR (proposed scenario)

[image: image]
https://cloud.githubusercontent.com/assets/9630530/14984919/1a8e8190-113d-11e6-8372-425be9e6e13f.png
Testing Instructions

Use latest staging (the difference is more visible)

Apply patch

Go to content categories and check the visual difference

Do also some searches (with and without patch to check the
difference)

You can view, comment on, or merge this pull request online at:

#10213
Commit Summary

cleaner tree

File Changes

M
administrator/components/com_categories/views/categories/tmpl/default.php
https://github.com/joomla/joomla-cms/pull/10213/files#diff-0 (2)

Patch Links:

https://github.com/joomla/joomla-cms/pull/10213.patch

https://github.com/joomla/joomla-cms/pull/10213.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#10213

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

andrepereiradasilva · 2016-05-03T14:25:50Z

we can add another symbol.
The main propose of this is to better understand the tree view and it's levels just by looking.

brianteeman · 2016-05-03T14:36:40Z

I understand the aim - I was just pointing out an issue (for me) with the
chosen symbol

On 3 May 2016 at 15:25, andrepereiradasilva notifications@github.com
wrote:

we can add another symbol.
The main propose of this is to better understand the tree view and it's
levels.

—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#10213 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

brianteeman · 2016-05-03T19:00:06Z

What do you think about changing your three vertical dots with a dash or even an elipsis (love the muted class you are using) and then using ↳ ↳

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

andrepereiradasilva · 2016-05-03T22:11:08Z

ok! will give it another try when i have time.

BurtNL · 2016-05-04T09:42:33Z

I have tested this item ✅ successfully on 28ffdc3

Tested, works as described. The view has become clearer to me.
Looking forward to the setup as proposed by @brianteeman

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

andrepereiradasilva · 2016-05-04T10:28:16Z

well i think it's a matter of taste.

some examples:

andrepereiradasilva · 2016-05-04T10:29:14Z

BTW, htmlentities used http://www.w3schools.com/charsets/ref_utf_box.asp

andrepereiradasilva · 2016-05-04T10:31:09Z

i prefer the last one because it's cleaner.

BurtNL · 2016-05-04T10:57:00Z

I agree with @andrepereiradasilva, I prefer the last example too.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

pe7er · 2016-05-08T10:18:12Z

Great! Thanks @andrepereiradasilva, this is a huge UX improvement!

IMHO this version is the most clear one:

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

andrepereiradasilva · 2016-05-08T10:20:32Z

lol, each one likes a different one.
I think this is going to have to be a PLT decision.

The goal is to apply this to all the items with tree structures (menus, access level, tags, categories, etc) so we can have a consistent tree structure across all views.

pinging @wilsonge for a decision.

brianteeman · 2016-05-08T10:34:23Z

Set to Needs Review - not sure if its PLT or UI team on this one

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

wilsonge · 2016-05-08T10:59:21Z

I prefer the last one (i.e. https://cloud.githubusercontent.com/assets/9630530/15011868/1e7a8592-11ec-11e6-9e4e-69e91f4a7292.png) - I think the arrows Brian proposed are not rendering consistently between platforms (I can see large differences between windows and mac). So I think this is the next best solution

andrepereiradasilva · 2016-05-08T16:46:12Z

is that a opinion or a decision?

brianteeman · 2016-05-16T20:17:26Z

I think I agree with @wilsonge

Can you update the PR to use that styling so it can be tested in real life

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

andrepereiradasilva · 2016-05-16T21:36:21Z

yes, once i remember the character i used for the dash 😉

joomla-cms-bot · 2016-05-16T21:43:26Z

This PR has received new commits.

CC: @BurtNL

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

andrepereiradasilva · 2016-05-16T21:43:34Z

ok done

brianteeman · 2016-05-16T21:46:49Z

Are you sure thats the correct symbol the dash looks very narrow

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

andrepereiradasilva · 2016-05-16T21:50:48Z

hum Mac right?
in Windows

brianteeman · 2016-05-16T21:53:44Z

yes - a mac ;)

On 16 May 2016 at 22:50, andrepereiradasilva notifications@github.com
wrote:

hum Mac right?
in Windows
[image: image]
https://cloud.githubusercontent.com/assets/9630530/15305025/9f136ebe-1bb8-11e6-85e8-da0ccb4da20c.png

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#10213 (comment)

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

joomla-cms-bot · 2016-05-16T21:58:53Z

This PR has received new commits.

CC: @BurtNL

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

andrepereiradasilva · 2016-05-16T21:59:05Z

is ok now?

brianteeman · 2016-05-16T22:02:21Z

I have tested this item ✅ successfully on e0d3450

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

brianteeman · 2016-05-16T22:02:56Z

Yes thats it - screenshot for reference

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

andrepereiradasilva · 2016-05-17T10:34:53Z

ok @wilsonge, so do we have an ok on this tree view?

wilsonge · 2016-05-17T11:31:29Z

Yes :)

andrepereiradasilva · 2016-05-17T11:40:32Z

ok then, so when this gets tested and eventually merged i will do PR for the others tree like structures (tags, menus and user groups).

MATsxm · 2016-05-17T11:41:46Z

I have tested this item ✅ successfully on e0d3450

Like this way 👍 - thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10213.}

wilsonge · 2016-05-17T12:02:47Z

You'd better get moving then :) Merged with two good tests!

andrepereiradasilva · 2016-05-17T12:25:47Z

no pressure right? ;)

cleaner tree

28ffdc3

joomla-cms-bot added the PR-staging label May 3, 2016

new view

e4f844b

and now?

e0d3450

wilsonge added this to the Joomla 3.6.0 milestone May 17, 2016

wilsonge merged commit 3b8e664 into joomla:staging May 17, 2016

andrepereiradasilva deleted the patch-7 branch May 17, 2016 12:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[com_categories] Cleaner tree view #10213

[com_categories] Cleaner tree view #10213

andrepereiradasilva commented May 3, 2016 •

edited by brianteeman

brianteeman commented May 3, 2016

andrepereiradasilva commented May 3, 2016 •

edited

brianteeman commented May 3, 2016

brianteeman commented May 3, 2016

andrepereiradasilva commented May 3, 2016

BurtNL commented May 4, 2016

andrepereiradasilva commented May 4, 2016 •

edited

andrepereiradasilva commented May 4, 2016

andrepereiradasilva commented May 4, 2016

BurtNL commented May 4, 2016

pe7er commented May 8, 2016

andrepereiradasilva commented May 8, 2016 •

edited

brianteeman commented May 8, 2016

wilsonge commented May 8, 2016

andrepereiradasilva commented May 8, 2016

brianteeman commented May 16, 2016

andrepereiradasilva commented May 16, 2016

joomla-cms-bot commented May 16, 2016

andrepereiradasilva commented May 16, 2016

brianteeman commented May 16, 2016

andrepereiradasilva commented May 16, 2016

brianteeman commented May 16, 2016

joomla-cms-bot commented May 16, 2016

andrepereiradasilva commented May 16, 2016

brianteeman commented May 16, 2016

brianteeman commented May 16, 2016

andrepereiradasilva commented May 17, 2016

wilsonge commented May 17, 2016

andrepereiradasilva commented May 17, 2016

MATsxm commented May 17, 2016

wilsonge commented May 17, 2016

andrepereiradasilva commented May 17, 2016

[com_categories] Cleaner tree view #10213

[com_categories] Cleaner tree view #10213

Conversation

andrepereiradasilva commented May 3, 2016 • edited by brianteeman

Summary of Changes

Before PR (current scenario)

After PR (proposed scenario)

Testing Instructions

brianteeman commented May 3, 2016

andrepereiradasilva commented May 3, 2016 • edited

brianteeman commented May 3, 2016

brianteeman commented May 3, 2016

andrepereiradasilva commented May 3, 2016

BurtNL commented May 4, 2016

andrepereiradasilva commented May 4, 2016 • edited

andrepereiradasilva commented May 4, 2016

andrepereiradasilva commented May 4, 2016

BurtNL commented May 4, 2016

pe7er commented May 8, 2016

andrepereiradasilva commented May 8, 2016 • edited

brianteeman commented May 8, 2016

wilsonge commented May 8, 2016

andrepereiradasilva commented May 8, 2016

brianteeman commented May 16, 2016

andrepereiradasilva commented May 16, 2016

joomla-cms-bot commented May 16, 2016

andrepereiradasilva commented May 16, 2016

brianteeman commented May 16, 2016

andrepereiradasilva commented May 16, 2016

brianteeman commented May 16, 2016

joomla-cms-bot commented May 16, 2016

andrepereiradasilva commented May 16, 2016

brianteeman commented May 16, 2016

brianteeman commented May 16, 2016

andrepereiradasilva commented May 17, 2016

wilsonge commented May 17, 2016

andrepereiradasilva commented May 17, 2016

MATsxm commented May 17, 2016

wilsonge commented May 17, 2016

andrepereiradasilva commented May 17, 2016

andrepereiradasilva commented May 3, 2016 •

edited by brianteeman

andrepereiradasilva commented May 3, 2016 •

edited

andrepereiradasilva commented May 4, 2016 •

edited

andrepereiradasilva commented May 8, 2016 •

edited