Improving Login menu language strings #10336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -93,12 +93,13 @@ COM_USERS_ERROR_SECRET_CODE_WITHOUT_TFA="You have entered a Secret Code but two | |||
| COM_USERS_FIELD_CATEGORY_ID_LABEL="Category" | |||
| COM_USERS_FIELD_ID_LABEL="ID" | |||
| COM_USERS_FIELD_LOGIN_MENUITEM="Menu Item" | |||
| COM_USERS_FIELD_LOGIN_REDIRECT_CHOICE_DESC="'Custom URL' lets you manually enter any internal url in the Redirect field. 'Menu Item' lets you directly select an existing menu item.<br />For a multilingual site, it is advised to use 'Menu Item'." | |||
| COM_USERS_FIELD_LOGIN_REDIRECT_PLACEHOLDER="index.php?Itemid=999&lang=en-GB" | |||
| COM_USERS_FIELD_LOGIN_REDIRECT_CHOICE_DESC="'Internal URL' lets you manually enter any internal url in the Redirect field. 'Menu Item' lets you directly select an existing menu item.<br />For a multilingual site, it is advised to use 'Menu Item'." | |||
There was a problem hiding this comment.
can you change "advised" to "recommended"
|
Made some comments inline |
|
it seems travis is still recovering from today merge frenzy. |
|
@brianteeman |
| @@ -196,11 +196,11 @@ JFIELD_LANGUAGE_DESC="Assign a language to this article." | |||
| JFIELD_LANGUAGE_LABEL="Language" | |||
| JFIELD_LOGIN_IMAGE_DESC="Select or upload an image to display on login page." | |||
| JFIELD_LOGIN_IMAGE_LABEL="Login Image" | |||
| JFIELD_LOGIN_REDIRECT_URL_DESC="If an URL is entered here, users will be redirected to it after login. The URL must not be an external one." | |||
| JFIELD_LOGIN_REDIRECT_URL_DESC="If a URL is entered here, users will be redirected to it after login.<br />The URL must be internal (ex: index.php?Itemid=999)." | |||
There was a problem hiding this comment.
Sorry one last change
ex should be eg
No periods just as this
internal (eg: index.php?Itemid=999)."
|
Sorry one last change and then we can make it RTC |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10336. |
|
I have tested this item ✅ successfully on b09ce72 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10336. |
|
please remove the label @joomla-cms-bot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says. Changed Custom URL to Internal URL and added a placeholder.
After patch:
