[mod_login] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8') #10406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have tested this item ✅ successfully on 8a3e663 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
1 similar comment
|
I have tested this item ✅ successfully on 8a3e663 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
| } endif; ?> | ||
| <?php if ($params->get('name') == 0) : ?> | ||
| <?php echo JText::sprintf('MOD_LOGIN_HINAME', htmlspecialchars($user->get('name')), ENT_COMPAT, 'UTF-8'); ?> | ||
| <?php else : ?> |
There was a problem hiding this comment.
Parentheses is in the wrong place.
|
@brianteeman same thing. Please remove the RTC. |
|
@zero-24 @andrepereiradasilva Please see zero-24#13 |
|
This PR has received new commits. CC: @brianteeman, @BurtNL This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
|
seems fine to me now. |
|
Back to Pending. Thanks @wojsmol and @andrepereiradasilva This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
|
This PR has received new commits. CC: @brianteeman, @BurtNL This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
|
I have tested this item ✅ successfully on fd6e877 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
|
I have tested this item ✅ successfully on fd6e877 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
|
Thanks everybody |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #10399 .
Summary of Changes
Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')
Testing Instructions