[mod_articles_popular]Code style #10576
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <field name="relative_date" type="text" default="30" | ||
| <field | ||
| name="relative_date" | ||
| type="text" default="30" |
There was a problem hiding this comment.
move default down?
|
I have tested this item ✅ successfully on 40b8104 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10576. |
| <fieldset | ||
| name="advanced"> | ||
|
|
||
| <fieldsetname="advanced"> |
There was a problem hiding this comment.
missing space between fieldset and name ...
|
I have tested this item 🔴 unsuccessfully on 40b8104 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10576. |
|
This PR has received new commits. CC: @andrepereiradasilva, @JoomliC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10576. |
|
I have tested this item ✅ successfully on 2bad85a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10576. |
1 similar comment
|
I have tested this item ✅ successfully on 2bad85a This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10576. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10576. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Code style changes for mod_articles_popular
Testing Instructions
code review
cc @JoomliC @andrepereiradasilva